fix: Fix http image registry edit exception (#9460)
Some checks failed
SonarCloud Scan / SonarCloud (push) Failing after 2s

This commit is contained in:
ssongliu 2025-07-08 18:18:00 +08:00 committed by GitHub
parent 8ec5a5bd4b
commit 0d548c7df9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -155,10 +155,12 @@ func (u *ImageRepoService) Update(req dto.ImageRepoUpdate) error {
needRestart = true
}
if repo.Protocol == "http" && req.Protocol == "http" {
if err := u.handleRegistries(req.DownloadUrl, repo.DownloadUrl, "update"); err != nil {
return fmt.Errorf("update registry %s => %s failed, err: %v", repo.DownloadUrl, req.DownloadUrl, err)
if repo.DownloadUrl != req.DownloadUrl {
if err := u.handleRegistries(req.DownloadUrl, repo.DownloadUrl, "update"); err != nil {
return fmt.Errorf("update registry %s => %s failed, err: %v", repo.DownloadUrl, req.DownloadUrl, err)
}
needRestart = true
}
needRestart = repo.DownloadUrl == req.DownloadUrl
}
if repo.Protocol == "https" && req.Protocol == "http" {
if err := u.handleRegistries(req.DownloadUrl, "", "create"); err != nil {