From 50dcb6c7e4c4565c485a2e566f0386c042f8fa51 Mon Sep 17 00:00:00 2001 From: CityFun <31820853+zhengkunwang223@users.noreply.github.com> Date: Thu, 31 Jul 2025 17:21:33 +0800 Subject: [PATCH] fix: Fix the issue where certificate deletion fails due to network issues (#9775) --- agent/app/service/website_ssl.go | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/agent/app/service/website_ssl.go b/agent/app/service/website_ssl.go index 97a64cad9..b16669dca 100644 --- a/agent/app/service/website_ssl.go +++ b/agent/app/service/website_ssl.go @@ -471,16 +471,22 @@ func (w WebsiteSSLService) Delete(ids []uint) error { continue } if websiteSSL.Provider != constant.Manual && websiteSSL.Provider != constant.SelfSigned { - acmeAccount, err := websiteAcmeRepo.GetFirst(repo.WithByID(websiteSSL.AcmeAccountID)) - if err != nil { - return err - } - client, err := ssl.NewAcmeClient(acmeAccount, getSystemProxy(acmeAccount.UseProxy)) - if err != nil { - return err - } go func() { - _ = client.RevokeSSL([]byte(websiteSSL.Pem)) + acmeAccount, err := websiteAcmeRepo.GetFirst(repo.WithByID(websiteSSL.AcmeAccountID)) + if err != nil { + global.LOG.Errorf("Failed to get acme account for SSL revoke, err: %v", err) + return + } + client, err := ssl.NewAcmeClient(acmeAccount, getSystemProxy(acmeAccount.UseProxy)) + if err != nil { + global.LOG.Errorf("Failed to create ACME client for SSL revoke, err: %v", err) + return + } + err = client.RevokeSSL([]byte(websiteSSL.Pem)) + if err != nil { + global.LOG.Errorf("Failed to revoke SSL for domain %s, err: %v", websiteSSL.PrimaryDomain, err) + return + } }() } _ = websiteSSLRepo.DeleteBy(repo.WithByID(id))