From 514d68d395d5b62ead0476dca8c0e86a9e623e62 Mon Sep 17 00:00:00 2001 From: ssongliu <73214554+ssongliu@users.noreply.github.com> Date: Thu, 29 Feb 2024 11:08:18 +0800 Subject: [PATCH] =?UTF-8?q?fix:=20=E8=A7=A3=E5=86=B3=E5=AE=B9=E5=99=A8?= =?UTF-8?q?=E8=B5=84=E6=BA=90=E4=BD=BF=E7=94=A8=E7=8E=87=E8=8E=B7=E5=8F=96?= =?UTF-8?q?=E9=94=99=E8=AF=AF=E7=9A=84=E9=97=AE=E9=A2=98=20(#4023)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs #4022 --- backend/app/service/container.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/backend/app/service/container.go b/backend/app/service/container.go index fe1d04d80..71ad92827 100644 --- a/backend/app/service/container.go +++ b/backend/app/service/container.go @@ -5,7 +5,6 @@ import ( "encoding/base64" "encoding/json" "fmt" - "github.com/pkg/errors" "io" "os" "os/exec" @@ -18,6 +17,8 @@ import ( "time" "unicode/utf8" + "github.com/pkg/errors" + "github.com/1Panel-dev/1Panel/backend/app/dto" "github.com/1Panel-dev/1Panel/backend/buserr" "github.com/1Panel-dev/1Panel/backend/constant" @@ -683,7 +684,6 @@ func (u *ContainerService) ContainerLogs(wsConn *websocket.Conn, containerType, global.LOG.Errorf("read bytes from log failed, err: %v", err) continue } - // check if the bytes is valid utf8 if !utf8.Valid(buffer[:n]) { continue } @@ -723,7 +723,6 @@ func (u *ContainerService) ContainerStats(id string) (*dto.ContainerStats, error if cache, ok := stats.MemoryStats.Stats["cache"]; ok { data.Cache = float64(cache) / 1024 / 1024 } - data.Memory = data.Memory - data.Cache data.NetworkRX, data.NetworkTX = calculateNetwork(stats.Networks) data.ShotTime = stats.Read return &data, nil @@ -791,7 +790,7 @@ func calculateCPUPercentUnix(stats *types.StatsJSON) float64 { } func calculateMemPercentUnix(memStats types.MemoryStats) float64 { memPercent := 0.0 - memUsage := float64(memStats.Usage - memStats.Stats["cache"]) + memUsage := float64(memStats.Usage) memLimit := float64(memStats.Limit) if memUsage > 0.0 && memLimit > 0.0 { memPercent = (memUsage / memLimit) * 100.0 @@ -895,6 +894,7 @@ func loadCpuAndMem(client *client.Client, container string) dto.ContainerListSta data.MemoryCache = stats.MemoryStats.Stats["cache"] data.MemoryUsage = stats.MemoryStats.Usage data.MemoryLimit = stats.MemoryStats.Limit + data.MemoryPercent = calculateMemPercentUnix(stats.MemoryStats) return data }