From 6752c5a403753abc3092409b4f2793f11d810ae7 Mon Sep 17 00:00:00 2001 From: ssongliu Date: Mon, 17 Nov 2025 15:51:07 +0800 Subject: [PATCH] chore: Clean up some unused code --- agent/utils/cloud_storage/client/s3.go | 8 ++------ core/utils/cloud_storage/client/google_drive.go | 4 +--- core/utils/cloud_storage/client/up.go | 3 +-- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/agent/utils/cloud_storage/client/s3.go b/agent/utils/cloud_storage/client/s3.go index 2afc2fe1d..3a0064714 100644 --- a/agent/utils/cloud_storage/client/s3.go +++ b/agent/utils/cloud_storage/client/s3.go @@ -126,12 +126,8 @@ func (s s3Client) Upload(src, target string) (bool, error) { } func (s s3Client) Download(src, target string) (bool, error) { - if _, err := os.Stat(target); err != nil { - if os.IsNotExist(err) { - os.Remove(target) - } else { - return false, err - } + if _, err := os.Stat(target); err == nil { + _ = os.Remove(target) } file, err := os.Create(target) if err != nil { diff --git a/core/utils/cloud_storage/client/google_drive.go b/core/utils/cloud_storage/client/google_drive.go index 11a6eb245..a426781b0 100644 --- a/core/utils/cloud_storage/client/google_drive.go +++ b/core/utils/cloud_storage/client/google_drive.go @@ -80,11 +80,9 @@ func (g *googleDriveClient) Delete(pathItem string) (bool, error) { if len(fileInfo.ID) == 0 { return false, fmt.Errorf("no such file %s", pathItem) } - res, err := g.googleRequest("https://www.googleapis.com/drive/v3/files/"+fileInfo.ID, http.MethodDelete, nil, nil) - if err != nil { + if _, err := g.googleRequest("https://www.googleapis.com/drive/v3/files/"+fileInfo.ID, http.MethodDelete, nil, nil); err != nil { return false, err } - fmt.Println(string(res)) return true, nil } diff --git a/core/utils/cloud_storage/client/up.go b/core/utils/cloud_storage/client/up.go index 4255e7099..21d5373c8 100644 --- a/core/utils/cloud_storage/client/up.go +++ b/core/utils/cloud_storage/client/up.go @@ -1,7 +1,6 @@ package client import ( - "fmt" "path" "github.com/upyun/go-sdk/upyun" @@ -34,7 +33,7 @@ func (o upClient) ListBuckets() ([]interface{}, error) { func (s upClient) Upload(src, target string) (bool, error) { if _, err := s.client.GetInfo(path.Dir(target)); err != nil { if err := s.client.Mkdir(path.Dir(target)); err != nil { - fmt.Println(err) + return false, err } } if err := s.client.Put(&upyun.PutObjectConfig{