1Panel-dev/1Panel
1
1
Fork 0
mirror of https://github.com/1Panel-dev/1Panel.git synced 2025-12-17 21:08:25 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: Node.js 运行环境外部映射端口增加校验 (#2808)

Browse source
This commit is contained in:
zhengkunwang 2023-11-05 21:41:31 +08:00 • committed by GitHub
parent e43de97890
commit 9d1757dba6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
backend/app/service/runtime.go
View file

@ -87,6 +87,11 @@ func (r *RuntimeService) Create(create request.RuntimeCreate) (err error) {
if err = checkPortExist(create.Port); err != nil { if err = checkPortExist(create.Port); err != nil {
return err return err
} }
for _, export := range create.ExposedPorts {
if err = checkPortExist(export.HostPort); err != nil {
return err
}
}
if containerName, ok := create.Params["CONTAINER_NAME"]; ok { if containerName, ok := create.Params["CONTAINER_NAME"]; ok {
if err := checkContainerName(containerName.(string)); err != nil { if err := checkContainerName(containerName.(string)); err != nil {
return err return err
@ -342,6 +347,11 @@ func (r *RuntimeService) Update(req request.RuntimeUpdate) error {
} }
runtime.Port = req.Port runtime.Port = req.Port
} }
for _, export := range req.ExposedPorts {
if err = checkPortExist(export.HostPort); err != nil {
return err
}
}
if containerName, ok := req.Params["CONTAINER_NAME"]; ok { if containerName, ok := req.Params["CONTAINER_NAME"]; ok {
envs, err := gotenv.Unmarshal(runtime.Env) envs, err := gotenv.Unmarshal(runtime.Env)
if err != nil { if err != nil {

4
frontend/src/views/website/runtime/node/operate/index.vue
View file

@ -256,7 +256,6 @@ const rules = ref<any>({
HOST_IP: [Rules.requiredSelect], HOST_IP: [Rules.requiredSelect],
EXEC_SCRIPT: [Rules.requiredSelect], EXEC_SCRIPT: [Rules.requiredSelect],
CONTAINER_NAME: [Rules.requiredInput, Rules.containerName], CONTAINER_NAME: [Rules.requiredInput, Rules.containerName],
CUSTOM_SCRIPT: [Rules.requiredInput],
}, },
}); });
const scripts = ref<Runtime.NodeScripts[]>([]); const scripts = ref<Runtime.NodeScripts[]>([]);
@ -456,7 +455,8 @@ const getRuntime = async (id: number) => {
runtime.exposedPorts = data.exposedPorts || []; runtime.exposedPorts = data.exposedPorts || [];
editParams.value = data.appParams; editParams.value = data.appParams;
searchApp(data.appID); searchApp(data.appID);
if (data.params['CUSTOM_SCRIPT'] == '0') { if (data.params['CUSTOM_SCRIPT'] == undefined || data.params['CUSTOM_SCRIPT'] == '0') {
data.params['CUSTOM_SCRIPT'] = '0';
getScripts(); getScripts();
} }
open.value = true; open.value = true;