feat: 计划任务备份数据库增加任务日志 (#6717)

This commit is contained in:
ssongliu 2024-10-15 16:03:21 +08:00 committed by GitHub
parent 07bdcdc91b
commit f3fd02fcb3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 396 additions and 258 deletions

View file

@ -4,14 +4,15 @@ import (
"context" "context"
"encoding/json" "encoding/json"
"fmt" "fmt"
"github.com/1Panel-dev/1Panel/agent/app/task"
"github.com/1Panel-dev/1Panel/agent/i18n"
"io/fs" "io/fs"
"os" "os"
"path" "path"
"strings" "strings"
"time" "time"
"github.com/1Panel-dev/1Panel/agent/app/task"
"github.com/1Panel-dev/1Panel/agent/i18n"
"github.com/1Panel-dev/1Panel/agent/buserr" "github.com/1Panel-dev/1Panel/agent/buserr"
"github.com/1Panel-dev/1Panel/agent/app/dto" "github.com/1Panel-dev/1Panel/agent/app/dto"
@ -103,7 +104,8 @@ func backupDatabaseWithTask(parentTask *task.Task, resourceKey, tmpDir, name str
return err return err
} }
parentTask.LogStart(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase)) parentTask.LogStart(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase))
if err := handleMysqlBackup(db.MysqlName, resourceKey, db.Name, tmpDir, fmt.Sprintf("%s.sql.gz", name)); err != nil { databaseHelper := DatabaseHelper{Database: db.MysqlName, DBType: resourceKey, Name: db.Name}
if err := handleMysqlBackup(databaseHelper, parentTask, tmpDir, fmt.Sprintf("%s.sql.gz", name), ""); err != nil {
return err return err
} }
parentTask.LogSuccess(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase)) parentTask.LogSuccess(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase))
@ -113,7 +115,8 @@ func backupDatabaseWithTask(parentTask *task.Task, resourceKey, tmpDir, name str
return err return err
} }
parentTask.LogStart(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase)) parentTask.LogStart(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase))
if err := handlePostgresqlBackup(db.PostgresqlName, db.Name, tmpDir, fmt.Sprintf("%s.sql.gz", name)); err != nil { databaseHelper := DatabaseHelper{Database: db.PostgresqlName, DBType: resourceKey, Name: db.Name}
if err := handlePostgresqlBackup(databaseHelper, parentTask, tmpDir, fmt.Sprintf("%s.sql.gz", name), ""); err != nil {
return err return err
} }
parentTask.LogSuccess(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase)) parentTask.LogSuccess(task.GetTaskName(db.Name, task.TaskBackup, task.TaskScopeDatabase))
@ -257,7 +260,7 @@ func handleAppRecover(install *model.AppInstall, parentTask *task.Task, recoverF
Name: database.Name, Name: database.Name,
DetailName: db.Name, DetailName: db.Name,
File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, install.Name), File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, install.Name),
}, true); err != nil { }, parentTask, true); err != nil {
t.LogFailedWithErr(taskName, err) t.LogFailedWithErr(taskName, err)
return err return err
} }
@ -286,7 +289,7 @@ func handleAppRecover(install *model.AppInstall, parentTask *task.Task, recoverF
Name: newDB.MysqlName, Name: newDB.MysqlName,
DetailName: newDB.Name, DetailName: newDB.Name,
File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, install.Name), File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, install.Name),
}, true); err != nil { }, parentTask, true, ""); err != nil {
t.LogFailedWithErr(taskName, err) t.LogFailedWithErr(taskName, err)
return err return err
} }

View file

@ -9,11 +9,13 @@ import (
"time" "time"
"github.com/1Panel-dev/1Panel/agent/constant" "github.com/1Panel-dev/1Panel/agent/constant"
"github.com/1Panel-dev/1Panel/agent/i18n"
"github.com/1Panel-dev/1Panel/agent/buserr" "github.com/1Panel-dev/1Panel/agent/buserr"
"github.com/1Panel-dev/1Panel/agent/app/dto" "github.com/1Panel-dev/1Panel/agent/app/dto"
"github.com/1Panel-dev/1Panel/agent/app/model" "github.com/1Panel-dev/1Panel/agent/app/model"
"github.com/1Panel-dev/1Panel/agent/app/task"
"github.com/1Panel-dev/1Panel/agent/global" "github.com/1Panel-dev/1Panel/agent/global"
"github.com/1Panel-dev/1Panel/agent/utils/common" "github.com/1Panel-dev/1Panel/agent/utils/common"
"github.com/1Panel-dev/1Panel/agent/utils/files" "github.com/1Panel-dev/1Panel/agent/utils/files"
@ -26,7 +28,8 @@ func (u *BackupService) MysqlBackup(req dto.CommonBackup) error {
targetDir := path.Join(global.CONF.System.Backup, itemDir) targetDir := path.Join(global.CONF.System.Backup, itemDir)
fileName := fmt.Sprintf("%s_%s.sql.gz", req.DetailName, timeNow+common.RandStrAndNum(5)) fileName := fmt.Sprintf("%s_%s.sql.gz", req.DetailName, timeNow+common.RandStrAndNum(5))
if err := handleMysqlBackup(req.Name, req.Type, req.DetailName, targetDir, fileName); err != nil { databaseHelper := DatabaseHelper{Database: req.Name, DBType: req.Type, Name: req.DetailName}
if err := handleMysqlBackup(databaseHelper, nil, targetDir, fileName, req.TaskID); err != nil {
return err return err
} }
@ -46,7 +49,7 @@ func (u *BackupService) MysqlBackup(req dto.CommonBackup) error {
} }
func (u *BackupService) MysqlRecover(req dto.CommonRecover) error { func (u *BackupService) MysqlRecover(req dto.CommonRecover) error {
if err := handleMysqlRecover(req, false); err != nil { if err := handleMysqlRecover(req, nil, false, req.TaskID); err != nil {
return err return err
} }
return nil return nil
@ -90,26 +93,39 @@ func (u *BackupService) MysqlRecoverByUpload(req dto.CommonRecover) error {
} }
req.File = path.Dir(file) + "/" + fileName req.File = path.Dir(file) + "/" + fileName
if err := handleMysqlRecover(req, false); err != nil { if err := handleMysqlRecover(req, nil, false, req.TaskID); err != nil {
return err return err
} }
global.LOG.Info("recover from uploads successful!") global.LOG.Info("recover from uploads successful!")
return nil return nil
} }
func handleMysqlBackup(database, dbType, dbName, targetDir, fileName string) error { func handleMysqlBackup(db DatabaseHelper, parentTask *task.Task, targetDir, fileName, taskID string) error {
dbInfo, err := mysqlRepo.Get(commonRepo.WithByName(dbName), mysqlRepo.WithByMysqlName(database)) var (
err error
itemTask *task.Task
)
itemTask = parentTask
dbInfo, err := mysqlRepo.Get(commonRepo.WithByName(db.Name), mysqlRepo.WithByMysqlName(db.Database))
if err != nil { if err != nil {
return err return err
} }
cli, version, err := LoadMysqlClientByFrom(database) itemName := fmt.Sprintf("%s[%s] - %s", db.Database, db.DBType, db.Name)
if parentTask == nil {
itemTask, err = task.NewTaskWithOps(itemName, task.TaskBackup, task.TaskScopeDatabase, taskID, dbInfo.ID)
if err != nil { if err != nil {
return err return err
} }
}
backupDatabase := func(t *task.Task) error {
cli, version, err := LoadMysqlClientByFrom(db.Database)
if err != nil {
return err
}
backupInfo := client.BackupInfo{ backupInfo := client.BackupInfo{
Name: dbName, Name: db.Name,
Type: dbType, Type: db.DBType,
Version: version, Version: version,
Format: dbInfo.Format, Format: dbInfo.Format,
TargetDir: targetDir, TargetDir: targetDir,
@ -117,13 +133,36 @@ func handleMysqlBackup(database, dbType, dbName, targetDir, fileName string) err
Timeout: 300, Timeout: 300,
} }
if err := cli.Backup(backupInfo); err != nil { return cli.Backup(backupInfo)
return err
} }
return nil
itemTask.AddSubTask(i18n.GetMsgByKey("TaskBackup"), backupDatabase, nil)
if parentTask != nil {
return backupDatabase(parentTask)
}
return itemTask.Execute()
} }
func handleMysqlRecover(req dto.CommonRecover, isRollback bool) error { func handleMysqlRecover(req dto.CommonRecover, parentTask *task.Task, isRollback bool, taskID string) error {
var (
err error
itemTask *task.Task
)
itemTask = parentTask
dbInfo, err := mysqlRepo.Get(commonRepo.WithByName(req.DetailName), mysqlRepo.WithByMysqlName(req.Name))
if err != nil {
return err
}
itemName := fmt.Sprintf("%s[%s] - %s", req.Name, req.Type, req.DetailName)
if parentTask == nil {
itemTask, err = task.NewTaskWithOps(itemName, task.TaskRecover, task.TaskScopeDatabase, taskID, dbInfo.ID)
if err != nil {
return err
}
}
recoverDatabase := func(t *task.Task) error {
isOk := false isOk := false
fileOp := files.NewFileOp() fileOp := files.NewFileOp()
if !fileOp.Stat(req.File) { if !fileOp.Stat(req.File) {
@ -186,4 +225,11 @@ func handleMysqlRecover(req dto.CommonRecover, isRollback bool) error {
} }
isOk = true isOk = true
return nil return nil
}
itemTask.AddSubTask(i18n.GetMsgByKey("TaskRecover"), recoverDatabase, nil)
if parentTask != nil {
return recoverDatabase(parentTask)
}
return itemTask.Execute()
} }

View file

@ -9,6 +9,7 @@ import (
"time" "time"
"github.com/1Panel-dev/1Panel/agent/constant" "github.com/1Panel-dev/1Panel/agent/constant"
"github.com/1Panel-dev/1Panel/agent/i18n"
"github.com/1Panel-dev/1Panel/agent/buserr" "github.com/1Panel-dev/1Panel/agent/buserr"
"github.com/1Panel-dev/1Panel/agent/utils/common" "github.com/1Panel-dev/1Panel/agent/utils/common"
@ -16,6 +17,7 @@ import (
"github.com/1Panel-dev/1Panel/agent/app/dto" "github.com/1Panel-dev/1Panel/agent/app/dto"
"github.com/1Panel-dev/1Panel/agent/app/model" "github.com/1Panel-dev/1Panel/agent/app/model"
"github.com/1Panel-dev/1Panel/agent/app/task"
"github.com/1Panel-dev/1Panel/agent/global" "github.com/1Panel-dev/1Panel/agent/global"
"github.com/1Panel-dev/1Panel/agent/utils/files" "github.com/1Panel-dev/1Panel/agent/utils/files"
"github.com/1Panel-dev/1Panel/agent/utils/postgresql/client" "github.com/1Panel-dev/1Panel/agent/utils/postgresql/client"
@ -27,7 +29,8 @@ func (u *BackupService) PostgresqlBackup(req dto.CommonBackup) error {
targetDir := path.Join(global.CONF.System.Backup, itemDir) targetDir := path.Join(global.CONF.System.Backup, itemDir)
fileName := fmt.Sprintf("%s_%s.sql.gz", req.DetailName, timeNow+common.RandStrAndNum(5)) fileName := fmt.Sprintf("%s_%s.sql.gz", req.DetailName, timeNow+common.RandStrAndNum(5))
if err := handlePostgresqlBackup(req.Name, req.DetailName, targetDir, fileName); err != nil { databaseHelper := DatabaseHelper{Database: req.Name, DBType: req.Type, Name: req.DetailName}
if err := handlePostgresqlBackup(databaseHelper, nil, targetDir, fileName, req.TaskID); err != nil {
return err return err
} }
@ -46,7 +49,7 @@ func (u *BackupService) PostgresqlBackup(req dto.CommonBackup) error {
return nil return nil
} }
func (u *BackupService) PostgresqlRecover(req dto.CommonRecover) error { func (u *BackupService) PostgresqlRecover(req dto.CommonRecover) error {
if err := handlePostgresqlRecover(req, false); err != nil { if err := handlePostgresqlRecover(req, nil, false); err != nil {
return err return err
} }
return nil return nil
@ -90,42 +93,73 @@ func (u *BackupService) PostgresqlRecoverByUpload(req dto.CommonRecover) error {
} }
req.File = path.Dir(file) + "/" + fileName req.File = path.Dir(file) + "/" + fileName
if err := handlePostgresqlRecover(req, false); err != nil { if err := handlePostgresqlRecover(req, nil, false); err != nil {
return err return err
} }
global.LOG.Info("recover from uploads successful!") global.LOG.Info("recover from uploads successful!")
return nil return nil
} }
func handlePostgresqlBackup(database, dbName, targetDir, fileName string) error {
cli, err := LoadPostgresqlClientByFrom(database) func handlePostgresqlBackup(db DatabaseHelper, parentTask *task.Task, targetDir, fileName, taskID string) error {
var (
err error
itemTask *task.Task
)
itemTask = parentTask
itemName := fmt.Sprintf("%s - %s", db.Database, db.Name)
if parentTask == nil {
itemTask, err = task.NewTaskWithOps(itemName, task.TaskBackup, task.TaskScopeDatabase, taskID, db.ID)
if err != nil {
return err
}
}
backupDatabase := func(t *task.Task) error {
cli, err := LoadPostgresqlClientByFrom(db.Database)
if err != nil { if err != nil {
return err return err
} }
defer cli.Close() defer cli.Close()
backupInfo := pgclient.BackupInfo{ backupInfo := pgclient.BackupInfo{
Name: dbName, Name: db.Name,
TargetDir: targetDir, TargetDir: targetDir,
FileName: fileName, FileName: fileName,
Timeout: 300, Timeout: 300,
} }
if err := cli.Backup(backupInfo); err != nil { return cli.Backup(backupInfo)
return err
} }
return nil itemTask.AddSubTask(i18n.GetMsgByKey("TaskBackup"), backupDatabase, nil)
if parentTask != nil {
return backupDatabase(parentTask)
}
return itemTask.Execute()
} }
func handlePostgresqlRecover(req dto.CommonRecover, isRollback bool) error { func handlePostgresqlRecover(req dto.CommonRecover, parentTask *task.Task, isRollback bool) error {
var (
err error
itemTask *task.Task
)
dbInfo, err := postgresqlRepo.Get(commonRepo.WithByName(req.DetailName), postgresqlRepo.WithByPostgresqlName(req.Name))
if err != nil {
return err
}
itemTask = parentTask
if parentTask == nil {
itemTask, err = task.NewTaskWithOps("Redis", task.TaskRecover, task.TaskScopeDatabase, req.TaskID, dbInfo.ID)
if err != nil {
return err
}
}
recoverDatabase := func(t *task.Task) error {
isOk := false isOk := false
fileOp := files.NewFileOp() fileOp := files.NewFileOp()
if !fileOp.Stat(req.File) { if !fileOp.Stat(req.File) {
return buserr.WithName("ErrFileNotFound", req.File) return buserr.WithName("ErrFileNotFound", req.File)
} }
dbInfo, err := postgresqlRepo.Get(commonRepo.WithByName(req.DetailName), postgresqlRepo.WithByPostgresqlName(req.Name))
if err != nil {
return err
}
cli, err := LoadPostgresqlClientByFrom(req.Name) cli, err := LoadPostgresqlClientByFrom(req.Name)
if err != nil { if err != nil {
return err return err
@ -171,4 +205,11 @@ func handlePostgresqlRecover(req dto.CommonRecover, isRollback bool) error {
} }
isOk = true isOk = true
return nil return nil
}
itemTask.AddSubTask(i18n.GetMsgByKey("TaskRecover"), recoverDatabase, nil)
if parentTask != nil {
return recoverDatabase(parentTask)
}
return itemTask.Execute()
} }

View file

@ -10,9 +10,11 @@ import (
"github.com/1Panel-dev/1Panel/agent/app/dto" "github.com/1Panel-dev/1Panel/agent/app/dto"
"github.com/1Panel-dev/1Panel/agent/app/model" "github.com/1Panel-dev/1Panel/agent/app/model"
"github.com/1Panel-dev/1Panel/agent/app/repo" "github.com/1Panel-dev/1Panel/agent/app/repo"
"github.com/1Panel-dev/1Panel/agent/app/task"
"github.com/1Panel-dev/1Panel/agent/buserr" "github.com/1Panel-dev/1Panel/agent/buserr"
"github.com/1Panel-dev/1Panel/agent/constant" "github.com/1Panel-dev/1Panel/agent/constant"
"github.com/1Panel-dev/1Panel/agent/global" "github.com/1Panel-dev/1Panel/agent/global"
"github.com/1Panel-dev/1Panel/agent/i18n"
"github.com/1Panel-dev/1Panel/agent/utils/cmd" "github.com/1Panel-dev/1Panel/agent/utils/cmd"
"github.com/1Panel-dev/1Panel/agent/utils/common" "github.com/1Panel-dev/1Panel/agent/utils/common"
"github.com/1Panel-dev/1Panel/agent/utils/compose" "github.com/1Panel-dev/1Panel/agent/utils/compose"
@ -20,8 +22,8 @@ import (
"github.com/pkg/errors" "github.com/pkg/errors"
) )
func (u *BackupService) RedisBackup(db dto.CommonBackup) error { func (u *BackupService) RedisBackup(req dto.CommonBackup) error {
redisInfo, err := appInstallRepo.LoadBaseInfo("redis", db.Name) redisInfo, err := appInstallRepo.LoadBaseInfo("redis", req.Name)
if err != nil { if err != nil {
return err return err
} }
@ -42,12 +44,12 @@ func (u *BackupService) RedisBackup(db dto.CommonBackup) error {
} }
itemDir := fmt.Sprintf("database/redis/%s", redisInfo.Name) itemDir := fmt.Sprintf("database/redis/%s", redisInfo.Name)
backupDir := path.Join(global.CONF.System.Backup, itemDir) backupDir := path.Join(global.CONF.System.Backup, itemDir)
if err := handleRedisBackup(redisInfo, backupDir, fileName, db.Secret); err != nil { if err := handleRedisBackup(redisInfo, nil, backupDir, fileName, req.Secret, req.TaskID); err != nil {
return err return err
} }
record := &model.BackupRecord{ record := &model.BackupRecord{
Type: "redis", Type: "redis",
Name: db.Name, Name: req.Name,
SourceAccountIDs: "1", SourceAccountIDs: "1",
DownloadAccountID: 1, DownloadAccountID: 1,
FileDir: itemDir, FileDir: itemDir,
@ -66,13 +68,26 @@ func (u *BackupService) RedisRecover(req dto.CommonRecover) error {
return err return err
} }
global.LOG.Infof("recover redis from backup file %s", req.File) global.LOG.Infof("recover redis from backup file %s", req.File)
if err := handleRedisRecover(redisInfo, req.File, false, req.Secret); err != nil { if err := handleRedisRecover(redisInfo, nil, req.File, false, req.Secret, req.TaskID); err != nil {
return err return err
} }
return nil return nil
} }
func handleRedisBackup(redisInfo *repo.RootInfo, backupDir, fileName string, secret string) error { func handleRedisBackup(redisInfo *repo.RootInfo, parentTask *task.Task, backupDir, fileName, secret, taskID string) error {
var (
err error
itemTask *task.Task
)
itemTask = parentTask
if parentTask == nil {
itemTask, err = task.NewTaskWithOps("Redis", task.TaskBackup, task.TaskScopeDatabase, taskID, redisInfo.ID)
if err != nil {
return err
}
}
backupDatabase := func(t *task.Task) error {
fileOp := files.NewFileOp() fileOp := files.NewFileOp()
if !fileOp.Stat(backupDir) { if !fileOp.Stat(backupDir) {
if err := os.MkdirAll(backupDir, os.ModePerm); err != nil { if err := os.MkdirAll(backupDir, os.ModePerm); err != nil {
@ -105,9 +120,29 @@ func handleRedisBackup(redisInfo *repo.RootInfo, backupDir, fileName string, sec
return errors.New(string(stdout1)) return errors.New(string(stdout1))
} }
return nil return nil
}
itemTask.AddSubTask(i18n.GetMsgByKey("TaskBackup"), backupDatabase, nil)
if parentTask != nil {
return backupDatabase(parentTask)
}
return itemTask.Execute()
} }
func handleRedisRecover(redisInfo *repo.RootInfo, recoverFile string, isRollback bool, secret string) error { func handleRedisRecover(redisInfo *repo.RootInfo, parentTask *task.Task, recoverFile string, isRollback bool, secret, taskID string) error {
var (
err error
itemTask *task.Task
)
itemTask = parentTask
if parentTask == nil {
itemTask, err = task.NewTaskWithOps("Redis", task.TaskRecover, task.TaskScopeDatabase, taskID, redisInfo.ID)
if err != nil {
return err
}
}
recoverDatabase := func(t *task.Task) error {
fileOp := files.NewFileOp() fileOp := files.NewFileOp()
if !fileOp.Stat(recoverFile) { if !fileOp.Stat(recoverFile) {
return buserr.WithName("ErrFileNotFound", recoverFile) return buserr.WithName("ErrFileNotFound", recoverFile)
@ -143,13 +178,13 @@ func handleRedisRecover(redisInfo *repo.RootInfo, recoverFile string, isRollback
} }
} }
rollbackFile := path.Join(global.CONF.System.TmpDir, fmt.Sprintf("database/redis/%s_%s.%s", redisInfo.Name, time.Now().Format(constant.DateTimeSlimLayout), suffix)) rollbackFile := path.Join(global.CONF.System.TmpDir, fmt.Sprintf("database/redis/%s_%s.%s", redisInfo.Name, time.Now().Format(constant.DateTimeSlimLayout), suffix))
if err := handleRedisBackup(redisInfo, path.Dir(rollbackFile), path.Base(rollbackFile), secret); err != nil { if err := handleRedisBackup(redisInfo, nil, path.Dir(rollbackFile), path.Base(rollbackFile), secret, ""); err != nil {
return fmt.Errorf("backup database %s for rollback before recover failed, err: %v", redisInfo.Name, err) return fmt.Errorf("backup database %s for rollback before recover failed, err: %v", redisInfo.Name, err)
} }
defer func() { defer func() {
if !isOk { if !isOk {
global.LOG.Info("recover failed, start to rollback now") global.LOG.Info("recover failed, start to rollback now")
if err := handleRedisRecover(redisInfo, rollbackFile, true, secret); err != nil { if err := handleRedisRecover(redisInfo, itemTask, rollbackFile, true, secret, ""); err != nil {
global.LOG.Errorf("rollback redis from %s failed, err: %v", rollbackFile, err) global.LOG.Errorf("rollback redis from %s failed, err: %v", rollbackFile, err)
return return
} }
@ -187,4 +222,11 @@ func handleRedisRecover(redisInfo *repo.RootInfo, recoverFile string, isRollback
} }
isOk = true isOk = true
return nil return nil
}
itemTask.AddSubTask(i18n.GetMsgByKey("TaskRecover"), recoverDatabase, nil)
if parentTask != nil {
return recoverDatabase(parentTask)
}
return itemTask.Execute()
} }

View file

@ -3,17 +3,18 @@ package service
import ( import (
"encoding/json" "encoding/json"
"fmt" "fmt"
"github.com/1Panel-dev/1Panel/agent/app/task"
"github.com/1Panel-dev/1Panel/agent/i18n"
"github.com/1Panel-dev/1Panel/agent/utils/cmd"
"github.com/1Panel-dev/1Panel/agent/utils/compose"
"github.com/pkg/errors"
"io/fs" "io/fs"
"os" "os"
"path" "path"
"strings" "strings"
"time" "time"
"github.com/1Panel-dev/1Panel/agent/app/task"
"github.com/1Panel-dev/1Panel/agent/i18n"
"github.com/1Panel-dev/1Panel/agent/utils/cmd"
"github.com/1Panel-dev/1Panel/agent/utils/compose"
"github.com/pkg/errors"
"github.com/1Panel-dev/1Panel/agent/app/dto" "github.com/1Panel-dev/1Panel/agent/app/dto"
"github.com/1Panel-dev/1Panel/agent/app/model" "github.com/1Panel-dev/1Panel/agent/app/model"
"github.com/1Panel-dev/1Panel/agent/buserr" "github.com/1Panel-dev/1Panel/agent/buserr"
@ -310,7 +311,7 @@ func recoverWebsiteDatabase(t *task.Task, dbID uint, dbType, tmpPath, websiteKey
Name: db.PostgresqlName, Name: db.PostgresqlName,
DetailName: db.Name, DetailName: db.Name,
File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, websiteKey), File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, websiteKey),
}, true); err != nil { }, t, true); err != nil {
t.LogFailedWithErr(taskName, err) t.LogFailedWithErr(taskName, err)
return err return err
} }
@ -326,7 +327,7 @@ func recoverWebsiteDatabase(t *task.Task, dbID uint, dbType, tmpPath, websiteKey
Name: db.MysqlName, Name: db.MysqlName,
DetailName: db.Name, DetailName: db.Name,
File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, websiteKey), File: fmt.Sprintf("%s/%s.sql.gz", tmpPath, websiteKey),
}, true); err != nil { }, t, true, ""); err != nil {
t.LogFailedWithErr(taskName, err) t.LogFailedWithErr(taskName, err)
return err return err
} }

View file

@ -109,11 +109,11 @@ func (u *CronjobService) handleDatabase(cronjob model.Cronjob, startTime time.Ti
backupDir := path.Join(global.CONF.System.TmpDir, fmt.Sprintf("database/%s/%s/%s", dbInfo.DBType, record.Name, dbInfo.Name)) backupDir := path.Join(global.CONF.System.TmpDir, fmt.Sprintf("database/%s/%s/%s", dbInfo.DBType, record.Name, dbInfo.Name))
record.FileName = fmt.Sprintf("db_%s_%s.sql.gz", dbInfo.Name, startTime.Format(constant.DateTimeSlimLayout)+common.RandStrAndNum(5)) record.FileName = fmt.Sprintf("db_%s_%s.sql.gz", dbInfo.Name, startTime.Format(constant.DateTimeSlimLayout)+common.RandStrAndNum(5))
if cronjob.DBType == "mysql" || cronjob.DBType == "mariadb" { if cronjob.DBType == "mysql" || cronjob.DBType == "mariadb" {
if err := handleMysqlBackup(dbInfo.Database, dbInfo.DBType, dbInfo.Name, backupDir, record.FileName); err != nil { if err := handleMysqlBackup(dbInfo, nil, backupDir, record.FileName, ""); err != nil {
return err return err
} }
} else { } else {
if err := handlePostgresqlBackup(dbInfo.Database, dbInfo.Name, backupDir, record.FileName); err != nil { if err := handlePostgresqlBackup(dbInfo, nil, backupDir, record.FileName, ""); err != nil {
return err return err
} }
} }
@ -200,7 +200,7 @@ func (u *CronjobService) handleSnapshot(cronjob model.Cronjob, startTime time.Ti
var record model.BackupRecord var record model.BackupRecord
record.From = "cronjob" record.From = "cronjob"
record.Type = "directory" record.Type = "snapshot"
record.CronjobID = cronjob.ID record.CronjobID = cronjob.ID
record.Name = cronjob.Name record.Name = cronjob.Name
record.DownloadAccountID, record.SourceAccountIDs = cronjob.DownloadAccountID, cronjob.SourceAccountIDs record.DownloadAccountID, record.SourceAccountIDs = cronjob.DownloadAccountID, cronjob.SourceAccountIDs
@ -227,19 +227,21 @@ func (u *CronjobService) handleSnapshot(cronjob model.Cronjob, startTime time.Ti
return nil return nil
} }
type databaseHelper struct { type DatabaseHelper struct {
ID uint
DBType string DBType string
Database string Database string
Name string Name string
} }
func loadDbsForJob(cronjob model.Cronjob) []databaseHelper { func loadDbsForJob(cronjob model.Cronjob) []DatabaseHelper {
var dbs []databaseHelper var dbs []DatabaseHelper
if cronjob.DBName == "all" { if cronjob.DBName == "all" {
if cronjob.DBType == "mysql" || cronjob.DBType == "mariadb" { if cronjob.DBType == "mysql" || cronjob.DBType == "mariadb" {
mysqlItems, _ := mysqlRepo.List() mysqlItems, _ := mysqlRepo.List()
for _, mysql := range mysqlItems { for _, mysql := range mysqlItems {
dbs = append(dbs, databaseHelper{ dbs = append(dbs, DatabaseHelper{
ID: mysql.ID,
DBType: cronjob.DBType, DBType: cronjob.DBType,
Database: mysql.MysqlName, Database: mysql.MysqlName,
Name: mysql.Name, Name: mysql.Name,
@ -248,7 +250,8 @@ func loadDbsForJob(cronjob model.Cronjob) []databaseHelper {
} else { } else {
pgItems, _ := postgresqlRepo.List() pgItems, _ := postgresqlRepo.List()
for _, pg := range pgItems { for _, pg := range pgItems {
dbs = append(dbs, databaseHelper{ dbs = append(dbs, DatabaseHelper{
ID: pg.ID,
DBType: cronjob.DBType, DBType: cronjob.DBType,
Database: pg.PostgresqlName, Database: pg.PostgresqlName,
Name: pg.Name, Name: pg.Name,
@ -260,14 +263,16 @@ func loadDbsForJob(cronjob model.Cronjob) []databaseHelper {
itemID, _ := strconv.Atoi(cronjob.DBName) itemID, _ := strconv.Atoi(cronjob.DBName)
if cronjob.DBType == "mysql" || cronjob.DBType == "mariadb" { if cronjob.DBType == "mysql" || cronjob.DBType == "mariadb" {
mysqlItem, _ := mysqlRepo.Get(commonRepo.WithByID(uint(itemID))) mysqlItem, _ := mysqlRepo.Get(commonRepo.WithByID(uint(itemID)))
dbs = append(dbs, databaseHelper{ dbs = append(dbs, DatabaseHelper{
ID: mysqlItem.ID,
DBType: cronjob.DBType, DBType: cronjob.DBType,
Database: mysqlItem.MysqlName, Database: mysqlItem.MysqlName,
Name: mysqlItem.Name, Name: mysqlItem.Name,
}) })
} else { } else {
pgItem, _ := postgresqlRepo.Get(commonRepo.WithByID(uint(itemID))) pgItem, _ := postgresqlRepo.Get(commonRepo.WithByID(uint(itemID)))
dbs = append(dbs, databaseHelper{ dbs = append(dbs, DatabaseHelper{
ID: pgItem.ID,
DBType: cronjob.DBType, DBType: cronjob.DBType,
Database: pgItem.PostgresqlName, Database: pgItem.PostgresqlName,
Name: pgItem.Name, Name: pgItem.Name,