CorentinTh/it-tools
1
1
Fork 0
mirror of https://github.com/CorentinTh/it-tools.git synced 2024-11-15 21:54:30 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(device-information): prevent unwanted y-truncature of text

Browse source 
* Device information page styling fix

I was checking out your site, and really like it! already added to my bookmarks, and when I was on the Device Information page I noticed the `p` and `y` in the words 1 dppx and landscape-primary were cut off and my ocd kicked in to tweak it.
The fix was to remove the line height set on the value, and then to keep the spacing how it was just moving it up 5px seemed to do the trick.

I'm using Firefox 102.0.1 on Windows 11. I'll attach some pics so you can see the before and after.

I've never messed with vue, but after looking at this file here ya make me want to check it out more. I love how its keeping it all together in one file.
Might also need to rebuild it the site after this change, but you get the point. 

Awesome site!

* Update src/tools/device-information/device-information.vue

Co-authored-by: Corentin THOMASSET <corentin.thomasset74@gmail.com>
This commit is contained in:
JWB 2022-07-28 13:28:23 -04:00 committed by GitHub
parent 412de23796
commit 138149e6f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/tools/device-information/device-information.vue
View file

@ -89,7 +89,6 @@ const sections = [
.value { .value {
font-size: 20px; font-size: 20px;
font-weight: 400; font-weight: 400;
line-height: 1;
} }
} }
</style> </style>