2015-02-25 08:19:47 +08:00
|
|
|
React = require 'react/addons'
|
2015-04-25 02:33:10 +08:00
|
|
|
classNames = require 'classnames'
|
2015-05-20 07:06:59 +08:00
|
|
|
_ = require 'underscore'
|
2015-05-15 08:08:30 +08:00
|
|
|
{Utils} = require 'nylas-exports'
|
2015-02-25 08:19:47 +08:00
|
|
|
|
2015-05-20 06:59:37 +08:00
|
|
|
class DeveloperBarTask extends React.Component
|
|
|
|
|
@displayName: 'DeveloperBarTask'
|
2015-02-25 08:19:47 +08:00
|
|
|
|
2015-05-01 04:08:29 +08:00
|
|
|
constructor: (@props) ->
|
2015-09-28 14:43:59 +08:00
|
|
|
@state =
|
|
|
|
|
expanded: false
|
2015-02-25 08:19:47 +08:00
|
|
|
|
2015-05-01 04:08:29 +08:00
|
|
|
render: =>
|
2015-09-28 14:43:59 +08:00
|
|
|
details = false
|
|
|
|
|
if @state.expanded
|
|
|
|
|
# This could be a potentially large amount of JSON.
|
|
|
|
|
# Do not render unless it's actually being displayed!
|
|
|
|
|
details = <div className="task-details">{JSON.stringify(@props.task.toJSON())}</div>
|
|
|
|
|
|
|
|
|
|
<div className={@_classNames()} onClick={=> @setState(expanded: not @state.expanded)}>
|
2015-02-25 08:19:47 +08:00
|
|
|
<div className="task-summary">
|
|
|
|
|
{@_taskSummary()}
|
|
|
|
|
</div>
|
2015-09-28 14:43:59 +08:00
|
|
|
{details}
|
2015-02-25 08:19:47 +08:00
|
|
|
</div>
|
|
|
|
|
|
2015-05-15 05:12:53 +08:00
|
|
|
shouldComponentUpdate: (nextProps, nextState) =>
|
|
|
|
|
return not Utils.isEqualReact(nextProps, @props) or not Utils.isEqualReact(nextState, @state)
|
|
|
|
|
|
2015-05-01 04:08:29 +08:00
|
|
|
_taskSummary: =>
|
2015-02-25 08:19:47 +08:00
|
|
|
qs = @props.task.queueState
|
|
|
|
|
errType = ""
|
|
|
|
|
errCode = ""
|
|
|
|
|
errMessage = ""
|
|
|
|
|
if qs.localError?
|
|
|
|
|
localError = qs.localError
|
|
|
|
|
errType = localError.constructor.name
|
|
|
|
|
errMessage = localError.message ? JSON.stringify(localError)
|
|
|
|
|
else if qs.remoteError?
|
|
|
|
|
remoteError = qs.remoteError
|
|
|
|
|
errType = remoteError.constructor.name
|
|
|
|
|
errCode = remoteError.statusCode ? ""
|
|
|
|
|
errMessage = remoteError.body?.message ? remoteError?.message ? JSON.stringify(remoteError)
|
|
|
|
|
|
fix(tasks): don't continue if dependent task fails
Summary:
Fixes T4291
If I made a final edit to a pre-existing draft and sent, we'd queue a
`SyncbackDraftTask` before a `SendDraftTask`. This is important because
since we have a valid draft `server_id`, the `SendDraftTask` will send by
server_id, not by POSTing the whole body.
If the `SyncbackDraftTask` fails, then we had a very serious issue whereby
the `SendDraftTask` would keep on sending. Unfortunately the server never
got the latest changes and sent the wrong version of the draft. This
incorrect version would show up later when the `/send` endpoint returned
the message that got actually sent.
The solution was to make any queued `SendDraftTask` fail if a dependent
`SyncbackDraftTask` failed.
This meant we needed to make the requirements for `shouldWaitForTask`
stricter, and block if tasks failed.
Unfortunatley there was no infrastructure in place to do this.
The first change was to change `shouldWaitForTask` to `isDependentTask`.
If we're going to fail when a dependent task fails, I wanted the method
name to reflect this.
Now, if a dependent task fails, we recursively check the dependency tree
(and check for cycles) and `dequeue` anything that needed that to succeed.
I chose `dequeue` as the default action because it seemed as though all
current uses of `shouldWaitForTask` really should bail if their
dependencies fail. It's possible you don't want your task dequeued in this
dependency case. You can return the special `Task.DO_NOT_DEQUEUE_ME`
constant from the `onDependentTaskError` method.
When a task gets dequeued because of the reason above, the
`onDependentTaskError` callback gets fired. This gives tasks like the
`SendDraftTask` a chance to notify the user that it bailed. Not all tasks
need to notify.
The next big issue was a better way to determine if a task truely errored
to the point that we need to dequeue dependencies. In the Developer Status
area we were showing tasks that had errored as "Green" because we caught
the error and resolved with `Task.Status.Finished`. This used to be fine
since nothing life-or-death cared if a task errored or not. Now that it
might cause abortions down the line, we needed a more robust method then
this.
For one I changed `Task.Status.Finished` to a variety of finish types
including `Task.Status.Success`. The way you "error" out is to `throw` or
`Promise.reject` an `Error` object from the `performRemote` method. This
allows us to propagate API errors up, and acts as a safety net that can
catch any malformed code or unexpected responses.
The developer bar now shows a much richer set of statuses instead of a
binary one, which was REALLY helpful in debugging this. We also record
when a Task got dequeued because of the conditions introduced here.
Once all this was working we still had an issue of sending old drafts.
If after a `SyncbackDraftTask` failed, now we'd block the send and notify
the users as such. However, if we tried to send again, there was a
separate issue whereby we wouldn't queue another `SyncbackDraftTask` to
update the server with the latest information. Since our changes were
persisted to the DB, we thought we had no changes, and therefore didn't
need to queue a `SyncbackDraftTask`.
The fix to this is to always force the creation of a `SyncbackDraftTask`
before send regardless of the state of the `DraftStoreProxy`.
Test Plan: new tests. Lots of manual testing
Reviewers: bengotow
Reviewed By: bengotow
Subscribers: mg
Maniphest Tasks: T4291
Differential Revision: https://phab.nylas.com/D2156
2015-10-22 01:33:43 +08:00
|
|
|
id = @props.task.id[-4..-1]
|
|
|
|
|
|
|
|
|
|
if qs.status
|
|
|
|
|
status = "#{qs.status} (#{qs.debugStatus})"
|
|
|
|
|
else
|
|
|
|
|
status = "#{qs.debugStatus}"
|
|
|
|
|
|
|
|
|
|
return "#{@props.task.constructor.name} (ID: #{id}) #{status} #{errType} #{errCode} #{errMessage}"
|
2015-02-25 08:19:47 +08:00
|
|
|
|
2015-05-01 04:08:29 +08:00
|
|
|
_classNames: =>
|
2015-02-25 08:19:47 +08:00
|
|
|
qs = @props.task.queueState ? {}
|
2015-04-25 02:33:10 +08:00
|
|
|
classNames
|
2015-02-25 08:19:47 +08:00
|
|
|
"task": true
|
|
|
|
|
"task-queued": @props.type is "queued"
|
|
|
|
|
"task-completed": @props.type is "completed"
|
|
|
|
|
"task-expanded": @state.expanded
|
|
|
|
|
"task-local-error": qs.localError
|
|
|
|
|
"task-remote-error": qs.remoteError
|
|
|
|
|
"task-is-processing": qs.isProcessing
|
feat(offline-mode, undo-redo): Tasks handle network errors better and retry, undo/redo based on tasks
Summary:
This diff does a couple things:
- Undo redo with a new undo/redo store that maintains it's own queue of undo/redo tasks. This queue is separate from the TaskQueue because not all tasks should be considered for undo history! Right now just the AddRemoveTagsTask is undoable.
- NylasAPI.makeRequest now returns a promise which resolves with the result or rejects with an error. For things that still need them, there's still `success` and `error` callbacks. I also added `started:(req) ->` which allows you to get the underlying request.
- Aborting a NylasAPI request now makes it call it's error callback / promise reject.
- You can now run code after perform local has completed using this syntax:
```
task = new AddRemoveTagsTask(focused, ['archive'], ['inbox'])
task.waitForPerformLocal().then ->
Actions.setFocus(collection: 'thread', item: nextFocus)
Actions.setCursorPosition(collection: 'thread', item: nextKeyboard)
Actions.queueTask(task)
```
- In specs, you can now use `advanceClock` to get through a Promise.then/catch/finally. Turns out it was using something low level and not using setTimeout(0).
- The TaskQueue uses promises better and defers a lot of the complexity around queueState for performLocal/performRemote to a task subclass called APITask. APITask implements "perform" and breaks it into "performLocal" and "performRemote".
- All tasks either resolve or reject. They're always removed from the queue, unless they resolve with Task.Status.Retry, which means they internally did a .catch (err) => Promise.resolve(Task.Status.Retry) and they want to be run again later.
- API tasks retry until they succeed or receive a NylasAPI.PermanentErrorCode (400,404,500), in which case they revert and finish.
- The AddRemoveTags Task can now take more than one thread! This is super cool because you can undo/redo a bulk action and also because we'll probably have a bulk tag modification API endpoint soon.
Getting undo / redo working revealed that the thread versioning system we built isn't working because the server was incrementing things by more than 1 at a time. Now we count the number of unresolved "optimistic" changes we've made to a given model, and only accept the server's version of it once the number of optimistic changes is back at zero.
Known Issues:
- AddRemoveTagsTasks aren't dependent on each other, so if you (undo/redo x lots) and then come back online, all the tasks try to add / remove all the tags at the same time. To fix this we can either allow the tasks to be merged together into a minimal set or make them block on each other.
- When Offline, you still get errors in the console for GET requests. Need to catch these and display an offline status bar.
- The metadata tasks haven't been updated yet to the new API. Wanted to get it reviewed first!
Test Plan: All the tests still pass!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1694
2015-07-08 01:38:53 +08:00
|
|
|
"task-success": qs.localComplete and qs.remoteComplete
|
2015-05-01 04:08:29 +08:00
|
|
|
|
|
|
|
|
|
2015-05-20 06:59:37 +08:00
|
|
|
module.exports = DeveloperBarTask
|