2015-11-07 07:53:21 +08:00
|
|
|
proxyquire = require 'proxyquire'
|
2016-03-29 16:41:24 +08:00
|
|
|
React = require "react"
|
2016-04-01 05:43:44 +08:00
|
|
|
ReactDOM = require "react-dom"
|
2016-03-29 16:41:24 +08:00
|
|
|
ReactTestUtils = require('react-addons-test-utils')
|
2015-11-07 07:53:21 +08:00
|
|
|
|
|
|
|
{Contact,
|
|
|
|
Message,
|
|
|
|
File,
|
|
|
|
FileDownloadStore,
|
|
|
|
MessageBodyProcessor} = require "nylas-exports"
|
|
|
|
|
|
|
|
EmailFrameStub = React.createClass({render: -> <div></div>})
|
|
|
|
|
|
|
|
{InjectedComponent} = require 'nylas-component-kit'
|
|
|
|
|
|
|
|
file = new File
|
|
|
|
id: 'file_1_id'
|
|
|
|
filename: 'a.png'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_not_downloaded = new File
|
|
|
|
id: 'file_2_id'
|
|
|
|
filename: 'b.png'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_inline = new File
|
|
|
|
id: 'file_inline_id'
|
|
|
|
filename: 'c.png'
|
|
|
|
contentId: 'file_inline_id'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_inline_downloading = new File
|
|
|
|
id: 'file_inline_downloading_id'
|
|
|
|
filename: 'd.png'
|
|
|
|
contentId: 'file_inline_downloading_id'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_inline_not_downloaded = new File
|
|
|
|
id: 'file_inline_not_downloaded_id'
|
|
|
|
filename: 'e.png'
|
|
|
|
contentId: 'file_inline_not_downloaded_id'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_cid_but_not_referenced = new File
|
|
|
|
id: 'file_cid_but_not_referenced'
|
|
|
|
filename: 'f.png'
|
|
|
|
contentId: 'file_cid_but_not_referenced'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_cid_but_not_referenced_or_image = new File
|
|
|
|
id: 'file_cid_but_not_referenced_or_image'
|
|
|
|
filename: 'ansible notes.txt'
|
|
|
|
contentId: 'file_cid_but_not_referenced_or_image'
|
|
|
|
contentType: 'text/plain'
|
|
|
|
size: 300
|
|
|
|
file_without_filename = new File
|
|
|
|
id: 'file_without_filename'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
|
|
|
|
download =
|
|
|
|
fileId: 'file_1_id'
|
|
|
|
download_inline =
|
|
|
|
fileId: 'file_inline_downloading_id'
|
|
|
|
|
|
|
|
user_1 = new Contact
|
|
|
|
name: "User One"
|
|
|
|
email: "user1@nylas.com"
|
|
|
|
user_2 = new Contact
|
|
|
|
name: "User Two"
|
|
|
|
email: "user2@nylas.com"
|
|
|
|
user_3 = new Contact
|
|
|
|
name: "User Three"
|
|
|
|
email: "user3@nylas.com"
|
|
|
|
user_4 = new Contact
|
|
|
|
name: "User Four"
|
|
|
|
email: "user4@nylas.com"
|
|
|
|
|
|
|
|
MessageItemBody = proxyquire '../lib/message-item-body',
|
2016-05-06 06:13:51 +08:00
|
|
|
'./email-frame': {default: EmailFrameStub}
|
2015-11-07 07:53:21 +08:00
|
|
|
|
|
|
|
|
fix(spec): add support for async specs and disable misbehaving ones
More spec fixes
replace process.nextTick with setTimeout(fn, 0) for specs
Also added an unspy in the afterEach
Temporarily disable specs
fix(spec): start fixing specs
Summary:
This is the WIP fix to our spec runner.
Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.
Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!
The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.
Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.
I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).
Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update
Test Plan: npm test
Reviewers: juan, halla, jackie
Differential Revision: https://phab.nylas.com/D3501
Disable other specs
Disable more broken specs
All specs turned off till passing state
Use async-safe versions of spec functions
Add async test spec
Remove unused package code
Remove canary spec
2016-12-13 04:12:20 +08:00
|
|
|
xdescribe "MessageItem", ->
|
2015-11-07 07:53:21 +08:00
|
|
|
beforeEach ->
|
|
|
|
spyOn(FileDownloadStore, 'pathForFile').andCallFake (f) ->
|
|
|
|
return '/fake/path.png' if f.id is file.id
|
|
|
|
return '/fake/path-inline.png' if f.id is file_inline.id
|
|
|
|
return '/fake/path-downloading.png' if f.id is file_inline_downloading.id
|
|
|
|
return null
|
2016-03-10 10:02:21 +08:00
|
|
|
spyOn(MessageBodyProcessor, '_addToCache').andCallFake ->
|
2015-11-07 07:53:21 +08:00
|
|
|
|
|
|
|
@downloads =
|
|
|
|
'file_1_id': download,
|
|
|
|
'file_inline_downloading_id': download_inline
|
|
|
|
|
|
|
|
@message = new Message
|
|
|
|
id: "111"
|
|
|
|
from: [user_1]
|
|
|
|
to: [user_2]
|
|
|
|
cc: [user_3, user_4]
|
|
|
|
bcc: null
|
|
|
|
body: "Body One"
|
|
|
|
date: new Date(1415814587)
|
|
|
|
draft: false
|
|
|
|
files: []
|
|
|
|
unread: false
|
|
|
|
snippet: "snippet one..."
|
|
|
|
subject: "Subject One"
|
|
|
|
threadId: "thread_12345"
|
2016-02-25 04:24:19 +08:00
|
|
|
accountId: window.TEST_ACCOUNT_ID
|
2015-11-07 07:53:21 +08:00
|
|
|
|
|
|
|
# Generate the test component. Should be called after @message is configured
|
|
|
|
# for the test, since MessageItem assumes attributes of the message will not
|
|
|
|
# change after getInitialState runs.
|
|
|
|
@createComponent = ({collapsed} = {}) =>
|
|
|
|
collapsed ?= false
|
|
|
|
@component = ReactTestUtils.renderIntoDocument(
|
|
|
|
<MessageItemBody message={@message} downloads={@downloads} />
|
|
|
|
)
|
2015-12-08 07:00:20 +08:00
|
|
|
advanceClock()
|
2015-11-07 07:53:21 +08:00
|
|
|
|
|
|
|
describe "when the message contains attachments", ->
|
|
|
|
beforeEach ->
|
|
|
|
@message.files = [
|
|
|
|
file,
|
|
|
|
file_not_downloaded,
|
|
|
|
file_cid_but_not_referenced,
|
|
|
|
file_cid_but_not_referenced_or_image,
|
|
|
|
|
|
|
|
file_inline,
|
|
|
|
file_inline_downloading,
|
|
|
|
file_inline_not_downloaded,
|
|
|
|
file_without_filename
|
|
|
|
]
|
|
|
|
|
|
|
|
describe "inline", ->
|
|
|
|
beforeEach ->
|
|
|
|
@message.body = """
|
|
|
|
<img alt=\"A\" src=\"cid:#{file_inline.contentId}\"/>
|
|
|
|
<img alt=\"B\" src=\"cid:#{file_inline_downloading.contentId}\"/>
|
|
|
|
<img alt=\"C\" src=\"cid:#{file_inline_not_downloaded.contentId}\"/>
|
|
|
|
<img src=\"cid:missing-attachment\"/>
|
2016-07-22 02:56:40 +08:00
|
|
|
Hello world!
|
2015-11-07 07:53:21 +08:00
|
|
|
"""
|
|
|
|
@createComponent()
|
2016-07-22 02:56:40 +08:00
|
|
|
waitsFor =>
|
|
|
|
ReactTestUtils.scryRenderedComponentsWithType(@component, EmailFrameStub).length
|
2015-11-07 07:53:21 +08:00
|
|
|
|
2016-09-21 06:17:45 +08:00
|
|
|
it "should never leave src=cid: in the message body", ->
|
2016-07-22 02:56:40 +08:00
|
|
|
runs =>
|
|
|
|
body = ReactTestUtils.findRenderedComponentWithType(@component, EmailFrameStub).props.content
|
|
|
|
expect(body.indexOf('cid')).toEqual(-1)
|
2015-11-07 07:53:21 +08:00
|
|
|
|
2016-09-21 06:17:45 +08:00
|
|
|
it "should replace cid:<file.contentId> with the FileDownloadStore's path for the file", ->
|
2016-07-22 02:56:40 +08:00
|
|
|
runs =>
|
|
|
|
body = ReactTestUtils.findRenderedComponentWithType(@component, EmailFrameStub).props.content
|
|
|
|
expect(body.indexOf('alt="A" src="file:///fake/path-inline.png"')).toEqual(@message.body.indexOf('alt="A"'))
|
2015-11-07 07:53:21 +08:00
|
|
|
|
2016-09-21 06:17:45 +08:00
|
|
|
it "should not replace cid:<file.contentId> with the FileDownloadStore's path if the download is in progress", ->
|
2016-07-22 02:56:40 +08:00
|
|
|
runs =>
|
|
|
|
body = ReactTestUtils.findRenderedComponentWithType(@component, EmailFrameStub).props.content
|
|
|
|
expect(body.indexOf('/fake/path-downloading.png')).toEqual(-1)
|
2015-11-07 07:53:21 +08:00
|
|
|
|
|
|
|
describe "showQuotedText", ->
|
|
|
|
it "should be initialized to false", ->
|
|
|
|
@createComponent()
|
|
|
|
expect(@component.state.showQuotedText).toBe(false)
|
|
|
|
|
|
|
|
it "shouldn't render the quoted text control if there's no quoted text", ->
|
|
|
|
@message.body = "no quotes here!"
|
|
|
|
@createComponent()
|
|
|
|
toggles = ReactTestUtils.scryRenderedDOMComponentsWithClass(@component, 'quoted-text-control')
|
|
|
|
expect(toggles.length).toBe 0
|
|
|
|
|
|
|
|
describe 'quoted text control toggle button', ->
|
|
|
|
beforeEach ->
|
|
|
|
@message.body = """
|
|
|
|
Message
|
|
|
|
<blockquote class="gmail_quote">
|
|
|
|
Quoted message
|
|
|
|
</blockquote>
|
|
|
|
"""
|
|
|
|
@createComponent()
|
|
|
|
@toggle = ReactTestUtils.findRenderedDOMComponentWithClass(@component, 'quoted-text-control')
|
|
|
|
|
|
|
|
it 'should be rendered', ->
|
|
|
|
expect(@toggle).toBeDefined()
|
|
|
|
|
|
|
|
it "should be initialized to true if the message contains `Forwarded`...", ->
|
|
|
|
@message.body = """
|
|
|
|
Hi guys, take a look at this. Very relevant. -mg
|
|
|
|
<br>
|
|
|
|
<br>
|
|
|
|
<div class="gmail_quote">
|
|
|
|
---- Forwarded Message -----
|
|
|
|
blablalba
|
|
|
|
</div>
|
|
|
|
"""
|
|
|
|
@createComponent()
|
|
|
|
expect(@component.state.showQuotedText).toBe(true)
|
|
|
|
|
|
|
|
it "should be initialized to false if the message is a response to a Forwarded message", ->
|
|
|
|
@message.body = """
|
|
|
|
Thanks mg, that indeed looks very relevant. Will bring it up
|
|
|
|
with the rest of the team.
|
|
|
|
|
|
|
|
On Sunday, March 4th at 12:32AM, Michael Grinich Wrote:
|
|
|
|
<div class="gmail_quote">
|
|
|
|
Hi guys, take a look at this. Very relevant. -mg
|
|
|
|
<br>
|
|
|
|
<br>
|
|
|
|
<div class="gmail_quote">
|
|
|
|
---- Forwarded Message -----
|
|
|
|
blablalba
|
|
|
|
</div>
|
|
|
|
</div>
|
|
|
|
"""
|
|
|
|
@createComponent()
|
|
|
|
expect(@component.state.showQuotedText).toBe(false)
|
|
|
|
|
|
|
|
describe "when showQuotedText is true", ->
|
|
|
|
beforeEach ->
|
|
|
|
@message.body = """
|
|
|
|
Message
|
|
|
|
<blockquote class="gmail_quote">
|
|
|
|
Quoted message
|
|
|
|
</blockquote>
|
|
|
|
"""
|
|
|
|
@createComponent()
|
2016-09-21 06:17:45 +08:00
|
|
|
@component.state.showQuotedText = true
|
2016-07-22 02:56:40 +08:00
|
|
|
waitsFor =>
|
|
|
|
ReactTestUtils.scryRenderedComponentsWithType(@component, EmailFrameStub).length
|
2015-11-07 07:53:21 +08:00
|
|
|
|
|
|
|
describe 'quoted text control toggle button', ->
|
|
|
|
beforeEach ->
|
|
|
|
@toggle = ReactTestUtils.findRenderedDOMComponentWithClass(@component, 'quoted-text-control')
|
|
|
|
|
|
|
|
it 'should be rendered', ->
|
|
|
|
expect(@toggle).toBeDefined()
|
|
|
|
|
|
|
|
it "should pass the value into the EmailFrame", ->
|
2016-07-22 02:56:40 +08:00
|
|
|
runs =>
|
|
|
|
frame = ReactTestUtils.findRenderedComponentWithType(@component, EmailFrameStub)
|
|
|
|
expect(frame.props.showQuotedText).toBe(true)
|