feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
import {
|
2016-02-18 06:54:43 +08:00
|
|
|
Task,
|
|
|
|
Model,
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
NylasAPI,
|
|
|
|
DatabaseStore,
|
|
|
|
DestroyModelTask,
|
|
|
|
DatabaseTransaction} from 'nylas-exports'
|
|
|
|
|
2016-05-05 05:03:15 +08:00
|
|
|
describe('DestroyModelTask', function destroyModelTask() {
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
beforeEach(() => {
|
2016-02-18 06:54:43 +08:00
|
|
|
this.existingModel = new Model()
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
this.existingModel.clientId = "local-123"
|
|
|
|
this.existingModel.serverId = "server-123"
|
|
|
|
spyOn(DatabaseTransaction.prototype, "unpersistModel")
|
|
|
|
spyOn(DatabaseStore, "findBy").andCallFake(() => {
|
|
|
|
return Promise.resolve(this.existingModel)
|
|
|
|
})
|
|
|
|
|
|
|
|
this.defaultArgs = {
|
|
|
|
clientId: "local-123",
|
|
|
|
accountId: "a123",
|
2016-02-18 06:54:43 +08:00
|
|
|
modelName: "Model",
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
endpoint: "/endpoint",
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
it("constructs without error", () => {
|
|
|
|
const t = new DestroyModelTask()
|
|
|
|
expect(t._rememberedToCallSuper).toBe(true)
|
|
|
|
});
|
|
|
|
|
|
|
|
describe("performLocal", () => {
|
|
|
|
it("throws if basic fields are missing", () => {
|
|
|
|
const t = new DestroyModelTask()
|
|
|
|
try {
|
|
|
|
t.performLocal()
|
|
|
|
throw new Error("Shouldn't succeed");
|
|
|
|
} catch (e) {
|
|
|
|
expect(e.message).toMatch(/^Must pass.*/)
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
it("throws if the model name can't be found", () => {
|
|
|
|
this.defaultArgs.modelName = "dne"
|
|
|
|
const t = new DestroyModelTask(this.defaultArgs)
|
|
|
|
try {
|
|
|
|
t.performLocal()
|
|
|
|
throw new Error("Shouldn't succeed");
|
|
|
|
} catch (e) {
|
|
|
|
expect(e.message).toMatch(/^Couldn't find the class for.*/)
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
it("throws if it can't find the object", () => {
|
|
|
|
jasmine.unspy(DatabaseStore, "findBy")
|
|
|
|
spyOn(DatabaseStore, "findBy").andCallFake(() => {
|
|
|
|
return Promise.resolve(null)
|
|
|
|
})
|
|
|
|
const t = new DestroyModelTask(this.defaultArgs)
|
|
|
|
window.waitsForPromise(() => {
|
|
|
|
return t.performLocal().then(() => {
|
|
|
|
throw new Error("Shouldn't succeed")
|
|
|
|
}).catch((err) => {
|
|
|
|
expect(err.message).toMatch(/^Couldn't find the model with clientId.*/)
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it("unpersists the new existing model properly", () => {
|
|
|
|
const unpersistFn = DatabaseTransaction.prototype.unpersistModel
|
|
|
|
const t = new DestroyModelTask(this.defaultArgs)
|
|
|
|
window.waitsForPromise(() => {
|
|
|
|
return t.performLocal().then(() => {
|
|
|
|
expect(unpersistFn).toHaveBeenCalled()
|
|
|
|
const model = unpersistFn.calls[0].args[0]
|
|
|
|
expect(model).toBe(this.existingModel)
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe("performRemote", () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
this.task = new DestroyModelTask(this.defaultArgs)
|
|
|
|
});
|
|
|
|
|
|
|
|
const performRemote = (fn) => {
|
|
|
|
window.waitsForPromise(() => {
|
|
|
|
return this.task.performLocal().then(() => {
|
|
|
|
return this.task.performRemote().then(fn)
|
|
|
|
});
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2016-02-18 06:54:43 +08:00
|
|
|
it("skips request if the serverId is undefined", () => {
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
window.waitsForPromise(() => {
|
|
|
|
return this.task.performLocal().then(() => {
|
|
|
|
this.task.serverId = null
|
2016-05-06 13:30:34 +08:00
|
|
|
return this.task.performRemote().then((status) => {
|
2016-02-18 06:54:43 +08:00
|
|
|
expect(status).toEqual(Task.Status.Continue)
|
|
|
|
})
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
it("makes a DELETE request to the Nylas API", () => {
|
|
|
|
spyOn(NylasAPI, "makeRequest").andReturn(Promise.resolve())
|
|
|
|
performRemote(() => {
|
|
|
|
const opts = NylasAPI.makeRequest.calls[0].args[0]
|
|
|
|
expect(opts.method).toBe("DELETE")
|
|
|
|
expect(opts.path).toBe("/endpoint/server-123")
|
|
|
|
expect(opts.accountId).toBe(this.defaultArgs.accountId)
|
|
|
|
})
|
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|