2015-05-20 07:06:59 +08:00
|
|
|
_ = require "underscore"
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
moment = require "moment"
|
2015-08-04 08:19:07 +08:00
|
|
|
proxyquire = require("proxyquire").noPreserveCache()
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
|
|
|
CSON = require "season"
|
|
|
|
React = require "react/addons"
|
|
|
|
TestUtils = React.addons.TestUtils
|
|
|
|
|
|
|
|
{Thread,
|
|
|
|
Contact,
|
|
|
|
Actions,
|
|
|
|
Message,
|
feat(accounts): Kill namespaces, long live accounts
Summary:
This diff replaces the Namespace object with the Account object, and changes all references to namespace_id => account_id, etc. The endpoints are now `/threads` instead of `/n/<id>/threads`.
This diff also adds preliminary support for multiple accounts. When you log in, we now log you in to all the attached accounts on edgehill server. From the preferences panel, you can auth with / unlink additional accounts. Shockingly, this all seems to pretty much work.
When replying to a thread, you cannot switch from addresses. However, when creating a new message in a popout composer, you can change the from address and the SaveDraftTask will delete/re-root the draft on the new account.
Search bar doesn't need to do full refresh on clear if it never committed
Allow drafts to be switched to a different account when not in reply to an existing thread
Fix edge case where ChangeMailTask throws exception if no models are modified during performLocal
Show many dots for many accounts in long polling status bar
add/remove accounts from prefs
Spec fixes!
Test Plan: Run tests, none broken!
Reviewers: evan, dillon
Reviewed By: evan, dillon
Differential Revision: https://phab.nylas.com/D1928
2015-08-22 06:29:58 +08:00
|
|
|
Account,
|
2015-07-14 07:30:02 +08:00
|
|
|
DraftStore,
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
MessageStore,
|
feat(accounts): Kill namespaces, long live accounts
Summary:
This diff replaces the Namespace object with the Account object, and changes all references to namespace_id => account_id, etc. The endpoints are now `/threads` instead of `/n/<id>/threads`.
This diff also adds preliminary support for multiple accounts. When you log in, we now log you in to all the attached accounts on edgehill server. From the preferences panel, you can auth with / unlink additional accounts. Shockingly, this all seems to pretty much work.
When replying to a thread, you cannot switch from addresses. However, when creating a new message in a popout composer, you can change the from address and the SaveDraftTask will delete/re-root the draft on the new account.
Search bar doesn't need to do full refresh on clear if it never committed
Allow drafts to be switched to a different account when not in reply to an existing thread
Fix edge case where ChangeMailTask throws exception if no models are modified during performLocal
Show many dots for many accounts in long polling status bar
add/remove accounts from prefs
Spec fixes!
Test Plan: Run tests, none broken!
Reviewers: evan, dillon
Reviewed By: evan, dillon
Differential Revision: https://phab.nylas.com/D1928
2015-08-22 06:29:58 +08:00
|
|
|
AccountStore,
|
2015-06-27 05:06:31 +08:00
|
|
|
NylasTestUtils,
|
2015-05-15 08:08:30 +08:00
|
|
|
ComponentRegistry} = require "nylas-exports"
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
2015-05-15 08:08:30 +08:00
|
|
|
{InjectedComponent} = require 'nylas-component-kit'
|
2015-02-19 06:09:46 +08:00
|
|
|
|
2015-08-04 08:19:07 +08:00
|
|
|
MessageParticipants = require "../lib/message-participants"
|
|
|
|
|
2015-03-21 08:51:49 +08:00
|
|
|
MessageItem = proxyquire("../lib/message-item", {
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
"./email-frame": React.createClass({render: -> <div></div>})
|
|
|
|
})
|
|
|
|
|
2015-08-04 08:19:07 +08:00
|
|
|
MessageItemContainer = proxyquire("../lib/message-item-container", {
|
2015-03-21 08:51:49 +08:00
|
|
|
"./message-item": MessageItem
|
2015-08-04 08:19:07 +08:00
|
|
|
"./pending-message-item": MessageItem
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
})
|
|
|
|
|
2015-08-04 08:19:07 +08:00
|
|
|
MessageList = proxyquire '../lib/message-list',
|
|
|
|
"./message-item-container": MessageItemContainer
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
2015-09-15 04:18:55 +08:00
|
|
|
# User_1 needs to be "me" so that when we calculate who we should reply
|
|
|
|
# to, it properly matches the AccountStore
|
2015-07-14 07:30:02 +08:00
|
|
|
user_1 = new Contact
|
2015-09-15 04:18:55 +08:00
|
|
|
name: TEST_ACCOUNT_NAME
|
|
|
|
email: TEST_ACCOUNT_EMAIL
|
2015-07-14 07:30:02 +08:00
|
|
|
user_2 = new Contact
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
name: "User Two"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user2@nylas.com"
|
2015-07-14 07:30:02 +08:00
|
|
|
user_3 = new Contact
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
name: "User Three"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user3@nylas.com"
|
2015-07-14 07:30:02 +08:00
|
|
|
user_4 = new Contact
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
name: "User Four"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user4@nylas.com"
|
2015-07-14 07:30:02 +08:00
|
|
|
user_5 = new Contact
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
name: "User Five"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user5@nylas.com"
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
m1 = (new Message).fromJSON({
|
|
|
|
"id" : "111",
|
|
|
|
"from" : [ user_1 ],
|
|
|
|
"to" : [ user_2 ],
|
|
|
|
"cc" : [ user_3, user_4 ],
|
|
|
|
"bcc" : null,
|
|
|
|
"body" : "Body One",
|
|
|
|
"date" : 1415814587,
|
|
|
|
"draft" : false
|
|
|
|
"files" : [],
|
|
|
|
"unread" : false,
|
|
|
|
"object" : "message",
|
|
|
|
"snippet" : "snippet one...",
|
|
|
|
"subject" : "Subject One",
|
|
|
|
"thread_id" : "thread_12345",
|
2015-08-29 02:12:53 +08:00
|
|
|
"account_id" : TEST_ACCOUNT_ID
|
2015-03-25 04:57:24 +08:00
|
|
|
})
|
|
|
|
m2 = (new Message).fromJSON({
|
|
|
|
"id" : "222",
|
|
|
|
"from" : [ user_2 ],
|
|
|
|
"to" : [ user_1 ],
|
|
|
|
"cc" : [ user_3, user_4 ],
|
|
|
|
"bcc" : null,
|
|
|
|
"body" : "Body Two",
|
|
|
|
"date" : 1415814587,
|
|
|
|
"draft" : false
|
|
|
|
"files" : [],
|
|
|
|
"unread" : false,
|
|
|
|
"object" : "message",
|
|
|
|
"snippet" : "snippet Two...",
|
|
|
|
"subject" : "Subject Two",
|
|
|
|
"thread_id" : "thread_12345",
|
2015-08-29 02:12:53 +08:00
|
|
|
"account_id" : TEST_ACCOUNT_ID
|
2015-03-25 04:57:24 +08:00
|
|
|
})
|
|
|
|
m3 = (new Message).fromJSON({
|
|
|
|
"id" : "333",
|
|
|
|
"from" : [ user_3 ],
|
|
|
|
"to" : [ user_1 ],
|
|
|
|
"cc" : [ user_2, user_4 ],
|
|
|
|
"bcc" : [],
|
|
|
|
"body" : "Body Three",
|
|
|
|
"date" : 1415814587,
|
|
|
|
"draft" : false
|
|
|
|
"files" : [],
|
|
|
|
"unread" : false,
|
|
|
|
"object" : "message",
|
|
|
|
"snippet" : "snippet Three...",
|
|
|
|
"subject" : "Subject Three",
|
|
|
|
"thread_id" : "thread_12345",
|
2015-08-29 02:12:53 +08:00
|
|
|
"account_id" : TEST_ACCOUNT_ID
|
2015-03-25 04:57:24 +08:00
|
|
|
})
|
|
|
|
m4 = (new Message).fromJSON({
|
|
|
|
"id" : "444",
|
|
|
|
"from" : [ user_4 ],
|
|
|
|
"to" : [ user_1 ],
|
|
|
|
"cc" : [],
|
|
|
|
"bcc" : [ user_5 ],
|
|
|
|
"body" : "Body Four",
|
|
|
|
"date" : 1415814587,
|
|
|
|
"draft" : false
|
|
|
|
"files" : [],
|
|
|
|
"unread" : false,
|
|
|
|
"object" : "message",
|
|
|
|
"snippet" : "snippet Four...",
|
|
|
|
"subject" : "Subject Four",
|
|
|
|
"thread_id" : "thread_12345",
|
2015-08-29 02:12:53 +08:00
|
|
|
"account_id" : TEST_ACCOUNT_ID
|
2015-03-25 04:57:24 +08:00
|
|
|
})
|
|
|
|
m5 = (new Message).fromJSON({
|
|
|
|
"id" : "555",
|
|
|
|
"from" : [ user_1 ],
|
|
|
|
"to" : [ user_4 ],
|
|
|
|
"cc" : [],
|
|
|
|
"bcc" : [],
|
|
|
|
"body" : "Body Five",
|
|
|
|
"date" : 1415814587,
|
|
|
|
"draft" : false
|
|
|
|
"files" : [],
|
|
|
|
"unread" : false,
|
|
|
|
"object" : "message",
|
|
|
|
"snippet" : "snippet Five...",
|
|
|
|
"subject" : "Subject Five",
|
|
|
|
"thread_id" : "thread_12345",
|
2015-08-29 02:12:53 +08:00
|
|
|
"account_id" : TEST_ACCOUNT_ID
|
2015-03-25 04:57:24 +08:00
|
|
|
})
|
|
|
|
testMessages = [m1, m2, m3, m4, m5]
|
2015-02-17 09:09:28 +08:00
|
|
|
draftMessages = [
|
|
|
|
(new Message).fromJSON({
|
|
|
|
"id" : "666",
|
|
|
|
"from" : [ user_1 ],
|
|
|
|
"to" : [ ],
|
|
|
|
"cc" : [ ],
|
|
|
|
"bcc" : null,
|
|
|
|
"body" : "Body One",
|
|
|
|
"date" : 1415814587,
|
|
|
|
"draft" : true
|
|
|
|
"files" : [],
|
|
|
|
"unread" : false,
|
|
|
|
"object" : "draft",
|
|
|
|
"snippet" : "draft snippet one...",
|
|
|
|
"subject" : "Draft One",
|
|
|
|
"thread_id" : "thread_12345",
|
2015-08-29 02:12:53 +08:00
|
|
|
"account_id" : TEST_ACCOUNT_ID
|
2015-02-17 09:09:28 +08:00
|
|
|
}),
|
|
|
|
]
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
|
|
|
test_thread = (new Thread).fromJSON({
|
2015-08-29 02:12:53 +08:00
|
|
|
"id": "12345"
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
"id" : "thread_12345"
|
|
|
|
"subject" : "Subject 12345"
|
|
|
|
})
|
|
|
|
|
|
|
|
describe "MessageList", ->
|
2015-02-19 06:09:46 +08:00
|
|
|
beforeEach ->
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
MessageStore._items = []
|
|
|
|
MessageStore._threadId = null
|
2015-03-18 03:11:34 +08:00
|
|
|
spyOn(MessageStore, "itemsLoading").andCallFake ->
|
|
|
|
false
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
@messageList = TestUtils.renderIntoDocument(<MessageList />)
|
|
|
|
@messageList_node = React.findDOMNode(@messageList)
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
|
|
|
it "renders into the document", ->
|
2015-06-23 06:49:52 +08:00
|
|
|
expect(TestUtils.isCompositeComponentWithType(@messageList,
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
MessageList)).toBe true
|
|
|
|
|
|
|
|
it "by default has zero children", ->
|
2015-06-23 06:49:52 +08:00
|
|
|
items = TestUtils.scryRenderedComponentsWithType(@messageList,
|
2015-08-04 08:19:07 +08:00
|
|
|
MessageItemContainer)
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
|
|
|
expect(items.length).toBe 0
|
|
|
|
|
|
|
|
describe "Populated Message list", ->
|
|
|
|
beforeEach ->
|
2015-02-17 09:09:28 +08:00
|
|
|
MessageStore._items = testMessages
|
2015-04-01 08:04:10 +08:00
|
|
|
MessageStore._expandItemsToDefault()
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
MessageStore.trigger(MessageStore)
|
2015-06-23 06:49:52 +08:00
|
|
|
@messageList.setState currentThread: test_thread
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
2015-06-27 05:06:31 +08:00
|
|
|
NylasTestUtils.loadKeymap("keymaps/base")
|
|
|
|
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
it "renders all the correct number of messages", ->
|
2015-06-23 06:49:52 +08:00
|
|
|
items = TestUtils.scryRenderedComponentsWithType(@messageList,
|
2015-08-04 08:19:07 +08:00
|
|
|
MessageItemContainer)
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
expect(items.length).toBe 5
|
|
|
|
|
2015-04-01 08:04:10 +08:00
|
|
|
it "renders the correct number of expanded messages", ->
|
2015-08-04 08:19:07 +08:00
|
|
|
msgs = TestUtils.scryRenderedDOMComponentsWithClass(@messageList, "collapsed message-item-wrap")
|
2015-04-01 08:04:10 +08:00
|
|
|
expect(msgs.length).toBe 4
|
|
|
|
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
it "displays lists of participants on the page", ->
|
2015-06-23 06:49:52 +08:00
|
|
|
items = TestUtils.scryRenderedComponentsWithType(@messageList,
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
MessageParticipants)
|
2015-04-01 08:04:10 +08:00
|
|
|
expect(items.length).toBe 1
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
2015-02-17 09:09:28 +08:00
|
|
|
it "focuses new composers when a draft is added", ->
|
2015-06-23 06:49:52 +08:00
|
|
|
spyOn(@messageList, "_focusDraft")
|
|
|
|
msgs = @messageList.state.messages
|
2015-03-18 03:11:34 +08:00
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
@messageList.setState
|
2015-03-18 03:11:34 +08:00
|
|
|
messages: msgs.concat(draftMessages)
|
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
expect(@messageList._focusDraft).toHaveBeenCalled()
|
2015-08-29 02:12:53 +08:00
|
|
|
expect(@messageList._focusDraft.mostRecentCall.args[0].props.draftClientId).toEqual(draftMessages[0].draftClientId)
|
2015-08-04 08:19:07 +08:00
|
|
|
|
|
|
|
it "includes drafts as message item containers", ->
|
|
|
|
msgs = @messageList.state.messages
|
|
|
|
@messageList.setState
|
|
|
|
messages: msgs.concat(draftMessages)
|
|
|
|
items = TestUtils.scryRenderedComponentsWithType(@messageList,
|
|
|
|
MessageItemContainer)
|
|
|
|
expect(items.length).toBe 6
|
2015-02-17 09:09:28 +08:00
|
|
|
|
|
|
|
describe "MessageList with draft", ->
|
|
|
|
beforeEach ->
|
|
|
|
MessageStore._items = testMessages.concat draftMessages
|
2015-08-01 03:06:34 +08:00
|
|
|
MessageStore._thread = test_thread
|
2015-02-17 09:09:28 +08:00
|
|
|
MessageStore.trigger(MessageStore)
|
2015-06-23 06:49:52 +08:00
|
|
|
spyOn(@messageList, "_focusDraft")
|
2015-02-17 09:09:28 +08:00
|
|
|
|
|
|
|
it "renders the composer", ->
|
2015-06-23 06:49:52 +08:00
|
|
|
items = TestUtils.scryRenderedComponentsWithTypeAndProps(@messageList, InjectedComponent, matching: {role:"Composer"})
|
|
|
|
expect(@messageList.state.messages.length).toBe 6
|
2015-02-17 09:09:28 +08:00
|
|
|
expect(items.length).toBe 1
|
|
|
|
|
2015-06-06 02:38:30 +08:00
|
|
|
it "doesn't focus on initial load", ->
|
2015-06-23 06:49:52 +08:00
|
|
|
expect(@messageList._focusDraft).not.toHaveBeenCalled()
|
2015-03-25 04:57:24 +08:00
|
|
|
|
|
|
|
describe "reply type", ->
|
|
|
|
it "prompts for a reply when there's only one participant", ->
|
|
|
|
MessageStore._items = [m3, m5]
|
2015-08-01 03:06:34 +08:00
|
|
|
MessageStore._thread = test_thread
|
2015-03-25 04:57:24 +08:00
|
|
|
MessageStore.trigger()
|
2015-06-23 06:49:52 +08:00
|
|
|
expect(@messageList._replyType()).toBe "reply"
|
|
|
|
cs = TestUtils.scryRenderedDOMComponentsWithClass(@messageList, "footer-reply-area")
|
2015-03-25 04:57:24 +08:00
|
|
|
expect(cs.length).toBe 1
|
|
|
|
|
2015-09-15 04:18:55 +08:00
|
|
|
it "prompts for a reply-all when there's more than one participant and the default is reply-all", ->
|
2015-11-12 02:25:11 +08:00
|
|
|
spyOn(NylasEnv.config, "get").andReturn "reply-all"
|
2015-03-25 04:57:24 +08:00
|
|
|
MessageStore._items = [m5, m3]
|
2015-08-01 03:06:34 +08:00
|
|
|
MessageStore._thread = test_thread
|
2015-03-25 04:57:24 +08:00
|
|
|
MessageStore.trigger()
|
2015-06-23 06:49:52 +08:00
|
|
|
expect(@messageList._replyType()).toBe "reply-all"
|
|
|
|
cs = TestUtils.scryRenderedDOMComponentsWithClass(@messageList, "footer-reply-area")
|
2015-03-25 04:57:24 +08:00
|
|
|
expect(cs.length).toBe 1
|
|
|
|
|
2015-09-15 04:18:55 +08:00
|
|
|
it "prompts for a reply-all when there's more than one participant and the default is reply", ->
|
2015-11-12 02:25:11 +08:00
|
|
|
spyOn(NylasEnv.config, "get").andReturn "reply"
|
2015-09-15 04:18:55 +08:00
|
|
|
MessageStore._items = [m5, m3]
|
|
|
|
MessageStore._thread = test_thread
|
|
|
|
MessageStore.trigger()
|
|
|
|
expect(@messageList._replyType()).toBe "reply"
|
|
|
|
cs = TestUtils.scryRenderedDOMComponentsWithClass(@messageList, "footer-reply-area")
|
|
|
|
expect(cs.length).toBe 1
|
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
it "hides the reply type if the last message is a draft", ->
|
|
|
|
MessageStore._items = [m5, m3, draftMessages[0]]
|
2015-08-01 03:06:34 +08:00
|
|
|
MessageStore._thread = test_thread
|
2015-03-25 04:57:24 +08:00
|
|
|
MessageStore.trigger()
|
2015-08-07 03:22:06 +08:00
|
|
|
cs = TestUtils.scryRenderedDOMComponentsWithClass(@messageList, "footer-reply-area")
|
|
|
|
expect(cs.length).toBe 0
|
2015-06-23 06:49:52 +08:00
|
|
|
|
2015-07-14 07:30:02 +08:00
|
|
|
describe "reply behavior (_createReplyOrUpdateExistingDraft)", ->
|
|
|
|
beforeEach ->
|
|
|
|
@messageList.setState(currentThread: test_thread)
|
|
|
|
|
|
|
|
it "should throw an exception unless you provide `reply` or `reply-all`", ->
|
|
|
|
expect( => @messageList._createReplyOrUpdateExistingDraft('lala')).toThrow()
|
|
|
|
|
|
|
|
describe "when there is already a draft at the bottom of the thread", ->
|
|
|
|
beforeEach ->
|
|
|
|
@replyToMessage = new Message
|
|
|
|
id: "reply-id",
|
|
|
|
threadId: test_thread.id
|
|
|
|
date: new Date()
|
|
|
|
@draft = new Message
|
|
|
|
id: "666",
|
|
|
|
draft: true,
|
|
|
|
date: new Date()
|
|
|
|
replyToMessage: @replyToMessage.id
|
|
|
|
|
|
|
|
spyOn(@messageList, '_focusDraft')
|
|
|
|
spyOn(@replyToMessage, 'participantsForReplyAll').andCallFake ->
|
|
|
|
{to: [user_3], cc: [user_2, user_4] }
|
|
|
|
spyOn(@replyToMessage, 'participantsForReply').andCallFake ->
|
|
|
|
{to: [user_3], cc: [] }
|
|
|
|
|
|
|
|
MessageStore._items = [@replyToMessage, @draft]
|
2015-08-01 03:06:34 +08:00
|
|
|
MessageStore._thread = test_thread
|
2015-07-14 07:30:02 +08:00
|
|
|
MessageStore.trigger()
|
|
|
|
|
|
|
|
@sessionStub =
|
|
|
|
draft: => @draft
|
|
|
|
changes:
|
|
|
|
add: jasmine.createSpy('session.changes.add')
|
2015-08-29 02:12:53 +08:00
|
|
|
spyOn(DraftStore, 'sessionForClientId').andCallFake =>
|
2015-07-14 07:30:02 +08:00
|
|
|
Promise.resolve(@sessionStub)
|
|
|
|
|
|
|
|
it "should not fire a composer action", ->
|
|
|
|
spyOn(Actions, 'composeReplyAll')
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply-all')
|
|
|
|
advanceClock()
|
|
|
|
expect(Actions.composeReplyAll).not.toHaveBeenCalled()
|
|
|
|
|
|
|
|
it "should focus the existing draft", ->
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply-all')
|
|
|
|
advanceClock()
|
|
|
|
expect(@messageList._focusDraft).toHaveBeenCalled()
|
|
|
|
|
|
|
|
describe "when reply-all is passed", ->
|
|
|
|
it "should add missing participants", ->
|
|
|
|
@draft.to = [ user_3 ]
|
|
|
|
@draft.cc = []
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply-all')
|
|
|
|
advanceClock()
|
|
|
|
expect(@sessionStub.changes.add).toHaveBeenCalledWith({to: [user_3], cc: [user_2, user_4]})
|
|
|
|
|
|
|
|
it "should not blow away other participants who have been added to the draft", ->
|
|
|
|
user_random_a = new Contact(email: 'other-guy-a@gmail.com')
|
|
|
|
user_random_b = new Contact(email: 'other-guy-b@gmail.com')
|
|
|
|
@draft.to = [ user_3, user_random_a ]
|
|
|
|
@draft.cc = [ user_random_b ]
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply-all')
|
|
|
|
advanceClock()
|
|
|
|
expect(@sessionStub.changes.add).toHaveBeenCalledWith({to: [user_3, user_random_a], cc: [user_random_b, user_2, user_4]})
|
|
|
|
|
|
|
|
describe "when reply is passed", ->
|
|
|
|
it "should remove participants present in the reply-all participant set and not in the reply set", ->
|
|
|
|
@draft.to = [ user_3 ]
|
|
|
|
@draft.cc = [ user_2, user_4 ]
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply')
|
|
|
|
advanceClock()
|
|
|
|
expect(@sessionStub.changes.add).toHaveBeenCalledWith({to: [user_3], cc: []})
|
|
|
|
|
|
|
|
it "should not blow away other participants who have been added to the draft", ->
|
|
|
|
user_random_a = new Contact(email: 'other-guy-a@gmail.com')
|
|
|
|
user_random_b = new Contact(email: 'other-guy-b@gmail.com')
|
|
|
|
@draft.to = [ user_3, user_random_a ]
|
|
|
|
@draft.cc = [ user_2, user_4, user_random_b ]
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply')
|
|
|
|
advanceClock()
|
|
|
|
expect(@sessionStub.changes.add).toHaveBeenCalledWith({to: [user_3, user_random_a], cc: [user_random_b]})
|
|
|
|
|
|
|
|
describe "when there is not an existing draft at the bottom of the thread", ->
|
|
|
|
beforeEach ->
|
|
|
|
MessageStore._items = [m5, m3]
|
2015-08-01 03:06:34 +08:00
|
|
|
MessageStore._thread = test_thread
|
2015-07-14 07:30:02 +08:00
|
|
|
MessageStore.trigger()
|
|
|
|
|
|
|
|
it "should fire a composer action based on the reply type", ->
|
|
|
|
spyOn(Actions, 'composeReplyAll')
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply-all')
|
|
|
|
expect(Actions.composeReplyAll).toHaveBeenCalledWith(thread: test_thread, message: m3)
|
|
|
|
|
|
|
|
spyOn(Actions, 'composeReply')
|
|
|
|
@messageList._createReplyOrUpdateExistingDraft('reply')
|
|
|
|
expect(Actions.composeReply).toHaveBeenCalledWith(thread: test_thread, message: m3)
|
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
describe "Message minification", ->
|
|
|
|
beforeEach ->
|
|
|
|
@messageList.MINIFY_THRESHOLD = 3
|
|
|
|
@messageList.setState minified: true
|
|
|
|
@messages = [
|
|
|
|
{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}, {id: 'f'}, {id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "ignores the first message if it's collapsed", ->
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: false, c: false, d: false, e: false, f: false, g: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(@messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}]
|
|
|
|
},
|
|
|
|
{id: 'f'},
|
|
|
|
{id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "ignores the first message if it's expanded", ->
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: "default", b: false, c: false, d: false, e: false, f: false, g: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(@messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}]
|
|
|
|
},
|
|
|
|
{id: 'f'},
|
|
|
|
{id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "doesn't minify the last collapsed message", ->
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: false, c: false, d: false, e: false, f: "default", g: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(@messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'b'}, {id: 'c'}, {id: 'd'}]
|
|
|
|
},
|
|
|
|
{id: 'e'},
|
|
|
|
{id: 'f'},
|
|
|
|
{id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "allows explicitly expanded messages", ->
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: false, c: false, d: false, e: false, f: "explicit", g: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(@messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}]
|
|
|
|
},
|
|
|
|
{id: 'f'},
|
|
|
|
{id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "doesn't minify if the threshold isn't reached", ->
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: "default", c: false, d: "default", e: false, f: "default", g: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(@messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{id: 'b'},
|
|
|
|
{id: 'c'},
|
|
|
|
{id: 'd'},
|
|
|
|
{id: 'e'},
|
|
|
|
{id: 'f'},
|
|
|
|
{id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "doesn't minify if the threshold isn't reached due to the rule about not minifying the last collapsed messages", ->
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: false, c: false, d: false, e: "default", f: "default", g: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(@messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{id: 'b'},
|
|
|
|
{id: 'c'},
|
|
|
|
{id: 'd'},
|
|
|
|
{id: 'e'},
|
|
|
|
{id: 'f'},
|
|
|
|
{id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "minifies at the threshold if the message is explicitly expanded", ->
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: false, c: false, d: false, e: "explicit", f: "default", g: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(@messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'b'}, {id: 'c'}, {id: 'd'}]
|
|
|
|
},
|
|
|
|
{id: 'e'},
|
|
|
|
{id: 'f'},
|
|
|
|
{id: 'g'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "can have multiple minification blocks", ->
|
|
|
|
messages = [
|
|
|
|
{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}, {id: 'f'},
|
|
|
|
{id: 'g'}, {id: 'h'}, {id: 'i'}, {id: 'j'}, {id: 'k'}, {id: 'l'}
|
|
|
|
]
|
|
|
|
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: false, c: false, d: false, e: false, f: "default",
|
|
|
|
g: false, h: false, i: false, j: false, k: false, l: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'b'}, {id: 'c'}, {id: 'd'}]
|
|
|
|
},
|
|
|
|
{id: 'e'},
|
|
|
|
{id: 'f'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'g'}, {id: 'h'}, {id: 'i'}, {id: 'j'}]
|
|
|
|
},
|
|
|
|
{id: 'k'},
|
|
|
|
{id: 'l'}
|
|
|
|
]
|
|
|
|
|
|
|
|
it "can have multiple minification blocks next to explicitly expanded messages", ->
|
|
|
|
messages = [
|
|
|
|
{id: 'a'}, {id: 'b'}, {id: 'c'}, {id: 'd'}, {id: 'e'}, {id: 'f'},
|
|
|
|
{id: 'g'}, {id: 'h'}, {id: 'i'}, {id: 'j'}, {id: 'k'}, {id: 'l'}
|
|
|
|
]
|
|
|
|
|
|
|
|
@messageList.setState messagesExpandedState:
|
|
|
|
a: false, b: false, c: false, d: false, e: "explicit", f: "default",
|
|
|
|
g: false, h: false, i: false, j: false, k: "explicit", l: "default"
|
|
|
|
|
|
|
|
out = @messageList._messagesWithMinification(messages)
|
|
|
|
expect(out).toEqual [
|
|
|
|
{id: 'a'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'b'}, {id: 'c'}, {id: 'd'}]
|
|
|
|
},
|
|
|
|
{id: 'e'},
|
|
|
|
{id: 'f'},
|
|
|
|
{
|
|
|
|
type: "minifiedBundle"
|
|
|
|
messages: [{id: 'g'}, {id: 'h'}, {id: 'i'}, {id: 'j'}]
|
|
|
|
},
|
|
|
|
{id: 'k'},
|
|
|
|
{id: 'l'}
|
|
|
|
]
|