fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
<!DOCTYPE html>
|
|
|
|
|
<html style="background: #fff">
|
|
|
|
|
<head>
|
2016-02-10 08:30:05 +08:00
|
|
|
<title>Nylas N1</title>
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
2016-06-04 01:48:21 +08:00
|
|
|
<meta http-equiv="Content-Security-Policy" content="default-src * nylas:; script-src 'self' chrome-extension://react-developer-tools; style-src * 'unsafe-inline' nylas:; img-src * data: nylas: file:;">
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
feat(work): Create the "Work" window, move TaskQueue, Nylas sync workers
Summary:
Move sync workers and Edgehill token checks to work window
Move the task queue and database setup to the work window
Move ContactStore background refresh to work window
Store the task queue in the database
WIP
The TaskQueue now puts tasks in the database instead of in a file, which also means it can be observed
Move all delta sync and initial sync to a package, make NylasSyncStore which exposes read-only sync state
DraftStore no longer reads task status. Once you set the "sending" bit on a draft, it never gets unset. But that's fine actually.
If your package lists windowTypes, you *only* get loaded in those windowTypes. If you specify no windowTypes, you get loaded in the root window.
This means that onboarding, worker-ui, worker-sync, etc. no longer get loaded into the main window
ActivitySidebar has a special little store that observes the task queue since it's no longer in the window
Move "toggle component regions" / "toggle react remote" to the Developer menu
Move sync worker specs, update draft store specs to not rely on TaskQueue at all
Test Plan: Run existing tests, all pass
Reviewers: dillon, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1936
2015-08-28 07:39:40 +08:00
|
|
|
<style>
|
2015-08-29 05:24:11 +08:00
|
|
|
.application-loading-cover {
|
2016-06-02 06:43:18 +08:00
|
|
|
position: fixed;
|
|
|
|
|
top: 0;
|
|
|
|
|
left: 0;
|
|
|
|
|
right: 0;
|
|
|
|
|
bottom: 0;
|
|
|
|
|
z-index: 100000;
|
|
|
|
|
background: #F6F6F6;
|
2015-09-24 08:33:15 +08:00
|
|
|
text-align: center;
|
feat(work): Create the "Work" window, move TaskQueue, Nylas sync workers
Summary:
Move sync workers and Edgehill token checks to work window
Move the task queue and database setup to the work window
Move ContactStore background refresh to work window
Store the task queue in the database
WIP
The TaskQueue now puts tasks in the database instead of in a file, which also means it can be observed
Move all delta sync and initial sync to a package, make NylasSyncStore which exposes read-only sync state
DraftStore no longer reads task status. Once you set the "sending" bit on a draft, it never gets unset. But that's fine actually.
If your package lists windowTypes, you *only* get loaded in those windowTypes. If you specify no windowTypes, you get loaded in the root window.
This means that onboarding, worker-ui, worker-sync, etc. no longer get loaded into the main window
ActivitySidebar has a special little store that observes the task queue since it's no longer in the window
Move "toggle component regions" / "toggle react remote" to the Developer menu
Move sync worker specs, update draft store specs to not rely on TaskQueue at all
Test Plan: Run existing tests, all pass
Reviewers: dillon, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1936
2015-08-28 07:39:40 +08:00
|
|
|
}
|
|
|
|
|
</style>
|
fix(focus): Remove focusedField in favor of imperative focus, break apart ComposerView
Summary:
- Removes controlled focus in the composer!
- No React components ever perfom focus in lifecycle methods. Never again.
- A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus"
- The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus.
- The MessageList never focuses anything automatically.
- Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView
- ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon.
- Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing.
- Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want.
- Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature.
Todos:
- Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur.
- Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable.
- Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon.
Test Plan: Broken
Reviewers: juan, evan
Reviewed By: juan, evan
Differential Revision: https://phab.nylas.com/D2814
2016-04-05 06:22:01 +08:00
|
|
|
|
2016-02-19 08:09:30 +08:00
|
|
|
<script src="index.js"></script>
|
|
|
|
|
</head>
|
|
|
|
|
<body>
|
2015-09-02 01:27:37 +08:00
|
|
|
<div class="application-loading-cover" id="application-loading-cover">
|
2015-08-29 05:24:11 +08:00
|
|
|
<div class="application-loading-cover-centered">
|
2016-06-02 06:43:18 +08:00
|
|
|
<img style="width: 150px; height: 150px; margin-top: 90px;" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAALUAAAC7CAMAAAAUhy/rAAABX1BMVEUAAAACAgIBAQEBAQEAAAAAAAAAAAAAAAAAAAD///8BAQEDAwP09PQFBQUBAQECAgIDAwP///8LCwv+/v4BAQH////////////+/v7////+/v7////////+/v7////////////////9/f3////////////////9/f3////////5+fn////////////////////39/f///////////8SEhL///////////////9oaGj////////////////29vb////////q6uozMzPh4eHZ2dn////////////09PSBgYFNTU3///9ISEjw8PD////MzMz///+Tk5O0tLSXl5d5eXkzMzPt7e3R0dHy8vL////s7Oz///+bm5v///+xsbGrq6vp6enh4eHj4+PV1dX///////9fX1/////Gxsbi4uK8vLy8vLz///////+6urrKysrS0tLu7u709PTHx8f///8ncRFIAAAAdXRSTlMAEg8MCBAGDQoCHBgmFSEfGiICBBYGCg54e3YncgwcHxBVfBkza08YOXl2bmBBKhRzaDxIEXBbEi4jZFJ6Nm9iXV0dVFAsWE1sKSAWFWdLRDAqKSIcGWVHamdhPzBZODNZWU5JRkQcQz9HPjJmRTs0PB5dC4IqRDTyAAAN4ElEQVR42tWceXvbRBDGvWvJK0sokh3lJkdJQwq0ENpAytXSQoFCudKU+ygpLaScbfn+D1pJyUsyu9Sasf/oJHEcxdn5PSO9M7O7ijuTNjXsPHk2PZUFnSfO1rJ4KplsuIddpZQOxulkJVZpNmU6k7Khjqcai7tjG3UQK6XiqbzXmYiZErZIU6XSNInJxSijtuGehCqH+VScqiNL46liODZqa8kEVDnMMjCrJjrdcVLTQMih40wRw8Uop0Ygxmi3CHTjZXuM1ONWZTCVKqflU1lvfNSNKscE3b+KkWm406GQmgRiPKp8lCm/FVNZdzzUUCUCIbB7NNRyVYLaEYgxqHLmw8TDi8tES6gnkp7mrhItUlXGPTb1ZNLTJhlXokpKPZn09OCx1E1FjnjUk0lPqyNRqxR9sphanp76T2Fchiq51FClnFquSkotCYScGn0yg5oZCDk1+mQeNV+Vcmr0yXJqqDKaIDWiY8TU/vQkp5ZrH9QyVcqpoUo5NVWlnFquSlDLVCmnRp/MoJY1DaB+LWFho0+WU0OVvVGpL7+bg5uhSga1XJXr7y9ufZegx2Z4YVHLOtjZwd3XF37ChIbhhUEtVuXMSxffeOX5+0nBgIYXNjV3XtmfXTl/dv6L62xVZhGDWl7FptdefH/jmTt8VSZDBrW8is2sv/X94iWJKhnU8irWnxv88fXCT1dJuGUVeXAdgRD1ln5Vfnbq6ef/HK8qV88iPcl6S78qV789+9wXpFZKTupLF5CeGHqJR1XlC899mRBu9jR+ZuVbkp4mkLzXz7y6+MHngpPKSE/ylmp6bunCywvvQJWykypPT+60OiRePjpdqvIHfhJUjvT0+4JElZpSk4TeX149d/nNK3xVTjvSE2kaZGl1dgrax8V47dkX5j9lqjJee0x6kquy/yB2JfTZlTNvz3/F0378oO9rGr5kqhKLgpiBNZtqVJXPvMtRZfxU35eeoEpmSwVqcqzxslmqcuvHJBVTIxA/f430xGqpQO3V/vLg3OsLV6B9NjVUeZrXNGADDdTeacn0zsVnX5n/NUnE1FDlubPPfcNWpVUgqL2LBeWE4e35j68nbOqAqvJZNA286ttQQ6kuVX6y8YydxrOo+0hPwqYBquwfo/aq8q33oMqW1MsZSU/ipmEO1I76CVXaafztDxMG9UqMQEibBpQDUHvqJ6bxi6jIo1MPYqQn0jS0UyWGBzWpn9xpPKVGepI3DaB2LxYw+2RK7U9PUKWYGosF3D6ZUiM9UVXapoFDHYYqVKr6st9CqNLXJ4d4XfW34dEf2rEIdfUKryq3SlU2I4ZHY2Hw5hmltq6sHT2p/iyxqqR9clWR8Vr7rSY/NEJ9OCD2/GkrX9M13mv2w5HDEwZql9noqKGvTw6JuakxujsQ0zu1KgvvcKNSw0uWBZ5pfNGGGoHwNQ22lRdTw4uvIn+XqPbU1WWSeVt5ITWsUSXtk98sK3I7agQicbTyddMgpYab/H8q8ujUME/T8EvVysupqSppRWZQQ5WklYcqhdR+VUL7Lagfq8qyVsqoqSppRYaXUamhysjXwQqoW2ifQR26m4ZN6EVM7VflZlORW1JDld4OVkqN6FRTezqNfxPab0Htr5X1vFJETVVJtf9COY0vGNQeVTarPUpODS/+aXwLaoxYVKqkVcz2llJqqko6jb+aMKihSrpFdB96cVBrrUMdhtp+t2Z/rH+yH0dHm1+p3D+NV9Uox6ntMPazHrAeo/mon1u9aNcarD2BNag+8q41qFtZqGyfTCtyNY3XlPrxdqhKOuN7NynIq3nU8EKn8b8mKYNah03TQGd89gQKqeHFo8r6pI5ODbOqDFzrMLalklKDO81c0/hP7DS+JTUCUQwdJ9C2VCmlzgsWtspdFdlO46+3o8aIUCWd6JygXrpSJnQet7NP/uP3VznU0AtNq7bZKY5Rd1ZO2YSuOeaZxp9ZZ1FDL3SiY1sq9V/q5WvVplqqGRY6p/Fzs52W1LCqg6UnsG6pQI3FglAzTKXQPoxHDb34Wqq0oT5K6OUxbrihSik1qhhVZbMwcESNTTW5KuXUflVeKDfQPkxAjU01zTGVZ3lPQk1HjLN06FwYuJ/kDTU21X4oFM9Lo0pKbVMWa0TbW9INNKvAmhrHrFJ5XkKPKgcP7zMDESZZ4mypXl3qHz9WKbVIWV5UjlQLW3+jDA433HHmaqnON+UASq031YqQ66VLtL9kdxgY6cl3AvtzO7Mdz/I900tCVdmkJ65ecAKJ0eV7viqz7aF7z59/mRgXJ13Cs4sFfFXGgXvPn6/KvEehPYsFn/JVOXTv+fNVSdPqo8y7fM9UZbxsx6B7/s9w0xOdgvQ3Y+VdLLjF8pK77iCaEaWnk1OQ/iDXYZ4lnsUCzsWIkkvSk0iVaHbsDKw+5lssSI3W2pSf9qv+qE3r5rF+gX2ofwtq5w5DoZrB7GuBZeox6keMWr2q+l1qVQnqynma0WnJTrVYkCrTzkDtWTFNDcfsJZEOQY1j7sWCVJMhONTYYbCBYBiqr6XGMbpQ+GKtSjLCqNSePf9WgQC2ti3VITWOeRYLvktDA2tDnbn3/PdJIEYP9/CIGsdcd+LYPX/iZSTq2SxLPHv+3MskftRQwxql0ntjF+/DSwvqzRiBIHv+vHDnDypqolTfnn+qW1MPcmd6mt5hqBLDW2p66cSB+06cQjGokZ5o0wBVSqmNbbOce/5QZRtqpCeqSpueeNRJ13SrT3P0aMpwG/e9sbfSbmmmeXG3+nbiMTlGbQ8brW0g3Hv+adit7GjECuLomKmhYElD7TCdxknP/Q81tRe/naRu/Idx7Nnzv5d22xioqRmdN9MS2ien7agRiNxz+26qhNQwqJLcG5uqdtQIhPLs+6VaSg0viUP7601Fbk/drfQSeVp5JafGxeiuyKUqFYO6a6BK0sqnWkgN00XsrchhO2oEwrhbeahSRA1VeioygxqqdOz7pUpODVX6KzKDGqp0tvJianjxV2TTkhrpydPKKzE13OSxU5Xw4qP2jK6TOHWr8jelhdQwU8S+u/CUZlAjEI5aqQTU1Iv2eeFQd42radi5CL3IqFEict80PmxHjUBsO/XywefKyKnhxaP9m6olNWpl4KtiUmpY+D8VmUENVdLVnj9VKKaGKt3aX7wEVbaghipJFStnfEpATb14pvH3FIMaqqRrsHegShd1FEXlgz1UPWme1j/WT6Po6PdGOScMVpVK26GKk9RRafUgeP7fwU0ZCGdvaU9gFJ2gKyrqImplljuptU9vr9pT3ZPUI42o8rznnPHdvqei4w
|
|
|
|
|
<img style="width: 136px; height: 26px; margin-top: 2em;" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAARAAAAA0CAMAAAB1npezAAACK1BMVEUAAABMTExLS0tQUFBNTU1JSUlPT09ISEhGRkb////y8vL///////8/Pz////9FRUX///////9DQ0P///9RUVFBQUH///89PT2urq7////////////////+/v5TU1P///9mZmb///9UVFT///////88PDz////////5+flWVlb////5+fk+Pj7///////////////////////9gYGBiYmL///////9ycnKpqan+/v7+/v46Ojo/Pz+0tLQ+Pj7///////9ubm6UlJQ+Pj4/Pz////////8/Pz9XV1f///////////+kpKRERET///////93d3dhYWHV1dX///////////+mpqY/Pz////////////9paWk+Pj7///8+Pj7///9dXV1CQkJDQ0P///+MjIxsbGz////9/f1bW1tTU1NBQUGgoKD///9BQUH///+EhISgoKCKioo+Pj6lpaX///9+fn7R0dHw8PCTk5P8/Pz////19fXn5+d6enqysrL4+PjNzc3///+vr6/Pz8////9ISEi8vLxVVVX///////+2traSkpL////Z2dna2trExMS6urrBwcFpaWlLS0uUlJTGxsb///+Li4vq6url5eX///9jY2OioqLd3d3Z2dm1tbXi4uLZ2dmBgYHDw8Ph4eFmZmZKSko6Ojrn5+f19fWAgIBtbW3X19fJycl/f3/4+PihoaFqamqwsLDIyMhWVlahoaGWlpb///9ubm5sPOHgAAAAuXRSTlMATlBMTVFNUlMdDA2HWYNVhQJWAUtXBFxBGxmAZRRLIlB8SnNqDAdcEUlPCQZYdz0XX3FUUhJtUkY5RiVEPx59eVRNSjoKJhhHBnZiYC4ef1RBLysVSkcyLm9UUE9APkxEIxIPTT0gRFBQTj83NzRZVVVSSEE2MX5eUyh0c1FPgm5nZF9HRkU5MCppWDsydWtlXFRBPTYyLnpdVjszIWpbU1NTUUpJKRNoW0VDQTomfE0uKigiGRUtCA5Tge8AAA9WSURBVGje5Zr5VxNXFMeZfSBhMkkmoWQlC9nIihgLpATLFvZSoCyyimyyKBSKqFXqXrXaajdt7a7d9/XP632TkEkgQyna4znl/sB5mXfvd+77zLz37rxD3pMzfynYHp0f35CeP1P76VtfEZh/l8414Lv8JO++DILVWYk8desrLCzcPRBwHnqSdx8CweqsRPZqdYCzLscTBNv23lUXFhXFZHS07RqVRrfLPLQ1Oo2mTvvkeGjrNBrNuFZK5DGAIJ59W682FcHVLUD8I0XgKwek+QOWYTUFuxuk/geWZbGGJwekAQPBn/VZiezRYhoM0xU2bQUCT1CXDaRGV6hjcc2IjI7imaUbNz57oN7VTcvmWIo5EH5yQMIHGIqdK8hKZG/mElghwWqOZ79i6h9ULKv6I4Oyf6FQpyITBJtozi10sCqoVL7WuLs8Cp5hcOpA/pMDkn+AwpmXFVmJ7M3MFYx3bIzV1Gc/wQ9ZimJ/lUSbhgo1LINjFuaI+f8NpPgwnuga87K66qwp+RyD4+wremlL1WlYqmSJ9lIvGHILeYajNlvE+vSBSInsGQhNY5hquTTzDckC8mUdrB4MdfLMdZqUBdJwusrnC4WfPhApkb0CsdMvkDirqZMFIk6Xio+M/HVMHoi6wBwOe1zapw5ESmSvQEj69imMYnV9ckDGgcfSGY7nruOYBETGnhKQw0kgj20AhMLo22sVMP7CptxA1A322YudPNfyWhu1A5DSajDp55d9I3U6Xd1Iu39XQPw19XW6Il1dfY3kn6k0FKuv3tpT2h4bQiFfSkCkRNJNNKqmejEXuCqnAD7gW5oEgt3mb+E4k7H3ln2fAaSg+9OzHN/p7J0/ySAgu/k8aYoVFRWKVlRUXyoPRNrFwD3pP9SUnfNIWmmoJrtuTnfE/PkvSECkRMTmSF5pXZGkLaeQNwK+1SIQHH/Txl/AKdh7cwIxX2rhuaB7Phx+fkcgIHw8fadCqOxUYBoNfLT4/wGIvw/5Q+nDQtFdWLTgz1CVlKBnJLNuLixMhxx/IAGREkk260uXkXhKu1pOwV8Pvikg1MeR2vOHgYiuOhcQRWigMzraqFAf3AmI9jdIu06dfN6QAYt/8N4v760mWFZTWOffEYh/CIo+lmEsYxaGYVW6DIKlOlBiE5Ork2Ms6qnJk2Kgg2ESYxgaUdcSLgKREkk3r97VIImU9nJpTgWNpv4qMH+kBSCwUP4UihjfxzAS9t5NIDCRmM01pGM0cNMAy/bB5ykMlwOifw+q8dnkM1qGVfjhsC8QiQR8VyhGpavZBgSU0kD6AAc1e2490hpZPwfPRSWt73UaFWO/4gu43YNfzMA7vLyJakGnYqjZz79ujQS++JZhqBkMo15SSImkmxQFg56bhlzuvSrNgm0KLEuC52pzCsjUzSi3AQg0sVRB/04aCFhDh9UDxHcG0jCHHrrYeVTHUhXOFpuR44w2RxvOqNp3AnIUMsMPfVVrhH3MWPtVCfijz6hNJfyeqBSvPYvGM56OofBDZ+MoJOg8R+EYiYBkJ4Ka2BiNz37qDIq5LKHNtFROAUY8V5AEcsxs6G3hT2FQjfTlAKLW67V524DIj3EcbtXGcTbHQHmwk78F5C9rdwASAx4zP/JKyIyDv+9jQAQWi02lUxxvrA3WdvIoQUArxawplbwRYvjgSYzuQkCytcVmF4m9ZeNFPyXMAkpVI6NAigopIJ7mxkD8/AEEsCkbiGS7B3KVxfBTtabR0HxlVWDAuPb+Jw/08kBqYLnBrvNGx2vugPu1Fk55AT2Yo2Jf++ydw7c6o+7Rqt6AM34bUN0V0TZtxpjcgUi0ljszQyfI3EDs9JFaY4sJtJ02/gRIP8qTVxCBYBh+zKNVLJq4s9BU1flFIDjAfHEbELgqDwQ6K1Ae6veA5oFPu8OKAoVnasXJ8dHFAhlnsD4WmudtrSuvdxR3vD5tiq9hkLY4NdSGdRsfj1RO9Rw0589HbkMHrRdBsbgYM3w6v9j6rm+g802aoHEEJEsbmiRBb8RN06fzDVPvDra0YQT1gVZeYRPI8548tXl4gL9OwitV/7hAXG+gYKr9aHJMo7XK4CWzPJDLlJc8ZQv0e2BeavXmxUj8MIkx4tRw9Tt5zjk/oUZCf8zdwQR8RrEtpqx4JXqLlANCY2dN82bRr3HwAgz2oV5eQQICNyz21cIrhcG6hcZE7R2IInQKPWPY3OsW2pvKugPO1mF5IGoKJ7C21v4GbXK9Uiy+dgoG3qVGSjcHuKDP8FdT9UJsGRZBbAybMadjTNcKUjGG3jMYTeYGQuJnQh51ct1ffAsSmynYUQGA0PjzB9HjOB0xrlWQNHO8FAEhyVxAaOxVeSBkMo+JYccJyIOBokyn0xWSk2+cNpTJOEOTgQ3izSqzdrOe6eltIwWccCEg19bdn3xzuVAHBvsvTiawijCqCrbENDdGDpAZQMhMIAcCU8AjWT98jJN4iUdWIRuIVjHv5DaAgyr2eEAKKsuVG0cwHKdQKQRQlsfVWlkgZpTaW69L53Cu/o/hilhI6D0PJkUWqGzDPniZIMiKYrju2RKjNVfdkQVyZ8WTPmg8B11HzPIKEhARYE+Vg29Dy0h78xv43oHoT5s4Pn7v5W+8OEChGGDSJOMMZoCXEj9pkIhpp25gAjYjpuQ/jopu5vLVn9/7pXv6IgARgwyzJJkVU7ZIyQHB7lxzpQeAgBwO76hQfIi0YMcOJovNqUHb+RcI2Hyb3sAIAt8OBCNIeSDQWZKffOlbeJ4LRk3rXzz7jR2DempIxhms4zPSi32WucYYDpNj5JEwatZDCYuvvrgY6h2MOB0bhJAM6jhE2LFjGTHqF3GCwJ5VZGinm3ek08SJZ+H3IcOOChIQhKm/1XiWACKX39kzELBmq2/AyKOap9YRjRwDPdVRWXrWk6Qdg3ktmXmWFMgbaGo0wbqB
|
2015-08-29 05:24:11 +08:00
|
|
|
</div>
|
feat(work): Create the "Work" window, move TaskQueue, Nylas sync workers
Summary:
Move sync workers and Edgehill token checks to work window
Move the task queue and database setup to the work window
Move ContactStore background refresh to work window
Store the task queue in the database
WIP
The TaskQueue now puts tasks in the database instead of in a file, which also means it can be observed
Move all delta sync and initial sync to a package, make NylasSyncStore which exposes read-only sync state
DraftStore no longer reads task status. Once you set the "sending" bit on a draft, it never gets unset. But that's fine actually.
If your package lists windowTypes, you *only* get loaded in those windowTypes. If you specify no windowTypes, you get loaded in the root window.
This means that onboarding, worker-ui, worker-sync, etc. no longer get loaded into the main window
ActivitySidebar has a special little store that observes the task queue since it's no longer in the window
Move "toggle component regions" / "toggle react remote" to the Developer menu
Move sync worker specs, update draft store specs to not rely on TaskQueue at all
Test Plan: Run existing tests, all pass
Reviewers: dillon, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1936
2015-08-28 07:39:40 +08:00
|
|
|
</div>
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
</body>
|
|
|
|
|
</html>
|
