Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-24 16:14:01 +08:00
Code Issues Projects Releases Packages Wiki Activity
Mailspring/build/config/eslint.json

26 lines
490 B
JSON
Raw Normal View History

Update grunt tasks to lint and transpile es6 code using babel Summary: - Linter uses predefined rules for ES6 and React from airbnb Test Plan: - Manuel Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2242
2015-11-07 08:54:56 +08:00
{
"extends": "airbnb",
"globals": {
add(integration-test): Adds test for onboarding flow with Exchange Summary: - Make sure user can log in using exchange - Adds some test helpers for the test - Updates eslint.json and cleans up lint errors Test Plan: - Integration Tests Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2346
2015-12-13 06:11:22 +08:00
"NylasEnv": false,
"$n": false
Update grunt tasks to lint and transpile es6 code using babel Summary: - Linter uses predefined rules for ES6 and React from airbnb Test Plan: - Manuel Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2242
2015-11-07 08:54:56 +08:00
},
"env": {
"browser": true,
"node": true,
"jasmine": true
},
"rules": {
"react/prop-types": [2, {"ignore": ["children"]}],
"eqeqeq": [2, "smart"],
"id-length": [0],
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes Summary: 1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`, `UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is or trivially overridden to easily update simple objects. Hopefully all of the boilerplate rollback, error handling, and undo logic won't have to be re-duplicated on every task. There are also tests for these tasks. We use them to perform mutating actions on `Metadata` objects. 1. **Failing on Promise Rejects**: Turns out that if a Promise rejected due to an error or `Promise.reject` we were ignoring it and letting tests pass. Now, tests will Fail if any unhandled promise rejects. This uncovered a variety of errors throughout the test suite that had to be fixed. The most significant one was during the `theme-manager` tests when all packages (and their stores with async DB requests) was loaded. Long after the `theme-manager` specs finished, those DB requests were (somtimes) silently failing. 1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually make queries on the database. Furthremore, the `inTransaction` block doesn't resolve at all unless `_query` is stubbed. Instead of manually remembering to do this in every test that touches the DB, it's now mocked in `spec_helper`. This broke a handful of tests that needed to be manually fixed. 1. **ESLint Fixes**: Some minor fixes to the linter config to prevent yelling about minor ES6 things and ensuring we have the correct parser. Test Plan: new tests Reviewers: bengotow, juan, drew Differential Revision: https://phab.nylas.com/D2419 Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
"object-curly-spacing": [0],
"no-console": [0],
feat(components): Add EditableList component to component-kit Summary: - Generic list component wich supports adding, editing and removing string-like items or components - Needs some css love Test Plan: - Unit tests. Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2322
2015-12-05 09:13:04 +08:00
"no-loop-func": [0],
fix(extension-adapter): Update adapter to support all versions of extension api we've used Summary: - Rewrites composer extension adpater to support all versions of the ComposerExtension API we've ever declared. This will allow old plugins (or plugins that haven't been reinstalled after update) to keep functioning without breaking N1 - Adds specs Test Plan: - Unit tests Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2399
2015-12-31 00:36:47 +08:00
"new-cap": [2, {"capIsNew": false}],
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes Summary: 1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`, `UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is or trivially overridden to easily update simple objects. Hopefully all of the boilerplate rollback, error handling, and undo logic won't have to be re-duplicated on every task. There are also tests for these tasks. We use them to perform mutating actions on `Metadata` objects. 1. **Failing on Promise Rejects**: Turns out that if a Promise rejected due to an error or `Promise.reject` we were ignoring it and letting tests pass. Now, tests will Fail if any unhandled promise rejects. This uncovered a variety of errors throughout the test suite that had to be fixed. The most significant one was during the `theme-manager` tests when all packages (and their stores with async DB requests) was loaded. Long after the `theme-manager` specs finished, those DB requests were (somtimes) silently failing. 1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually make queries on the database. Furthremore, the `inTransaction` block doesn't resolve at all unless `_query` is stubbed. Instead of manually remembering to do this in every test that touches the DB, it's now mocked in `spec_helper`. This broke a handful of tests that needed to be manually fixed. 1. **ESLint Fixes**: Some minor fixes to the linter config to prevent yelling about minor ES6 things and ensuring we have the correct parser. Test Plan: new tests Reviewers: bengotow, juan, drew Differential Revision: https://phab.nylas.com/D2419 Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
"no-shadow": [1],
"quotes": [0],
"semi": [0]
},
"parser": "babel-eslint"
Update grunt tasks to lint and transpile es6 code using babel Summary: - Linter uses predefined rules for ES6 and React from airbnb Test Plan: - Manuel Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2242
2015-11-07 08:54:56 +08:00
}
Reference in a new issue Copy permalink