2015-02-25 08:20:57 +08:00
|
|
|
proxyquire = require 'proxyquire'
|
|
|
|
React = require "react/addons"
|
|
|
|
ReactTestUtils = React.addons.TestUtils
|
|
|
|
|
|
|
|
{Contact,
|
|
|
|
Message,
|
|
|
|
File,
|
2015-03-11 02:05:30 +08:00
|
|
|
Thread,
|
2015-03-21 07:16:09 +08:00
|
|
|
Utils,
|
2015-07-09 00:51:33 +08:00
|
|
|
QuotedHTMLParser,
|
2015-08-18 07:23:12 +08:00
|
|
|
FileDownloadStore,
|
|
|
|
MessageBodyProcessor} = require "nylas-exports"
|
2015-02-25 08:20:57 +08:00
|
|
|
|
2015-11-07 07:53:21 +08:00
|
|
|
MessageItemBody = React.createClass({render: -> <div></div>})
|
feat(unsafe-components): Wrap injected components, catch exceptions, clean up ComponentRegistry
Summary:
This diff gives the ComponentRegistry a cleaner, smaller API. Instead of querying by name, location or role,
it's now just location and role, and you can register components for one or more location and one or more
roles without assigning the entries in the registry separate names.
When you register with the ComponentRegistry, the syntax is also cleaner and uses the component's displayName
instead of requiring you to provide a name. You also provide the actual component when unregistering, ensuring
that you can't unregister someone else's component.
InjectedComponent and InjectedComponentSet now wrap their children in UnsafeComponent, which prevents
render/component lifecycle problems from propogating.
Existing components have been updated:
1. maxWidth / minWidth are now containerStyles.maxWidth/minWidth
2. displayName is now required to use the CR.
3. containerRequired = false can be provided to exempt a component from being wrapped in an UnsafeComponent.
This is useful because it's slightly faster and keeps DOM flat.
This diff also makes the "Show Component Regions" more awesome. It displays column regions, since they now
use the InjectedComponentSet, and also shows for InjectedComponent as well as InjectedComponentSet.
Change ComponentRegistry syntax, lots more work on safely wrapping items. See description.
Fix for inline flexbox scenarios (message actions)
Allow ~/.inbox/packages to be symlinked to a github repo
Test Plan: Run tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1457
2015-05-01 07:10:15 +08:00
|
|
|
|
2015-05-15 08:08:30 +08:00
|
|
|
{InjectedComponent} = require 'nylas-component-kit'
|
2015-06-12 02:52:49 +08:00
|
|
|
|
2015-02-25 08:20:57 +08:00
|
|
|
file = new File
|
|
|
|
id: 'file_1_id'
|
|
|
|
filename: 'a.png'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_not_downloaded = new File
|
|
|
|
id: 'file_2_id'
|
|
|
|
filename: 'b.png'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_inline = new File
|
|
|
|
id: 'file_inline_id'
|
|
|
|
filename: 'c.png'
|
|
|
|
contentId: 'file_inline_id'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_inline_downloading = new File
|
|
|
|
id: 'file_inline_downloading_id'
|
|
|
|
filename: 'd.png'
|
|
|
|
contentId: 'file_inline_downloading_id'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
|
|
|
file_inline_not_downloaded = new File
|
|
|
|
id: 'file_inline_not_downloaded_id'
|
|
|
|
filename: 'e.png'
|
|
|
|
contentId: 'file_inline_not_downloaded_id'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
2015-03-14 01:55:28 +08:00
|
|
|
file_cid_but_not_referenced = new File
|
|
|
|
id: 'file_cid_but_not_referenced'
|
|
|
|
filename: 'f.png'
|
|
|
|
contentId: 'file_cid_but_not_referenced'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
2015-05-29 09:15:47 +08:00
|
|
|
file_cid_but_not_referenced_or_image = new File
|
|
|
|
id: 'file_cid_but_not_referenced_or_image'
|
|
|
|
filename: 'ansible notes.txt'
|
|
|
|
contentId: 'file_cid_but_not_referenced_or_image'
|
|
|
|
contentType: 'text/plain'
|
|
|
|
size: 300
|
2015-06-26 00:51:46 +08:00
|
|
|
file_without_filename = new File
|
|
|
|
id: 'file_without_filename'
|
|
|
|
contentType: 'image/png'
|
|
|
|
size: 10
|
2015-02-25 08:20:57 +08:00
|
|
|
|
|
|
|
download =
|
|
|
|
fileId: 'file_1_id'
|
|
|
|
download_inline =
|
|
|
|
fileId: 'file_inline_downloading_id'
|
|
|
|
|
|
|
|
user_1 = new Contact
|
|
|
|
name: "User One"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user1@nylas.com"
|
2015-02-25 08:20:57 +08:00
|
|
|
user_2 = new Contact
|
|
|
|
name: "User Two"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user2@nylas.com"
|
2015-02-25 08:20:57 +08:00
|
|
|
user_3 = new Contact
|
|
|
|
name: "User Three"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user3@nylas.com"
|
2015-02-25 08:20:57 +08:00
|
|
|
user_4 = new Contact
|
|
|
|
name: "User Four"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user4@nylas.com"
|
2015-02-25 08:20:57 +08:00
|
|
|
user_5 = new Contact
|
|
|
|
name: "User Five"
|
2015-05-15 08:08:30 +08:00
|
|
|
email: "user5@nylas.com"
|
2015-02-25 08:20:57 +08:00
|
|
|
|
|
|
|
|
2015-03-21 08:51:49 +08:00
|
|
|
MessageItem = proxyquire '../lib/message-item',
|
2015-11-07 07:53:21 +08:00
|
|
|
'./message-item-body': MessageItemBody
|
2015-02-25 08:20:57 +08:00
|
|
|
|
2015-03-21 08:51:49 +08:00
|
|
|
MessageTimestamp = require '../lib/message-timestamp'
|
2015-03-10 02:17:22 +08:00
|
|
|
|
2015-02-25 08:20:57 +08:00
|
|
|
|
|
|
|
describe "MessageItem", ->
|
|
|
|
beforeEach ->
|
|
|
|
spyOn(FileDownloadStore, 'pathForFile').andCallFake (f) ->
|
|
|
|
return '/fake/path.png' if f.id is file.id
|
|
|
|
return '/fake/path-inline.png' if f.id is file_inline.id
|
|
|
|
return '/fake/path-downloading.png' if f.id is file_inline_downloading.id
|
|
|
|
return null
|
2015-06-16 09:48:17 +08:00
|
|
|
spyOn(FileDownloadStore, 'downloadDataForFiles').andCallFake (ids) ->
|
2015-02-25 08:20:57 +08:00
|
|
|
return {'file_1_id': download, 'file_inline_downloading_id': download_inline}
|
|
|
|
|
2015-08-18 07:23:12 +08:00
|
|
|
spyOn(MessageBodyProcessor, 'addToCache').andCallFake ->
|
|
|
|
|
2015-02-25 08:20:57 +08:00
|
|
|
@message = new Message
|
|
|
|
id: "111"
|
|
|
|
from: [user_1]
|
|
|
|
to: [user_2]
|
|
|
|
cc: [user_3, user_4]
|
|
|
|
bcc: null
|
|
|
|
body: "Body One"
|
|
|
|
date: new Date(1415814587)
|
|
|
|
draft: false
|
|
|
|
files: []
|
|
|
|
unread: false
|
|
|
|
snippet: "snippet one..."
|
|
|
|
subject: "Subject One"
|
|
|
|
threadId: "thread_12345"
|
2015-08-29 02:12:53 +08:00
|
|
|
accountId: TEST_ACCOUNT_ID
|
2015-02-25 08:20:57 +08:00
|
|
|
|
2015-03-11 02:05:30 +08:00
|
|
|
@thread = new Thread
|
|
|
|
id: 'thread-111'
|
|
|
|
|
2015-02-25 08:20:57 +08:00
|
|
|
@threadParticipants = [user_1, user_2, user_3, user_4]
|
2015-03-10 02:17:22 +08:00
|
|
|
|
2015-02-25 08:20:57 +08:00
|
|
|
# Generate the test component. Should be called after @message is configured
|
|
|
|
# for the test, since MessageItem assumes attributes of the message will not
|
|
|
|
# change after getInitialState runs.
|
|
|
|
@createComponent = ({collapsed} = {}) =>
|
|
|
|
collapsed ?= false
|
|
|
|
@component = ReactTestUtils.renderIntoDocument(
|
|
|
|
<MessageItem key={@message.id}
|
|
|
|
message={@message}
|
2015-03-11 02:05:30 +08:00
|
|
|
thread={@thread}
|
2015-07-24 01:57:13 +08:00
|
|
|
collapsed={collapsed} />
|
2015-02-25 08:20:57 +08:00
|
|
|
)
|
2015-03-10 02:17:22 +08:00
|
|
|
|
|
|
|
# TODO: We currently don't support collapsed messages
|
|
|
|
# describe "when collapsed", ->
|
|
|
|
# beforeEach ->
|
|
|
|
# @createComponent({collapsed: true})
|
|
|
|
#
|
|
|
|
# it "should not render the EmailFrame", ->
|
|
|
|
# expect( -> ReactTestUtils.findRenderedComponentWithType(@component, EmailFrameStub)).toThrow()
|
|
|
|
#
|
|
|
|
# it "should have the `collapsed` class", ->
|
2015-04-25 02:33:10 +08:00
|
|
|
# expect(React.findDOMNode(@component).className.indexOf('collapsed') >= 0).toBe(true)
|
2015-03-10 02:17:22 +08:00
|
|
|
|
|
|
|
describe "when displaying detailed headers", ->
|
2015-02-25 08:20:57 +08:00
|
|
|
beforeEach ->
|
2015-03-10 02:17:22 +08:00
|
|
|
@createComponent({collapsed: false})
|
|
|
|
@component.setState detailedHeaders: true
|
2015-02-25 08:20:57 +08:00
|
|
|
|
2015-03-10 02:17:22 +08:00
|
|
|
it "correctly sets the participant states", ->
|
|
|
|
participants = ReactTestUtils.findRenderedDOMComponentWithClass(@component, "expanded-participants")
|
|
|
|
expect(participants).toBeDefined()
|
|
|
|
expect(-> ReactTestUtils.findRenderedDOMComponentWithClass(@component, "collapsed-participants")).toThrow()
|
2015-02-25 08:20:57 +08:00
|
|
|
|
2015-03-10 02:17:22 +08:00
|
|
|
it "correctly sets the timestamp", ->
|
|
|
|
ts = ReactTestUtils.findRenderedComponentWithType(@component, MessageTimestamp)
|
|
|
|
expect(ts.props.isDetailed).toBe true
|
2015-02-25 08:20:57 +08:00
|
|
|
|
|
|
|
describe "when not collapsed", ->
|
|
|
|
beforeEach ->
|
|
|
|
@createComponent({collapsed: false})
|
|
|
|
|
2015-11-07 07:53:21 +08:00
|
|
|
it "should render the MessageItemBody", ->
|
|
|
|
frame = ReactTestUtils.findRenderedComponentWithType(@component, MessageItemBody)
|
2015-02-25 08:20:57 +08:00
|
|
|
expect(frame).toBeDefined()
|
|
|
|
|
|
|
|
it "should not have the `collapsed` class", ->
|
2015-04-25 02:33:10 +08:00
|
|
|
expect(React.findDOMNode(@component).className.indexOf('collapsed') >= 0).toBe(false)
|
2015-03-14 01:55:28 +08:00
|
|
|
|
2015-02-25 08:20:57 +08:00
|
|
|
describe "when the message contains attachments", ->
|
|
|
|
beforeEach ->
|
2015-03-14 01:55:28 +08:00
|
|
|
@message.files = [
|
|
|
|
file,
|
|
|
|
file_not_downloaded,
|
|
|
|
file_cid_but_not_referenced,
|
2015-05-29 09:15:47 +08:00
|
|
|
file_cid_but_not_referenced_or_image,
|
2015-03-14 01:55:28 +08:00
|
|
|
|
|
|
|
file_inline,
|
|
|
|
file_inline_downloading,
|
|
|
|
file_inline_not_downloaded,
|
2015-06-26 00:51:46 +08:00
|
|
|
file_without_filename
|
2015-03-14 01:55:28 +08:00
|
|
|
]
|
|
|
|
@message.body = """
|
|
|
|
<img alt=\"A\" src=\"cid:#{file_inline.contentId}\"/>
|
|
|
|
<img alt=\"B\" src=\"cid:#{file_inline_downloading.contentId}\"/>
|
|
|
|
<img alt=\"C\" src=\"cid:#{file_inline_not_downloaded.contentId}\"/>
|
|
|
|
<img src=\"cid:missing-attachment\"/>
|
|
|
|
"""
|
2015-02-25 08:20:57 +08:00
|
|
|
@createComponent()
|
|
|
|
|
|
|
|
it "should include the attachments area", ->
|
|
|
|
attachments = ReactTestUtils.findRenderedDOMComponentWithClass(@component, 'attachments-area')
|
|
|
|
expect(attachments).toBeDefined()
|
|
|
|
|
feat(unsafe-components): Wrap injected components, catch exceptions, clean up ComponentRegistry
Summary:
This diff gives the ComponentRegistry a cleaner, smaller API. Instead of querying by name, location or role,
it's now just location and role, and you can register components for one or more location and one or more
roles without assigning the entries in the registry separate names.
When you register with the ComponentRegistry, the syntax is also cleaner and uses the component's displayName
instead of requiring you to provide a name. You also provide the actual component when unregistering, ensuring
that you can't unregister someone else's component.
InjectedComponent and InjectedComponentSet now wrap their children in UnsafeComponent, which prevents
render/component lifecycle problems from propogating.
Existing components have been updated:
1. maxWidth / minWidth are now containerStyles.maxWidth/minWidth
2. displayName is now required to use the CR.
3. containerRequired = false can be provided to exempt a component from being wrapped in an UnsafeComponent.
This is useful because it's slightly faster and keeps DOM flat.
This diff also makes the "Show Component Regions" more awesome. It displays column regions, since they now
use the InjectedComponentSet, and also shows for InjectedComponent as well as InjectedComponentSet.
Change ComponentRegistry syntax, lots more work on safely wrapping items. See description.
Fix for inline flexbox scenarios (message actions)
Allow ~/.inbox/packages to be symlinked to a github repo
Test Plan: Run tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1457
2015-05-01 07:10:15 +08:00
|
|
|
it "should render the registered an injected component for each attachment", ->
|
|
|
|
attachments = ReactTestUtils.scryRenderedComponentsWithTypeAndProps(@component, InjectedComponent, matching: {role: 'Attachment'})
|
|
|
|
expect(attachments[0].props.exposedProps.file).toBe(file)
|
2015-03-14 01:55:28 +08:00
|
|
|
|
|
|
|
it "should list attachments that are not mentioned in the body via cid", ->
|
feat(unsafe-components): Wrap injected components, catch exceptions, clean up ComponentRegistry
Summary:
This diff gives the ComponentRegistry a cleaner, smaller API. Instead of querying by name, location or role,
it's now just location and role, and you can register components for one or more location and one or more
roles without assigning the entries in the registry separate names.
When you register with the ComponentRegistry, the syntax is also cleaner and uses the component's displayName
instead of requiring you to provide a name. You also provide the actual component when unregistering, ensuring
that you can't unregister someone else's component.
InjectedComponent and InjectedComponentSet now wrap their children in UnsafeComponent, which prevents
render/component lifecycle problems from propogating.
Existing components have been updated:
1. maxWidth / minWidth are now containerStyles.maxWidth/minWidth
2. displayName is now required to use the CR.
3. containerRequired = false can be provided to exempt a component from being wrapped in an UnsafeComponent.
This is useful because it's slightly faster and keeps DOM flat.
This diff also makes the "Show Component Regions" more awesome. It displays column regions, since they now
use the InjectedComponentSet, and also shows for InjectedComponent as well as InjectedComponentSet.
Change ComponentRegistry syntax, lots more work on safely wrapping items. See description.
Fix for inline flexbox scenarios (message actions)
Allow ~/.inbox/packages to be symlinked to a github repo
Test Plan: Run tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1457
2015-05-01 07:10:15 +08:00
|
|
|
attachments = ReactTestUtils.scryRenderedComponentsWithTypeAndProps(@component, InjectedComponent, matching: {role: 'Attachment'})
|
2015-06-26 00:51:46 +08:00
|
|
|
expect(attachments.length).toEqual(5)
|
feat(unsafe-components): Wrap injected components, catch exceptions, clean up ComponentRegistry
Summary:
This diff gives the ComponentRegistry a cleaner, smaller API. Instead of querying by name, location or role,
it's now just location and role, and you can register components for one or more location and one or more
roles without assigning the entries in the registry separate names.
When you register with the ComponentRegistry, the syntax is also cleaner and uses the component's displayName
instead of requiring you to provide a name. You also provide the actual component when unregistering, ensuring
that you can't unregister someone else's component.
InjectedComponent and InjectedComponentSet now wrap their children in UnsafeComponent, which prevents
render/component lifecycle problems from propogating.
Existing components have been updated:
1. maxWidth / minWidth are now containerStyles.maxWidth/minWidth
2. displayName is now required to use the CR.
3. containerRequired = false can be provided to exempt a component from being wrapped in an UnsafeComponent.
This is useful because it's slightly faster and keeps DOM flat.
This diff also makes the "Show Component Regions" more awesome. It displays column regions, since they now
use the InjectedComponentSet, and also shows for InjectedComponent as well as InjectedComponentSet.
Change ComponentRegistry syntax, lots more work on safely wrapping items. See description.
Fix for inline flexbox scenarios (message actions)
Allow ~/.inbox/packages to be symlinked to a github repo
Test Plan: Run tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1457
2015-05-01 07:10:15 +08:00
|
|
|
expect(attachments[0].props.exposedProps.file).toBe(file)
|
|
|
|
expect(attachments[1].props.exposedProps.file).toBe(file_not_downloaded)
|
|
|
|
expect(attachments[2].props.exposedProps.file).toBe(file_cid_but_not_referenced)
|
2015-05-29 09:15:47 +08:00
|
|
|
expect(attachments[3].props.exposedProps.file).toBe(file_cid_but_not_referenced_or_image)
|
|
|
|
|
feat(unsafe-components): Wrap injected components, catch exceptions, clean up ComponentRegistry
Summary:
This diff gives the ComponentRegistry a cleaner, smaller API. Instead of querying by name, location or role,
it's now just location and role, and you can register components for one or more location and one or more
roles without assigning the entries in the registry separate names.
When you register with the ComponentRegistry, the syntax is also cleaner and uses the component's displayName
instead of requiring you to provide a name. You also provide the actual component when unregistering, ensuring
that you can't unregister someone else's component.
InjectedComponent and InjectedComponentSet now wrap their children in UnsafeComponent, which prevents
render/component lifecycle problems from propogating.
Existing components have been updated:
1. maxWidth / minWidth are now containerStyles.maxWidth/minWidth
2. displayName is now required to use the CR.
3. containerRequired = false can be provided to exempt a component from being wrapped in an UnsafeComponent.
This is useful because it's slightly faster and keeps DOM flat.
This diff also makes the "Show Component Regions" more awesome. It displays column regions, since they now
use the InjectedComponentSet, and also shows for InjectedComponent as well as InjectedComponentSet.
Change ComponentRegistry syntax, lots more work on safely wrapping items. See description.
Fix for inline flexbox scenarios (message actions)
Allow ~/.inbox/packages to be symlinked to a github repo
Test Plan: Run tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1457
2015-05-01 07:10:15 +08:00
|
|
|
it "should provide file download state to each InjectedComponent", ->
|
|
|
|
attachments = ReactTestUtils.scryRenderedComponentsWithTypeAndProps(@component, InjectedComponent, matching: {role: 'Attachment'})
|
|
|
|
expect(attachments[0].props.exposedProps.download).toBe(download)
|
|
|
|
expect(attachments[1].props.exposedProps.download).toBe(undefined)
|
2015-02-25 08:20:57 +08:00
|
|
|
|
2015-05-29 09:15:47 +08:00
|
|
|
it "should still list attachments when the message has no body", ->
|
|
|
|
@message.body = ""
|
|
|
|
@createComponent()
|
|
|
|
attachments = ReactTestUtils.scryRenderedComponentsWithTypeAndProps(@component, InjectedComponent, matching: {role: 'Attachment'})
|
2015-06-26 00:51:46 +08:00
|
|
|
expect(attachments.length).toEqual(8)
|