2015-11-07 08:54:56 +08:00
|
|
|
{
|
|
|
|
|
"extends": "airbnb",
|
|
|
|
|
"globals": {
|
2015-12-13 06:11:22 +08:00
|
|
|
"NylasEnv": false,
|
2016-03-04 04:37:20 +08:00
|
|
|
"$n": false,
|
2016-03-15 06:34:16 +08:00
|
|
|
"waitsForPromise": false,
|
2016-03-15 08:04:40 +08:00
|
|
|
"advanceClock": false,
|
2016-03-25 10:35:24 +08:00
|
|
|
"TEST_ACCOUNT_ID": false,
|
|
|
|
|
"TEST_ACCOUNT_NAME": false,
|
|
|
|
|
"TEST_ACCOUNT_ALIAS_EMAIL": false
|
2015-11-07 08:54:56 +08:00
|
|
|
},
|
|
|
|
|
"env": {
|
|
|
|
|
"browser": true,
|
|
|
|
|
"node": true,
|
|
|
|
|
"jasmine": true
|
|
|
|
|
},
|
|
|
|
|
"rules": {
|
|
|
|
|
"react/prop-types": [2, {"ignore": ["children"]}],
|
2016-02-24 07:40:44 +08:00
|
|
|
"react/no-multi-comp": [0],
|
2016-03-15 03:30:54 +08:00
|
|
|
"react/sort-comp": [2],
|
2015-11-07 08:54:56 +08:00
|
|
|
"eqeqeq": [2, "smart"],
|
|
|
|
|
"id-length": [0],
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
"object-curly-spacing": [0],
|
|
|
|
|
"no-console": [0],
|
2015-12-05 09:13:04 +08:00
|
|
|
"no-loop-func": [0],
|
2016-03-03 02:05:17 +08:00
|
|
|
"no-constant-condition": [0],
|
2015-12-31 00:36:47 +08:00
|
|
|
"new-cap": [2, {"capIsNew": false}],
|
feat(tasks): add Create, Update, Destroy tasks plus spec & lint fixes
Summary:
1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`,
`UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is
or trivially overridden to easily update simple objects. Hopefully all of
the boilerplate rollback, error handling, and undo logic won't have to be
re-duplicated on every task. There are also tests for these tasks. We use
them to perform mutating actions on `Metadata` objects.
1. **Failing on Promise Rejects**: Turns out that if a Promise rejected
due to an error or `Promise.reject` we were ignoring it and letting tests
pass. Now, tests will Fail if any unhandled promise rejects. This
uncovered a variety of errors throughout the test suite that had to be
fixed. The most significant one was during the `theme-manager` tests when
all packages (and their stores with async DB requests) was loaded. Long
after the `theme-manager` specs finished, those DB requests were
(somtimes) silently failing.
1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually
make queries on the database. Furthremore, the `inTransaction` block
doesn't resolve at all unless `_query` is stubbed. Instead of manually
remembering to do this in every test that touches the DB, it's now mocked
in `spec_helper`. This broke a handful of tests that needed to be manually
fixed.
1. **ESLint Fixes**: Some minor fixes to the linter config to prevent
yelling about minor ES6 things and ensuring we have the correct parser.
Test Plan: new tests
Reviewers: bengotow, juan, drew
Differential Revision: https://phab.nylas.com/D2419
Remove cloudState and N1-Send-Later
2016-01-05 08:39:14 +08:00
|
|
|
"no-shadow": [1],
|
|
|
|
|
"quotes": [0],
|
|
|
|
|
"semi": [0]
|
|
|
|
|
},
|
|
|
|
|
"parser": "babel-eslint"
|
2015-11-07 08:54:56 +08:00
|
|
|
}
|
