2015-06-26 01:33:26 +08:00
|
|
|
React = require "react/addons"
|
|
|
|
|
TestUtils = React.addons.TestUtils
|
|
|
|
|
{Thread, FocusedContentStore, Actions, AddRemoveTagsTask} = require "nylas-exports"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
MessageToolbarItems = require '../lib/message-toolbar-items'
|
|
|
|
|
|
|
|
|
|
test_thread = (new Thread).fromJSON({
|
|
|
|
|
"id" : "thread_12345"
|
|
|
|
|
"subject" : "Subject 12345"
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
test_thread_starred = (new Thread).fromJSON({
|
|
|
|
|
"id" : "thread_starred_12345"
|
|
|
|
|
"subject" : "Subject 12345"
|
|
|
|
|
"tags": [{"id": "starred"}]
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
describe "MessageToolbarItem starring", ->
|
|
|
|
|
it "stars a thread if the star button is clicked and thread is unstarred", ->
|
|
|
|
|
spyOn(FocusedContentStore, "focused").andCallFake ->
|
|
|
|
|
test_thread
|
|
|
|
|
spyOn(Actions, 'queueTask')
|
|
|
|
|
messageToolbarItems = TestUtils.renderIntoDocument(<MessageToolbarItems />)
|
|
|
|
|
|
|
|
|
|
starButton = React.findDOMNode(messageToolbarItems.refs.starButton)
|
|
|
|
|
TestUtils.Simulate.click starButton
|
|
|
|
|
|
feat(offline-mode, undo-redo): Tasks handle network errors better and retry, undo/redo based on tasks
Summary:
This diff does a couple things:
- Undo redo with a new undo/redo store that maintains it's own queue of undo/redo tasks. This queue is separate from the TaskQueue because not all tasks should be considered for undo history! Right now just the AddRemoveTagsTask is undoable.
- NylasAPI.makeRequest now returns a promise which resolves with the result or rejects with an error. For things that still need them, there's still `success` and `error` callbacks. I also added `started:(req) ->` which allows you to get the underlying request.
- Aborting a NylasAPI request now makes it call it's error callback / promise reject.
- You can now run code after perform local has completed using this syntax:
```
task = new AddRemoveTagsTask(focused, ['archive'], ['inbox'])
task.waitForPerformLocal().then ->
Actions.setFocus(collection: 'thread', item: nextFocus)
Actions.setCursorPosition(collection: 'thread', item: nextKeyboard)
Actions.queueTask(task)
```
- In specs, you can now use `advanceClock` to get through a Promise.then/catch/finally. Turns out it was using something low level and not using setTimeout(0).
- The TaskQueue uses promises better and defers a lot of the complexity around queueState for performLocal/performRemote to a task subclass called APITask. APITask implements "perform" and breaks it into "performLocal" and "performRemote".
- All tasks either resolve or reject. They're always removed from the queue, unless they resolve with Task.Status.Retry, which means they internally did a .catch (err) => Promise.resolve(Task.Status.Retry) and they want to be run again later.
- API tasks retry until they succeed or receive a NylasAPI.PermanentErrorCode (400,404,500), in which case they revert and finish.
- The AddRemoveTags Task can now take more than one thread! This is super cool because you can undo/redo a bulk action and also because we'll probably have a bulk tag modification API endpoint soon.
Getting undo / redo working revealed that the thread versioning system we built isn't working because the server was incrementing things by more than 1 at a time. Now we count the number of unresolved "optimistic" changes we've made to a given model, and only accept the server's version of it once the number of optimistic changes is back at zero.
Known Issues:
- AddRemoveTagsTasks aren't dependent on each other, so if you (undo/redo x lots) and then come back online, all the tasks try to add / remove all the tags at the same time. To fix this we can either allow the tasks to be merged together into a minimal set or make them block on each other.
- When Offline, you still get errors in the console for GET requests. Need to catch these and display an offline status bar.
- The metadata tasks haven't been updated yet to the new API. Wanted to get it reviewed first!
Test Plan: All the tests still pass!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1694
2015-07-08 01:38:53 +08:00
|
|
|
expect(Actions.queueTask.mostRecentCall.args[0].threadsOrIds).toEqual([test_thread])
|
2015-06-26 01:33:26 +08:00
|
|
|
expect(Actions.queueTask.mostRecentCall.args[0].tagIdsToAdd).toEqual(['starred'])
|
|
|
|
|
expect(Actions.queueTask.mostRecentCall.args[0].tagIdsToRemove).toEqual([])
|
|
|
|
|
|
|
|
|
|
it "unstars a thread if the star button is clicked and thread is starred", ->
|
|
|
|
|
spyOn(FocusedContentStore, "focused").andCallFake ->
|
|
|
|
|
test_thread_starred
|
|
|
|
|
spyOn(Actions, 'queueTask')
|
|
|
|
|
messageToolbarItems = TestUtils.renderIntoDocument(<MessageToolbarItems />)
|
|
|
|
|
|
|
|
|
|
starButton = React.findDOMNode(messageToolbarItems.refs.starButton)
|
|
|
|
|
TestUtils.Simulate.click starButton
|
|
|
|
|
|
feat(offline-mode, undo-redo): Tasks handle network errors better and retry, undo/redo based on tasks
Summary:
This diff does a couple things:
- Undo redo with a new undo/redo store that maintains it's own queue of undo/redo tasks. This queue is separate from the TaskQueue because not all tasks should be considered for undo history! Right now just the AddRemoveTagsTask is undoable.
- NylasAPI.makeRequest now returns a promise which resolves with the result or rejects with an error. For things that still need them, there's still `success` and `error` callbacks. I also added `started:(req) ->` which allows you to get the underlying request.
- Aborting a NylasAPI request now makes it call it's error callback / promise reject.
- You can now run code after perform local has completed using this syntax:
```
task = new AddRemoveTagsTask(focused, ['archive'], ['inbox'])
task.waitForPerformLocal().then ->
Actions.setFocus(collection: 'thread', item: nextFocus)
Actions.setCursorPosition(collection: 'thread', item: nextKeyboard)
Actions.queueTask(task)
```
- In specs, you can now use `advanceClock` to get through a Promise.then/catch/finally. Turns out it was using something low level and not using setTimeout(0).
- The TaskQueue uses promises better and defers a lot of the complexity around queueState for performLocal/performRemote to a task subclass called APITask. APITask implements "perform" and breaks it into "performLocal" and "performRemote".
- All tasks either resolve or reject. They're always removed from the queue, unless they resolve with Task.Status.Retry, which means they internally did a .catch (err) => Promise.resolve(Task.Status.Retry) and they want to be run again later.
- API tasks retry until they succeed or receive a NylasAPI.PermanentErrorCode (400,404,500), in which case they revert and finish.
- The AddRemoveTags Task can now take more than one thread! This is super cool because you can undo/redo a bulk action and also because we'll probably have a bulk tag modification API endpoint soon.
Getting undo / redo working revealed that the thread versioning system we built isn't working because the server was incrementing things by more than 1 at a time. Now we count the number of unresolved "optimistic" changes we've made to a given model, and only accept the server's version of it once the number of optimistic changes is back at zero.
Known Issues:
- AddRemoveTagsTasks aren't dependent on each other, so if you (undo/redo x lots) and then come back online, all the tasks try to add / remove all the tags at the same time. To fix this we can either allow the tasks to be merged together into a minimal set or make them block on each other.
- When Offline, you still get errors in the console for GET requests. Need to catch these and display an offline status bar.
- The metadata tasks haven't been updated yet to the new API. Wanted to get it reviewed first!
Test Plan: All the tests still pass!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1694
2015-07-08 01:38:53 +08:00
|
|
|
expect(Actions.queueTask.mostRecentCall.args[0].threadsOrIds).toEqual([test_thread_starred])
|
2015-06-26 01:33:26 +08:00
|
|
|
expect(Actions.queueTask.mostRecentCall.args[0].tagIdsToAdd).toEqual([])
|
|
|
|
|
expect(Actions.queueTask.mostRecentCall.args[0].tagIdsToRemove).toEqual(['starred'])
|
