Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-22 16:26:08 +08:00
Code Issues Packages Projects Releases Wiki Activity
Mailspring/internal_packages/message-list/spec/autolinker-fixtures/plaintext-out.html

27 lines
933 B
HTML
Raw Normal View History

rm(autolinker): Use our own very simple autolinker Summary: Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540 This is super bad, and also super unnecessary. I think this should do the trick. Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok? Test Plan: Need to write some tests Reviewers: evan, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D2725
2016-03-15 03:30:54 +08:00
<title></title>
fix(autolinker): Add more test cases, improv URL regex
2016-03-16 01:47:14 +08:00
<a href="http://apple.com/" title="http://apple.com/">http://apple.com/</a>
rm(autolinker): Use our own very simple autolinker Summary: Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540 This is super bad, and also super unnecessary. I think this should do the trick. Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok? Test Plan: Need to write some tests Reviewers: evan, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D2725
2016-03-15 03:30:54 +08:00
<div><br></div>
<div><a href="https://dropbox.com/" title="https://dropbox.com/">https://dropbox.com/</a></div>
<div><br></div>
<div><a href="whatever.com" title="whatever.com">whatever.com</a></div>
<div><br></div>
<div><a href="kinda-looks-like-a-link.com" title="kinda-looks-like-a-link.com">kinda-looks-like-a-link.com</a></div>
<div><br></div>
<div><a href="ftp://helloworld.com/asd" title="ftp://helloworld.com/asd">ftp://helloworld.com/asd</a></div>
<div><br></div>
<div><a href="tel:540-250-2334" title="tel:540-250-2334">540-250-2334</a></div>
<div><br></div>
<div><a href="tel:+1-524-123-3333" title="tel:+1-524-123-3333">+1-524-123-3333</a></div>
<div><br></div>
fix(autolinker): Only match top ten tld's when schme not present
2016-03-25 01:14:47 +08:00
<div>550.555.1234</div>
rm(autolinker): Use our own very simple autolinker Summary: Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540 This is super bad, and also super unnecessary. I think this should do the trick. Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok? Test Plan: Need to write some tests Reviewers: evan, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D2725
2016-03-15 03:30:54 +08:00
<div><br></div>
<div><a href="mailto:bengotow@gmail.com" title="mailto:bengotow@gmail.com">bengotow@gmail.com</a></div>
<div><br></div>
Reference in a new issue Copy permalink