Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-11-13 13:19:34 +08:00
Code Issues Projects Releases Packages Wiki Activity
Mailspring/spec/fixtures/two-hundred.txt

201 lines
4.6 KiB
Text
Raw Normal View History

fix(drafts): Various improvements and fixes to drafts, draft state management Summary: This diff contains a few major changes: 1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario: - View thread with draft, edit draft - Move to another thread - Move back to thread with draft - Move to another thread. Notice that one or more messages from thread with draft are still there. There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great. 2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here: - In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI. - Previously, when you added a contact to To/CC/BCC, this happened: <input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state. To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source! This diff includes a few minor fixes as well: 1. Draft.state is gone—use Message.object = draft instead 2. String model attributes should never be null 3. Pre-send checks that can cancel draft send 4. Put the entire curl history and task queue into feedback reports 5. Cache localIds for extra speed 6. Move us up to latest React Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet Reviewers: evan Reviewed By: evan Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
0
1
2
3
4----------------------------------------------------------------------------------------------------
5
6
7
8
9----------------------------------------------------------------------------------------------------
10
11
12
13
14----------------------------------------------------------------------------------------------------
15
16
17
18
19----------------------------------------------------------------------------------------------------
20
21
22
23
24----------------------------------------------------------------------------------------------------
25
26
27
28
29----------------------------------------------------------------------------------------------------
30
31
32
33
34----------------------------------------------------------------------------------------------------
35
36
37
38
39----------------------------------------------------------------------------------------------------
40
41
42
43
44----------------------------------------------------------------------------------------------------
45
46
47
48
49----------------------------------------------------------------------------------------------------
50
51
52
53
54----------------------------------------------------------------------------------------------------
55
56
57
58
59----------------------------------------------------------------------------------------------------
60
61
62
63
64----------------------------------------------------------------------------------------------------
65
66
67
68
69----------------------------------------------------------------------------------------------------
70
71
72
73
74----------------------------------------------------------------------------------------------------
75
76
77
78
79----------------------------------------------------------------------------------------------------
80
81
82
83
84----------------------------------------------------------------------------------------------------
85
86
87
88
89----------------------------------------------------------------------------------------------------
90
91
92
93
94----------------------------------------------------------------------------------------------------
95
96
97
98
99----------------------------------------------------------------------------------------------------
100
101
102
103
104----------------------------------------------------------------------------------------------------
105
106
107
108
109----------------------------------------------------------------------------------------------------
110
111
112
113
114----------------------------------------------------------------------------------------------------
115
116
117
118
119----------------------------------------------------------------------------------------------------
120
121
122
123
124----------------------------------------------------------------------------------------------------
125
126
127
128
129----------------------------------------------------------------------------------------------------
130
131
132
133
134----------------------------------------------------------------------------------------------------
135
136
137
138
139----------------------------------------------------------------------------------------------------
140
141
142
143
144----------------------------------------------------------------------------------------------------
145
146
147
148
149----------------------------------------------------------------------------------------------------
150
151
152
153
154----------------------------------------------------------------------------------------------------
155
156
157
158
159----------------------------------------------------------------------------------------------------
160
161
162
163
164----------------------------------------------------------------------------------------------------
165
166
167
168
169----------------------------------------------------------------------------------------------------
170
171
172
173
174----------------------------------------------------------------------------------------------------
175
176
177
178
179----------------------------------------------------------------------------------------------------
180
181
182
183
184----------------------------------------------------------------------------------------------------
185
186
187
188
189----------------------------------------------------------------------------------------------------
190
191
192
193
194----------------------------------------------------------------------------------------------------
195
196
197
198
199----------------------------------------------------------------------------------------------------
Reference in a new issue Copy permalink