2015-07-18 07:36:28 +08:00
|
|
|
fs = require 'fs'
|
2016-01-12 03:39:45 +08:00
|
|
|
path = require 'path'
|
2015-11-24 14:09:17 +08:00
|
|
|
{shell} = require 'electron'
|
fix(spec): add support for async specs and disable misbehaving ones
More spec fixes
replace process.nextTick with setTimeout(fn, 0) for specs
Also added an unspy in the afterEach
Temporarily disable specs
fix(spec): start fixing specs
Summary:
This is the WIP fix to our spec runner.
Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.
Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!
The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.
Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.
I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).
Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update
Test Plan: npm test
Reviewers: juan, halla, jackie
Differential Revision: https://phab.nylas.com/D3501
Disable other specs
Disable more broken specs
All specs turned off till passing state
Use async-safe versions of spec functions
Add async test spec
Remove unused package code
Remove canary spec
2016-12-13 04:12:20 +08:00
|
|
|
NylasAPI = require('../../src/flux/nylas-api').default
|
2016-12-02 05:50:31 +08:00
|
|
|
NylasAPIRequest = require('../../src/flux/nylas-api-request').default
|
2016-10-27 07:01:23 +08:00
|
|
|
File = require('../../src/flux/models/file').default
|
2016-05-05 08:00:53 +08:00
|
|
|
Message = require('../../src/flux/models/message').default
|
2016-11-02 09:12:24 +08:00
|
|
|
FileDownloadStore = require('../../src/flux/stores/file-download-store').default
|
|
|
|
{Download} = require('../../src/flux/stores/file-download-store')
|
fix(spec): add support for async specs and disable misbehaving ones
More spec fixes
replace process.nextTick with setTimeout(fn, 0) for specs
Also added an unspy in the afterEach
Temporarily disable specs
fix(spec): start fixing specs
Summary:
This is the WIP fix to our spec runner.
Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.
Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!
The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.
Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.
I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).
Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update
Test Plan: npm test
Reviewers: juan, halla, jackie
Differential Revision: https://phab.nylas.com/D3501
Disable other specs
Disable more broken specs
All specs turned off till passing state
Use async-safe versions of spec functions
Add async test spec
Remove unused package code
Remove canary spec
2016-12-13 04:12:20 +08:00
|
|
|
AccountStore = require('../../src/flux/stores/account-store').default
|
2016-01-12 05:40:38 +08:00
|
|
|
|
2015-08-11 04:36:11 +08:00
|
|
|
|
fix(spec): add support for async specs and disable misbehaving ones
More spec fixes
replace process.nextTick with setTimeout(fn, 0) for specs
Also added an unspy in the afterEach
Temporarily disable specs
fix(spec): start fixing specs
Summary:
This is the WIP fix to our spec runner.
Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.
Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!
The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.
Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.
I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).
Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update
Test Plan: npm test
Reviewers: juan, halla, jackie
Differential Revision: https://phab.nylas.com/D3501
Disable other specs
Disable more broken specs
All specs turned off till passing state
Use async-safe versions of spec functions
Add async test spec
Remove unused package code
Remove canary spec
2016-12-13 04:12:20 +08:00
|
|
|
xdescribe 'FileDownloadStoreSpecs', ->
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
describe "Download", ->
|
2016-01-12 05:44:54 +08:00
|
|
|
beforeEach ->
|
2016-11-03 08:20:33 +08:00
|
|
|
spyOn(fs, 'createWriteStream')
|
2016-11-30 08:32:23 +08:00
|
|
|
spyOn(NylasAPIRequest.prototype, 'run')
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
describe "constructor", ->
|
|
|
|
it "should require a non-empty filename", ->
|
|
|
|
expect(-> new Download(fileId: '123', targetPath: 'test.png')).toThrow()
|
|
|
|
expect(-> new Download(filename: null, fileId: '123', targetPath: 'test.png')).toThrow()
|
|
|
|
expect(-> new Download(filename: '', fileId: '123', targetPath: 'test.png')).toThrow()
|
|
|
|
|
|
|
|
it "should require a non-empty fileId", ->
|
|
|
|
expect(-> new Download(filename: 'test.png', fileId: null, targetPath: 'test.png')).toThrow()
|
|
|
|
expect(-> new Download(filename: 'test.png', fileId: '', targetPath: 'test.png')).toThrow()
|
|
|
|
|
|
|
|
it "should require a download path", ->
|
|
|
|
expect(-> new Download(filename: 'test.png', fileId: '123')).toThrow()
|
|
|
|
expect(-> new Download(filename: 'test.png', fileId: '123', targetPath: '')).toThrow()
|
|
|
|
|
|
|
|
describe "run", ->
|
2015-07-18 07:36:28 +08:00
|
|
|
beforeEach ->
|
2016-11-03 08:20:33 +08:00
|
|
|
account = AccountStore.accounts()[0]
|
|
|
|
@download = new Download(fileId: '123', targetPath: 'test.png', filename: 'test.png', accountId: account.id)
|
|
|
|
@download.run()
|
2016-11-30 08:32:23 +08:00
|
|
|
expect(NylasAPIRequest.prototype.run).toHaveBeenCalled()
|
2016-11-03 08:20:33 +08:00
|
|
|
|
2017-03-23 03:10:20 +08:00
|
|
|
it "should create a request with a null encoding to prevent the request library" +
|
|
|
|
" from attempting to parse the (potentially very large) response", ->
|
fix(spec): add support for async specs and disable misbehaving ones
More spec fixes
replace process.nextTick with setTimeout(fn, 0) for specs
Also added an unspy in the afterEach
Temporarily disable specs
fix(spec): start fixing specs
Summary:
This is the WIP fix to our spec runner.
Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.
Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!
The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.
Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.
I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).
Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update
Test Plan: npm test
Reviewers: juan, halla, jackie
Differential Revision: https://phab.nylas.com/D3501
Disable other specs
Disable more broken specs
All specs turned off till passing state
Use async-safe versions of spec functions
Add async test spec
Remove unused package code
Remove canary spec
2016-12-13 04:12:20 +08:00
|
|
|
expect(NylasAPIRequest.prototype.run.mostRecentCall.object.options.json).toBe(false)
|
|
|
|
expect(NylasAPIRequest.prototype.run.mostRecentCall.object.options.encoding).toBe(null)
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
it "should create a request for /files/123/download", ->
|
fix(spec): add support for async specs and disable misbehaving ones
More spec fixes
replace process.nextTick with setTimeout(fn, 0) for specs
Also added an unspy in the afterEach
Temporarily disable specs
fix(spec): start fixing specs
Summary:
This is the WIP fix to our spec runner.
Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.
Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!
The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.
Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.
I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).
Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update
Test Plan: npm test
Reviewers: juan, halla, jackie
Differential Revision: https://phab.nylas.com/D3501
Disable other specs
Disable more broken specs
All specs turned off till passing state
Use async-safe versions of spec functions
Add async test spec
Remove unused package code
Remove canary spec
2016-12-13 04:12:20 +08:00
|
|
|
expect(NylasAPIRequest.prototype.run.mostRecentCall.object.options.path).toBe("/files/123/download")
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
describe "FileDownloadStore", ->
|
|
|
|
beforeEach ->
|
|
|
|
account = AccountStore.accounts()[0]
|
|
|
|
|
|
|
|
spyOn(shell, 'showItemInFolder')
|
|
|
|
spyOn(shell, 'openItem')
|
|
|
|
@testfile = new File({
|
|
|
|
accountId: account.id,
|
|
|
|
filename: '123.png',
|
|
|
|
contentType: 'image/png',
|
|
|
|
id: "id",
|
|
|
|
size: 100
|
|
|
|
})
|
|
|
|
@testdownload = new Download({
|
|
|
|
accountId: account.id,
|
|
|
|
state : 'unknown',
|
|
|
|
fileId : 'id',
|
|
|
|
percent : 0,
|
|
|
|
filename : '123.png',
|
|
|
|
filesize : 100,
|
2017-01-14 10:54:37 +08:00
|
|
|
targetPath : '/Users/testuser/.nylas-mail/downloads/id/123.png'
|
2016-11-03 08:20:33 +08:00
|
|
|
})
|
|
|
|
|
|
|
|
FileDownloadStore._downloads = {}
|
2017-01-14 10:54:37 +08:00
|
|
|
FileDownloadStore._downloadDirectory = "/Users/testuser/.nylas-mail/downloads"
|
2016-11-03 08:20:33 +08:00
|
|
|
spyOn(FileDownloadStore, '_generatePreview').andReturn(Promise.resolve())
|
|
|
|
|
|
|
|
describe "pathForFile", ->
|
|
|
|
it "should return path within the download directory with the file id and displayName", ->
|
|
|
|
f = new File(filename: '123.png', contentType: 'image/png', id: 'id')
|
|
|
|
spyOn(f, 'displayName').andCallThrough()
|
2017-01-14 10:54:37 +08:00
|
|
|
expect(FileDownloadStore.pathForFile(f)).toBe("/Users/testuser/.nylas-mail/downloads/id/123.png")
|
2016-11-03 08:20:33 +08:00
|
|
|
expect(f.displayName).toHaveBeenCalled()
|
|
|
|
|
|
|
|
it "should return unique paths for identical filenames with different IDs", ->
|
|
|
|
f1 = new File(filename: '123.png', contentType: 'image/png', id: 'id1')
|
|
|
|
f2 = new File(filename: '123.png', contentType: 'image/png', id: 'id2')
|
2017-01-14 10:54:37 +08:00
|
|
|
expect(FileDownloadStore.pathForFile(f1)).toBe("/Users/testuser/.nylas-mail/downloads/id1/123.png")
|
|
|
|
expect(FileDownloadStore.pathForFile(f2)).toBe("/Users/testuser/.nylas-mail/downloads/id2/123.png")
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
it "should escape the displayName if it contains path separator characters", ->
|
|
|
|
f1 = new File(filename: "static#{path.sep}b#{path.sep}a.jpg", contentType: 'image/png', id: 'id1')
|
2017-01-14 10:54:37 +08:00
|
|
|
expect(FileDownloadStore.pathForFile(f1)).toBe("/Users/testuser/.nylas-mail/downloads/id1/static-b-a.jpg")
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
f1 = new File(filename: "my:file ? Windows /hates/ me :->.jpg", contentType: 'image/png', id: 'id1')
|
2017-01-14 10:54:37 +08:00
|
|
|
expect(FileDownloadStore.pathForFile(f1)).toBe("/Users/testuser/.nylas-mail/downloads/id1/my-file - Windows -hates- me ---.jpg")
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
describe "_checkForDownloadedFile", ->
|
|
|
|
it "should return true if the file exists at the path and is the right size", ->
|
|
|
|
f = new File(filename: '123.png', contentType: 'image/png', id: "id", size: 100)
|
|
|
|
spyOn(fs, 'statAsync').andCallFake (path) ->
|
|
|
|
Promise.resolve({size: 100})
|
|
|
|
waitsForPromise ->
|
|
|
|
FileDownloadStore._checkForDownloadedFile(f).then (downloaded) ->
|
|
|
|
expect(downloaded).toBe(true)
|
|
|
|
|
|
|
|
it "should return false if the file does not exist", ->
|
|
|
|
f = new File(filename: '123.png', contentType: 'image/png', id: "id", size: 100)
|
|
|
|
spyOn(fs, 'statAsync').andCallFake (path) ->
|
|
|
|
Promise.reject(new Error("File does not exist"))
|
|
|
|
waitsForPromise ->
|
|
|
|
FileDownloadStore._checkForDownloadedFile(f).then (downloaded) ->
|
|
|
|
expect(downloaded).toBe(false)
|
|
|
|
|
|
|
|
it "should return false if the file is too small", ->
|
|
|
|
f = new File(filename: '123.png', contentType: 'image/png', id: "id", size: 100)
|
|
|
|
spyOn(fs, 'statAsync').andCallFake (path) ->
|
|
|
|
Promise.resolve({size: 50})
|
|
|
|
waitsForPromise ->
|
|
|
|
FileDownloadStore._checkForDownloadedFile(f).then (downloaded) ->
|
|
|
|
expect(downloaded).toBe(false)
|
|
|
|
|
|
|
|
describe "_runDownload", ->
|
2015-07-18 07:36:28 +08:00
|
|
|
beforeEach ->
|
2016-11-03 08:20:33 +08:00
|
|
|
spyOn(Download.prototype, 'run').andCallFake -> Promise.resolve(@)
|
|
|
|
spyOn(FileDownloadStore, '_prepareFolder').andCallFake -> Promise.resolve(true)
|
2015-07-18 07:36:28 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
it "should make sure that the download file path exists", ->
|
fix(spec): add support for async specs and disable misbehaving ones
More spec fixes
replace process.nextTick with setTimeout(fn, 0) for specs
Also added an unspy in the afterEach
Temporarily disable specs
fix(spec): start fixing specs
Summary:
This is the WIP fix to our spec runner.
Several tests have been completely commented out that will require
substantially more work to fix. These have been added to our sprint
backlog.
Other tests have been fixed to update to new APIs or to deal with genuine
bugs that were introduced without our knowing!
The most common non-trivial change relates to observing the `NylasAPI` and
`NylasAPIRequest`. We used to observe the arguments to `makeRequest`.
Unfortunately `NylasAPIRequest.run` is argumentless. Instead you can do:
`NylasAPIRequest.prototype.run.mostRecentCall.object.options` to get the
`options` passed into the object. the `.object` property grabs the context
of the spy when it was last called.
Fixing these tests uncovered several concerning issues with our test
runner. I spent a while tracking down why our participant-text-field-spec
was failling every so often. I chose that spec because it was the first
spec to likely fail, thereby requiring looking at the least number of
preceding files. I tried binary searching, turning on and off, several
files beforehand only to realize that the failure rate was not determined
by a particular preceding test, but rather the existing and quantity of
preceding tests, AND the number of console.log statements I had. There is
some processor-dependent race condition going on that needs further
investigation.
I also discovered an issue with the file-download-spec. We were getting
errors about it accessing a file, which was very suspicious given the code
stubs out all fs access. This was caused due to a spec that called an
async function outside ot a `waitsForPromise` block or a `waitsFor` block.
The test completed, the spies were cleaned up, but the downstream async
chain was still running. By the time the async chain finished the runner
was already working on the next spec and the spies had been restored
(causing the real fs access to run).
Juan had an idea to kill the specs once one fails to prevent cascading
failures. I'll implement this in the next diff update
Test Plan: npm test
Reviewers: juan, halla, jackie
Differential Revision: https://phab.nylas.com/D3501
Disable other specs
Disable more broken specs
All specs turned off till passing state
Use async-safe versions of spec functions
Add async test spec
Remove unused package code
Remove canary spec
2016-12-13 04:12:20 +08:00
|
|
|
waitsForPromise =>
|
|
|
|
FileDownloadStore._runDownload(@testfile).then ->
|
|
|
|
expect(FileDownloadStore._prepareFolder).toHaveBeenCalled()
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
it "should return the promise returned by download.run if the download already exists", ->
|
|
|
|
existing =
|
|
|
|
fileId: @testfile.id
|
|
|
|
run: jasmine.createSpy('existing.run').andCallFake ->
|
|
|
|
Promise.resolve(existing)
|
|
|
|
FileDownloadStore._downloads[@testfile.id] = existing
|
|
|
|
|
|
|
|
promise = FileDownloadStore._runDownload(@testfile)
|
|
|
|
expect(promise instanceof Promise).toBe(true)
|
|
|
|
waitsForPromise ->
|
|
|
|
promise.then ->
|
|
|
|
expect(existing.run).toHaveBeenCalled()
|
|
|
|
|
|
|
|
describe "when the downloaded file exists", ->
|
|
|
|
beforeEach ->
|
|
|
|
spyOn(FileDownloadStore, '_checkForDownloadedFile').andCallFake ->
|
|
|
|
Promise.resolve(true)
|
|
|
|
|
|
|
|
it "should resolve with a Download without calling download.run", ->
|
|
|
|
waitsForPromise =>
|
|
|
|
FileDownloadStore._runDownload(@testfile).then (download) ->
|
|
|
|
expect(Download.prototype.run).not.toHaveBeenCalled()
|
|
|
|
expect(download instanceof Download).toBe(true)
|
|
|
|
expect(download.data()).toEqual({
|
|
|
|
state : 'finished',
|
|
|
|
fileId : 'id',
|
|
|
|
percent : 0,
|
|
|
|
filename : '123.png',
|
|
|
|
filesize : 100,
|
2017-01-14 10:54:37 +08:00
|
|
|
targetPath : '/Users/testuser/.nylas-mail/downloads/id/123.png'
|
2016-11-03 08:20:33 +08:00
|
|
|
})
|
|
|
|
|
|
|
|
describe "when the downloaded file does not exist", ->
|
|
|
|
beforeEach ->
|
|
|
|
spyOn(FileDownloadStore, '_checkForDownloadedFile').andCallFake ->
|
|
|
|
Promise.resolve(false)
|
|
|
|
|
|
|
|
it "should register the download with the right attributes", ->
|
2015-10-06 08:57:24 +08:00
|
|
|
FileDownloadStore._runDownload(@testfile)
|
2016-11-03 08:20:33 +08:00
|
|
|
advanceClock(0)
|
2017-03-23 03:10:20 +08:00
|
|
|
expect(FileDownloadStore.getDownloadDataForFile(@testfile.id)).toEqual({
|
2016-11-03 08:20:33 +08:00
|
|
|
state : 'unstarted',fileId : 'id',
|
|
|
|
percent : 0,
|
|
|
|
filename : '123.png',
|
|
|
|
filesize : 100,
|
2017-01-14 10:54:37 +08:00
|
|
|
targetPath : '/Users/testuser/.nylas-mail/downloads/id/123.png'
|
2016-11-03 08:20:33 +08:00
|
|
|
})
|
|
|
|
|
|
|
|
it "should call download.run", ->
|
|
|
|
waitsForPromise =>
|
|
|
|
FileDownloadStore._runDownload(@testfile)
|
|
|
|
runs ->
|
|
|
|
expect(Download.prototype.run).toHaveBeenCalled()
|
|
|
|
|
|
|
|
it "should resolve with a Download", ->
|
|
|
|
waitsForPromise =>
|
|
|
|
FileDownloadStore._runDownload(@testfile).then (download) ->
|
|
|
|
expect(download instanceof Download).toBe(true)
|
|
|
|
expect(download.data()).toEqual({
|
|
|
|
state : 'unstarted',
|
|
|
|
fileId : 'id',
|
|
|
|
percent : 0,
|
|
|
|
filename : '123.png',
|
|
|
|
filesize : 100,
|
2017-01-14 10:54:37 +08:00
|
|
|
targetPath : '/Users/testuser/.nylas-mail/downloads/id/123.png'
|
2016-11-03 08:20:33 +08:00
|
|
|
})
|
|
|
|
|
|
|
|
describe "_fetch", ->
|
|
|
|
it "should call through to startDownload", ->
|
|
|
|
spyOn(FileDownloadStore, '_runDownload').andCallFake ->
|
|
|
|
Promise.resolve(@testdownload)
|
|
|
|
FileDownloadStore._fetch(@testfile)
|
|
|
|
expect(FileDownloadStore._runDownload).toHaveBeenCalled()
|
|
|
|
|
|
|
|
it "should fail silently since it's called passively", ->
|
|
|
|
spyOn(FileDownloadStore, '_presentError')
|
|
|
|
spyOn(FileDownloadStore, '_runDownload').andCallFake =>
|
|
|
|
Promise.reject(@testdownload)
|
|
|
|
FileDownloadStore._fetch(@testfile)
|
|
|
|
expect(FileDownloadStore._presentError).not.toHaveBeenCalled()
|
|
|
|
|
|
|
|
describe "_fetchAndOpen", ->
|
|
|
|
it "should open the file once it's been downloaded", ->
|
2017-01-14 10:54:37 +08:00
|
|
|
@savePath = "/Users/imaginary/.nylas-mail/Downloads/a.png"
|
2016-11-03 08:20:33 +08:00
|
|
|
download = {targetPath: @savePath}
|
|
|
|
downloadResolve = null
|
2016-03-04 10:00:37 +08:00
|
|
|
|
|
|
|
spyOn(FileDownloadStore, '_runDownload').andCallFake =>
|
2016-11-03 08:20:33 +08:00
|
|
|
new Promise (resolve, reject) ->
|
|
|
|
downloadResolve = resolve
|
2016-03-04 10:00:37 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
FileDownloadStore._fetchAndOpen(@testfile)
|
|
|
|
expect(shell.openItem).not.toHaveBeenCalled()
|
|
|
|
downloadResolve(download)
|
|
|
|
advanceClock(100)
|
|
|
|
expect(shell.openItem).toHaveBeenCalledWith(@savePath)
|
2016-07-27 06:01:52 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
it "should open an error if the download fails", ->
|
|
|
|
spyOn(FileDownloadStore, '_presentError')
|
|
|
|
spyOn(FileDownloadStore, '_runDownload').andCallFake =>
|
|
|
|
Promise.reject(@testdownload)
|
|
|
|
FileDownloadStore._fetchAndOpen(@testfile)
|
2016-07-27 06:01:52 +08:00
|
|
|
advanceClock(1)
|
2016-11-03 08:20:33 +08:00
|
|
|
expect(FileDownloadStore._presentError).toHaveBeenCalled()
|
2016-03-04 10:00:37 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
describe "_fetchAndSave", ->
|
|
|
|
beforeEach ->
|
2017-01-14 10:54:37 +08:00
|
|
|
@userSelectedPath = "/Users/imaginary/.nylas-mail/Downloads/b.png"
|
2016-11-03 08:20:33 +08:00
|
|
|
spyOn(NylasEnv, 'showSaveDialog').andCallFake (options, callback) => callback(@userSelectedPath)
|
|
|
|
|
|
|
|
it "should open a save dialog and prompt the user to choose a download path", ->
|
|
|
|
spyOn(FileDownloadStore, '_runDownload').andCallFake =>
|
|
|
|
new Promise (resolve, reject) -> # never resolve
|
2016-07-27 06:01:52 +08:00
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
2016-11-03 08:20:33 +08:00
|
|
|
expect(NylasEnv.showSaveDialog).toHaveBeenCalled()
|
|
|
|
expect(FileDownloadStore._runDownload).toHaveBeenCalledWith(@testfile)
|
2016-07-27 06:01:52 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
it "should open an error if the download fails", ->
|
|
|
|
spyOn(FileDownloadStore, '_presentError')
|
|
|
|
spyOn(FileDownloadStore, '_runDownload').andCallFake =>
|
|
|
|
Promise.reject(@testdownload)
|
2016-03-05 02:28:48 +08:00
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
|
|
|
advanceClock(1)
|
2016-11-03 08:20:33 +08:00
|
|
|
expect(FileDownloadStore._presentError).toHaveBeenCalled()
|
|
|
|
|
|
|
|
describe "when the user confirms a path", ->
|
|
|
|
beforeEach ->
|
|
|
|
@download = {targetPath: 'bla'}
|
|
|
|
@onEndEventCallback = null
|
|
|
|
streamStub =
|
|
|
|
pipe: ->
|
|
|
|
on: (eventName, eventCallback) =>
|
|
|
|
@onEndEventCallback = eventCallback
|
|
|
|
|
|
|
|
spyOn(FileDownloadStore, '_runDownload').andCallFake =>
|
|
|
|
Promise.resolve(@download)
|
|
|
|
spyOn(fs, 'createReadStream').andReturn(streamStub)
|
|
|
|
spyOn(fs, 'createWriteStream')
|
|
|
|
|
|
|
|
it "should copy the file to the download path after it's been downloaded and open it after the stream has ended", ->
|
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
|
|
|
advanceClock(1)
|
|
|
|
expect(fs.createReadStream).toHaveBeenCalledWith(@download.targetPath)
|
|
|
|
expect(shell.showItemInFolder).not.toHaveBeenCalled()
|
|
|
|
@onEndEventCallback()
|
|
|
|
advanceClock(1)
|
2016-03-04 10:00:37 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
it "should show file in folder if download path differs from previous download path", ->
|
|
|
|
spyOn(FileDownloadStore, '_saveDownload').andCallFake =>
|
|
|
|
Promise.resolve(@testfile)
|
|
|
|
NylasEnv.savedState.lastDownloadDirectory = null
|
2017-01-14 10:54:37 +08:00
|
|
|
@userSelectedPath = "/Users/imaginary/.nylas-mail/Another Random Folder/file.jpg"
|
2016-03-04 10:00:37 +08:00
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
|
|
|
advanceClock(1)
|
2016-11-03 08:20:33 +08:00
|
|
|
expect(shell.showItemInFolder).toHaveBeenCalledWith(@userSelectedPath)
|
2016-03-04 10:00:37 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
it "should not show the file in the folder if the download path is the previous download path", ->
|
|
|
|
spyOn(FileDownloadStore, '_saveDownload').andCallFake =>
|
|
|
|
Promise.resolve(@testfile)
|
2017-01-14 10:54:37 +08:00
|
|
|
@userSelectedPath = "/Users/imaginary/.nylas-mail/Another Random Folder/123.png"
|
|
|
|
NylasEnv.savedState.lastDownloadDirectory = "/Users/imaginary/.nylas-mail/Another Random Folder"
|
2016-03-04 10:00:37 +08:00
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
|
|
|
advanceClock(1)
|
2016-11-03 08:20:33 +08:00
|
|
|
expect(shell.showItemInFolder).not.toHaveBeenCalled()
|
2016-03-04 10:00:37 +08:00
|
|
|
|
2016-11-03 08:20:33 +08:00
|
|
|
it "should update the NylasEnv.savedState.lastDownloadDirectory if is has changed", ->
|
|
|
|
spyOn(FileDownloadStore, '_saveDownload').andCallFake =>
|
|
|
|
Promise.resolve(@testfile)
|
|
|
|
NylasEnv.savedState.lastDownloadDirectory = null
|
2017-01-14 10:54:37 +08:00
|
|
|
@userSelectedPath = "/Users/imaginary/.nylas-mail/Another Random Folder/file.jpg"
|
2016-11-03 08:20:33 +08:00
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
|
|
|
advanceClock(1)
|
2017-01-14 10:54:37 +08:00
|
|
|
expect(NylasEnv.savedState.lastDownloadDirectory).toEqual('/Users/imaginary/.nylas-mail/Another Random Folder')
|
2016-11-03 08:20:33 +08:00
|
|
|
|
|
|
|
describe "file extensions", ->
|
|
|
|
it "should allow the user to save the file with a different extension", ->
|
2017-01-14 10:54:37 +08:00
|
|
|
@userSelectedPath = "/Users/imaginary/.nylas-mail/Downloads/b-changed.tiff"
|
2016-11-03 08:20:33 +08:00
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
|
|
|
advanceClock(1)
|
|
|
|
expect(fs.createWriteStream).toHaveBeenCalledWith(@userSelectedPath)
|
|
|
|
|
|
|
|
it "should restore the extension if the user removed it entirely, because it's usually an accident", ->
|
2017-01-14 10:54:37 +08:00
|
|
|
@userSelectedPath = "/Users/imaginary/.nylas-mail/Downloads/b-changed"
|
2016-11-03 08:20:33 +08:00
|
|
|
FileDownloadStore._fetchAndSave(@testfile)
|
|
|
|
advanceClock(1)
|
|
|
|
expect(fs.createWriteStream).toHaveBeenCalledWith("#{@userSelectedPath}.png")
|
|
|
|
|
|
|
|
describe "_abortFetchFile", ->
|
|
|
|
beforeEach ->
|
|
|
|
@download =
|
|
|
|
ensureClosed: jasmine.createSpy('abort')
|
|
|
|
fileId: @testfile.id
|
|
|
|
FileDownloadStore._downloads[@testfile.id] = @download
|
|
|
|
|
|
|
|
it "should cancel the download for the provided file", ->
|
|
|
|
spyOn(fs, 'exists').andCallFake (path, callback) -> callback(true)
|
|
|
|
spyOn(fs, 'unlink')
|
|
|
|
FileDownloadStore._abortFetchFile(@testfile)
|
|
|
|
expect(fs.unlink).toHaveBeenCalled()
|
|
|
|
expect(@download.ensureClosed).toHaveBeenCalled()
|
|
|
|
|
|
|
|
it "should not try to delete the file if doesn't exist", ->
|
|
|
|
spyOn(fs, 'exists').andCallFake (path, callback) -> callback(false)
|
|
|
|
spyOn(fs, 'unlink')
|
|
|
|
FileDownloadStore._abortFetchFile(@testfile)
|
|
|
|
expect(fs.unlink).not.toHaveBeenCalled()
|
|
|
|
expect(@download.ensureClosed).toHaveBeenCalled()
|