Mailspring/spec/components/editable-list-spec.jsx

282 lines
10 KiB
React
Raw Normal View History

import React, {addons} from 'react/addons';
import EditableList from '../../src/components/editable-list';
const {findDOMNode} = React;
const {TestUtils: {
renderIntoDocument,
findRenderedDOMComponentWithTag,
findRenderedDOMComponentWithClass,
scryRenderedDOMComponentsWithClass,
Simulate,
}} = addons;
const makeList = (items = [], props = {})=> {
return renderIntoDocument(<EditableList {...props}>{items}</EditableList>);
};
describe('EditableList', ()=> {
describe('_onItemClick', ()=> {
it('calls onItemSelected', ()=> {
const onItemSelected = jasmine.createSpy('onItemSelected');
const list = makeList(['1', '2'], {onItemSelected});
const item = scryRenderedDOMComponentsWithClass(list, 'editable-item')[0];
Simulate.click(item);
expect(onItemSelected).toHaveBeenCalledWith('1', 0);
});
});
describe('_onItemEdit', ()=> {
it('enters editing mode when double click when item is not React Element', ()=> {
const list = makeList(['1', '2']);
spyOn(list, 'setState');
const item = scryRenderedDOMComponentsWithClass(list, 'editable-item')[0];
Simulate.doubleClick(item);
expect(list.setState).toHaveBeenCalledWith({editing: 0});
});
it('enters editing mode when edit icon clicked when item is not React Element', ()=> {
const list = makeList(['1', '2']);
spyOn(list, 'setState');
const editIcon = scryRenderedDOMComponentsWithClass(list, 'edit-icon')[0];
Simulate.click(editIcon);
expect(list.setState).toHaveBeenCalledWith({editing: 0});
});
it('does not enters editing mode when item is React Element', ()=> {
const item = <div key="2"></div>;
const list = makeList(['1', item]);
spyOn(list, 'setState');
list._onItemEdit({}, item, 1);
expect(list.setState).not.toHaveBeenCalled();
});
});
describe('_onListBlur', ()=> {
it('clears selection when requirements met', ()=> {
const list = makeList(['1', '2'], {allowEmptySelection: true});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
list._beganEditing = false;
spyOn(list, 'setState');
Simulate.blur(innerList);
expect(list.setState).toHaveBeenCalledWith({selected: null});
});
it('does not clear selection when entering edit mode', ()=> {
const list = makeList(['1', '2'], {allowEmptySelection: true});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
list._beganEditing = true;
spyOn(list, 'setState');
Simulate.blur(innerList);
expect(list.setState).not.toHaveBeenCalled();
});
it('does not clear selection when prop does not allow it', ()=> {
const list = makeList(['1', '2'], {allowEmptySelection: false});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
list._beganEditing = false;
spyOn(list, 'setState');
Simulate.blur(innerList);
expect(list.setState).not.toHaveBeenCalled();
});
});
describe('_onListKeyDown', ()=> {
it('calls onItemSelected', ()=> {
const onItemSelected = jasmine.createSpy('onItemSelected');
const list = makeList(['1', '2'], {initialState: {selected: 0}, onItemSelected});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
Simulate.keyDown(innerList, {key: 'ArrowDown'});
expect(onItemSelected).toHaveBeenCalledWith('2', 1);
});
it('does not select an item when at the bottom of the list and moves down', ()=> {
const onItemSelected = jasmine.createSpy('onItemSelected');
const list = makeList(['1', '2'], {initialState: {selected: 1}, onItemSelected});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
Simulate.keyDown(innerList, {key: 'ArrowDown'});
expect(onItemSelected).not.toHaveBeenCalled();
});
it('does not select an item when at the top of the list and moves up', ()=> {
const onItemSelected = jasmine.createSpy('onItemSelected');
const list = makeList(['1', '2'], {initialState: {selected: 0}, onItemSelected});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
Simulate.keyDown(innerList, {key: 'ArrowUp'});
expect(onItemSelected).not.toHaveBeenCalled();
});
it('clears selection when esc pressed', ()=> {
const onItemSelected = jasmine.createSpy('onItemSelected');
const list = makeList(['1', '2'], {initialState: {selected: 0}, onItemSelected});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
Simulate.keyDown(innerList, {key: 'Escape'});
expect(onItemSelected).toHaveBeenCalledWith(undefined, null);
});
it('does not clear the selection when esc pressed but prop does not allow it', ()=> {
const onItemSelected = jasmine.createSpy('onItemSelected');
const list = makeList(['1', '2'], {initialState: {selected: 0}, allowEmptySelection: false, onItemSelected});
const innerList = findRenderedDOMComponentWithClass(list, 'items-wrapper');
Simulate.keyDown(innerList, {key: 'Escape'});
expect(onItemSelected).not.toHaveBeenCalled();
});
});
describe('_onCreateInputKeyDown', ()=> {
it('calls onItemCreated', ()=> {
const onItemCreated = jasmine.createSpy('onItemCreated');
const list = makeList(['1', '2'], {initialState: {creatingItem: true}, onItemCreated});
const createItem = findRenderedDOMComponentWithClass(list, 'create-item-input');
const input = findRenderedDOMComponentWithTag(createItem, 'input');
findDOMNode(input).value = 'New Item';
Simulate.keyDown(input, {key: 'Enter'});
expect(onItemCreated).toHaveBeenCalledWith('New Item');
});
});
describe('_onCreateItem', ()=> {
it('should call prop callback when provided', ()=> {
const onCreateItem = jasmine.createSpy('onCreateItem');
const list = makeList(['1', '2'], {onCreateItem});
list._onCreateItem();
expect(onCreateItem).toHaveBeenCalled();
});
it('should set state for creating item when no callback provided', ()=> {
const list = makeList(['1', '2']);
spyOn(list, 'setState');
list._onCreateItem();
expect(list.setState).toHaveBeenCalledWith({creatingItem: true});
});
});
describe('_renderItem', ()=> {
const makeItem = (item, idx, state = {}, handlers = {})=> {
const list = makeList();
return renderIntoDocument(
list._renderItem(item, idx, state, handlers)
);
};
it('binds correct click callbacks', ()=> {
const onClick = jasmine.createSpy('onClick');
const onEdit = jasmine.createSpy('onEdit');
const item = makeItem('item 1', 0, {}, {onClick, onEdit});
Simulate.click(item);
expect(onClick.calls[0].args[1]).toEqual('item 1');
expect(onClick.calls[0].args[2]).toEqual(0);
Simulate.doubleClick(item);
expect(onEdit.calls[0].args[1]).toEqual('item 1');
expect(onEdit.calls[0].args[2]).toEqual(0);
});
it('renders correctly when item is selected', ()=> {
const item = findDOMNode(makeItem('item 1', 0, {selected: 0}));
expect(item.className.indexOf('selected')).not.toEqual(-1);
});
it('renders correctly when item is string', ()=> {
const item = findDOMNode(makeItem('item 1', 0));
expect(item.className.indexOf('selected')).toEqual(-1);
expect(item.className.indexOf('editable-item')).not.toEqual(-1);
expect(item.className.indexOf('component-item')).toEqual(-1);
expect(item.childNodes[0].textContent).toEqual('item 1');
});
it('renders correctly when item is component', ()=> {
const item = findDOMNode(makeItem(<div></div>, 0));
expect(item.className.indexOf('selected')).toEqual(-1);
expect(item.className.indexOf('editable-item')).toEqual(-1);
expect(item.className.indexOf('component-item')).not.toEqual(-1);
expect(item.childNodes[0].tagName).toEqual('DIV');
});
it('renders correctly when item is in editing state', ()=> {
const onInputBlur = jasmine.createSpy('onInputBlur');
const onInputFocus = jasmine.createSpy('onInputFocus');
const onInputKeyDown = jasmine.createSpy('onInputKeyDown');
const item = makeItem('item 1', 0, {editing: 0}, {onInputBlur, onInputFocus, onInputKeyDown});
const input = findRenderedDOMComponentWithTag(item, 'input');
Simulate.focus(input);
Simulate.keyDown(input);
Simulate.blur(input);
expect(onInputFocus).toHaveBeenCalled();
expect(onInputBlur).toHaveBeenCalled();
expect(onInputKeyDown.calls[0].args[1]).toEqual('item 1');
expect(onInputKeyDown.calls[0].args[2]).toEqual(0);
expect(findDOMNode(input).tagName).toEqual('INPUT');
});
});
describe('render', ()=> {
it('renders list of items', ()=> {
const items = ['1', '2', '3'];
const list = makeList(items);
const innerList = findDOMNode(
feat(account-prefs): Adds new page for Account in preferences Summary: Adds the new Account preferences page. This consists of two major React components, PreferencesAccountList and PreferencesAccountDetails, both of which use EditableList. I added a bunch of fixes and updated the API for EditableList, plus a bit of refactoring for PreferencesAccount component, and a bunch of CSS so its a big diff. The detailed changelog: Updates to EditableList: - Fix bug updating selection state when arrows pressed to move selection - Add new props: - allowEmptySelection to allow the list to have no selection - createInputProps to pass aditional props to the createInput - Add scroll region for list items - Update styles and refactor render methods Other Updates: - Updates Account model to hold aliases and a label - Adds getter for label to default to email - Update accountswitcher to display label, update styles and spec - Refactor PreferencesAccounts component: - Splits it into smaller components, - Removes unused code - Splits preferences styelsheets into smaller separate stylesheet for account page. Adds some updates and fixes (scroll-region padding) - Update AccountStore to be able to perform updates on an account. - Adds new Action to update account, and an action to remove account to be consistent with Action usage - Adds components for Account list and Aliases list using EditableList Test Plan: - All specs pass, but need to write new tests! Reviewers: bengotow, evan Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2332
2015-12-10 04:35:40 +08:00
findRenderedDOMComponentWithClass(list, 'scroll-region-content-inner')
);
expect(()=> {
findRenderedDOMComponentWithClass(list, 'create-item-input');
}).toThrow();
expect(innerList.childNodes.length).toEqual(3);
items.forEach((item, idx)=> expect(innerList.childNodes[idx].textContent).toEqual(item));
});
it('renders create input as an item when creating', ()=> {
const items = ['1', '2', '3'];
const list = makeList(items, {initialState: {creatingItem: true}});
const createItem = findRenderedDOMComponentWithClass(list, 'create-item-input');
expect(createItem).toBeDefined();
});
it('renders add button', ()=> {
const list = makeList();
const button = scryRenderedDOMComponentsWithClass(list, 'btn-editable-list')[0];
expect(findDOMNode(button).textContent).toEqual('+');
});
it('renders delete button', ()=> {
const onDeleteItem = jasmine.createSpy('onDeleteItem');
const list = makeList(['1', '2'], {initialState: {selected: 1}, onDeleteItem});
const button = scryRenderedDOMComponentsWithClass(list, 'btn-editable-list')[1];
Simulate.click(button);
expect(findDOMNode(button).textContent).toEqual('—');
expect(onDeleteItem).toHaveBeenCalledWith('2', 1);
});
});
});