fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
@import "ui-variables";
|
|
|
|
|
@import "ui-mixins";
|
|
|
|
|
|
2015-03-07 04:03:32 +08:00
|
|
|
@message-max-width: 800px;
|
2015-06-23 06:49:52 +08:00
|
|
|
@message-spacing: 6px;
|
2015-03-07 04:03:32 +08:00
|
|
|
|
2015-05-14 03:01:41 +08:00
|
|
|
.tag-picker {
|
|
|
|
|
.menu {
|
|
|
|
|
.content-container {
|
|
|
|
|
height:250px;
|
|
|
|
|
overflow-y:scroll;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-19 09:21:04 +08:00
|
|
|
.sheet-toolbar {
|
|
|
|
|
// This class wraps the items that appear above the message list in the
|
|
|
|
|
// toolbar. We want the toolbar items to sit right above the centered
|
|
|
|
|
// content, so we need another 800px-wide container in the toolbar...
|
|
|
|
|
.message-toolbar-items {
|
2015-03-21 05:52:10 +08:00
|
|
|
order: 200;
|
|
|
|
|
flex-grow: 0;
|
|
|
|
|
flex-shrink: 0;
|
2015-03-07 04:03:32 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-19 09:21:04 +08:00
|
|
|
.message-toolbar-arrow.down {
|
2015-07-24 10:42:16 +08:00
|
|
|
order:201;
|
2015-06-06 02:40:44 +08:00
|
|
|
margin-right: 0;
|
feat(unsafe-components): Wrap injected components, catch exceptions, clean up ComponentRegistry
Summary:
This diff gives the ComponentRegistry a cleaner, smaller API. Instead of querying by name, location or role,
it's now just location and role, and you can register components for one or more location and one or more
roles without assigning the entries in the registry separate names.
When you register with the ComponentRegistry, the syntax is also cleaner and uses the component's displayName
instead of requiring you to provide a name. You also provide the actual component when unregistering, ensuring
that you can't unregister someone else's component.
InjectedComponent and InjectedComponentSet now wrap their children in UnsafeComponent, which prevents
render/component lifecycle problems from propogating.
Existing components have been updated:
1. maxWidth / minWidth are now containerStyles.maxWidth/minWidth
2. displayName is now required to use the CR.
3. containerRequired = false can be provided to exempt a component from being wrapped in an UnsafeComponent.
This is useful because it's slightly faster and keeps DOM flat.
This diff also makes the "Show Component Regions" more awesome. It displays column regions, since they now
use the InjectedComponentSet, and also shows for InjectedComponent as well as InjectedComponentSet.
Change ComponentRegistry syntax, lots more work on safely wrapping items. See description.
Fix for inline flexbox scenarios (message actions)
Allow ~/.inbox/packages to be symlinked to a github repo
Test Plan: Run tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1457
2015-05-01 07:10:15 +08:00
|
|
|
padding-top:6px;
|
2015-09-05 03:32:19 +08:00
|
|
|
margin-left: @spacing-standard * 1.5;
|
2015-03-19 09:21:04 +08:00
|
|
|
}
|
|
|
|
|
.message-toolbar-arrow.up {
|
2015-07-24 10:42:16 +08:00
|
|
|
order:202;
|
feat(unsafe-components): Wrap injected components, catch exceptions, clean up ComponentRegistry
Summary:
This diff gives the ComponentRegistry a cleaner, smaller API. Instead of querying by name, location or role,
it's now just location and role, and you can register components for one or more location and one or more
roles without assigning the entries in the registry separate names.
When you register with the ComponentRegistry, the syntax is also cleaner and uses the component's displayName
instead of requiring you to provide a name. You also provide the actual component when unregistering, ensuring
that you can't unregister someone else's component.
InjectedComponent and InjectedComponentSet now wrap their children in UnsafeComponent, which prevents
render/component lifecycle problems from propogating.
Existing components have been updated:
1. maxWidth / minWidth are now containerStyles.maxWidth/minWidth
2. displayName is now required to use the CR.
3. containerRequired = false can be provided to exempt a component from being wrapped in an UnsafeComponent.
This is useful because it's slightly faster and keeps DOM flat.
This diff also makes the "Show Component Regions" more awesome. It displays column regions, since they now
use the InjectedComponentSet, and also shows for InjectedComponent as well as InjectedComponentSet.
Change ComponentRegistry syntax, lots more work on safely wrapping items. See description.
Fix for inline flexbox scenarios (message actions)
Allow ~/.inbox/packages to be symlinked to a github repo
Test Plan: Run tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1457
2015-05-01 07:10:15 +08:00
|
|
|
padding-top:6px;
|
2015-03-19 09:21:04 +08:00
|
|
|
// <1 because of hit region padding on the button
|
|
|
|
|
margin-right: @spacing-standard * 0.75;
|
|
|
|
|
}
|
2015-03-24 22:41:00 +08:00
|
|
|
.message-toolbar-arrow.disabled {
|
|
|
|
|
opacity: 0.3;
|
|
|
|
|
}
|
2015-03-07 04:03:32 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-24 07:33:28 +08:00
|
|
|
.mode-split {
|
2015-06-23 06:49:52 +08:00
|
|
|
.message-nav-title {
|
|
|
|
|
display: none;
|
2015-03-24 07:33:28 +08:00
|
|
|
}
|
|
|
|
|
}
|
2015-06-23 06:49:52 +08:00
|
|
|
|
2015-07-24 02:18:42 +08:00
|
|
|
.hide-sidebar-button {
|
|
|
|
|
font-size: @font-size-small;
|
|
|
|
|
color: @text-color-subtle;
|
|
|
|
|
margin-left: @spacing-standard;
|
|
|
|
|
cursor:default;
|
2015-08-11 02:40:19 +08:00
|
|
|
-webkit-user-select: none;
|
2015-07-24 02:18:42 +08:00
|
|
|
.img-wrap {
|
|
|
|
|
margin-right: @spacing-half;
|
|
|
|
|
position: relative;
|
|
|
|
|
top: -1px;
|
|
|
|
|
}
|
|
|
|
|
img { background: @text-color-subtle; }
|
|
|
|
|
}
|
|
|
|
|
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
#message-list {
|
2015-03-20 08:21:09 +08:00
|
|
|
display: flex;
|
2015-03-28 07:35:55 +08:00
|
|
|
flex-direction: column;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
position: relative;
|
2015-09-09 01:53:07 +08:00
|
|
|
background: @background-secondary;
|
2015-03-04 10:51:56 +08:00
|
|
|
|
|
|
|
|
width: 100%;
|
2015-03-18 03:11:34 +08:00
|
|
|
height: 100%;
|
|
|
|
|
min-height: 100%;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
padding: 0;
|
|
|
|
|
order: 2;
|
2015-03-04 10:51:56 +08:00
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
.message-subject-wrap {
|
|
|
|
|
width: calc(~"100% - 12px");
|
|
|
|
|
max-width: @message-max-width;
|
|
|
|
|
margin: 11px auto 10px auto;
|
2015-07-24 02:18:42 +08:00
|
|
|
padding-left: 20px;
|
feat(offline-mode, undo-redo): Tasks handle network errors better and retry, undo/redo based on tasks
Summary:
This diff does a couple things:
- Undo redo with a new undo/redo store that maintains it's own queue of undo/redo tasks. This queue is separate from the TaskQueue because not all tasks should be considered for undo history! Right now just the AddRemoveTagsTask is undoable.
- NylasAPI.makeRequest now returns a promise which resolves with the result or rejects with an error. For things that still need them, there's still `success` and `error` callbacks. I also added `started:(req) ->` which allows you to get the underlying request.
- Aborting a NylasAPI request now makes it call it's error callback / promise reject.
- You can now run code after perform local has completed using this syntax:
```
task = new AddRemoveTagsTask(focused, ['archive'], ['inbox'])
task.waitForPerformLocal().then ->
Actions.setFocus(collection: 'thread', item: nextFocus)
Actions.setCursorPosition(collection: 'thread', item: nextKeyboard)
Actions.queueTask(task)
```
- In specs, you can now use `advanceClock` to get through a Promise.then/catch/finally. Turns out it was using something low level and not using setTimeout(0).
- The TaskQueue uses promises better and defers a lot of the complexity around queueState for performLocal/performRemote to a task subclass called APITask. APITask implements "perform" and breaks it into "performLocal" and "performRemote".
- All tasks either resolve or reject. They're always removed from the queue, unless they resolve with Task.Status.Retry, which means they internally did a .catch (err) => Promise.resolve(Task.Status.Retry) and they want to be run again later.
- API tasks retry until they succeed or receive a NylasAPI.PermanentErrorCode (400,404,500), in which case they revert and finish.
- The AddRemoveTags Task can now take more than one thread! This is super cool because you can undo/redo a bulk action and also because we'll probably have a bulk tag modification API endpoint soon.
Getting undo / redo working revealed that the thread versioning system we built isn't working because the server was incrementing things by more than 1 at a time. Now we count the number of unresolved "optimistic" changes we've made to a given model, and only accept the server's version of it once the number of optimistic changes is back at zero.
Known Issues:
- AddRemoveTagsTasks aren't dependent on each other, so if you (undo/redo x lots) and then come back online, all the tasks try to add / remove all the tags at the same time. To fix this we can either allow the tasks to be merged together into a minimal set or make them block on each other.
- When Offline, you still get errors in the console for GET requests. Need to catch these and display an offline status bar.
- The metadata tasks haven't been updated yet to the new API. Wanted to get it reviewed first!
Test Plan: All the tests still pass!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1694
2015-07-08 01:38:53 +08:00
|
|
|
-webkit-user-select: text;
|
2015-07-22 02:50:08 +08:00
|
|
|
line-height: @font-size-large * 1.8;
|
2015-06-23 06:49:52 +08:00
|
|
|
}
|
2015-09-09 01:53:07 +08:00
|
|
|
.mail-important-icon {
|
|
|
|
|
margin-right:@spacing-half;
|
|
|
|
|
margin-bottom:2px;
|
|
|
|
|
}
|
2015-06-23 06:49:52 +08:00
|
|
|
.message-subject {
|
|
|
|
|
font-size: @font-size-large;
|
2015-07-17 08:51:18 +08:00
|
|
|
color: @text-color;
|
2015-07-22 02:50:08 +08:00
|
|
|
margin-right: @spacing-standard;
|
2015-06-23 06:49:52 +08:00
|
|
|
}
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
.message-list-headers {
|
2015-03-04 10:51:56 +08:00
|
|
|
margin: 0 auto;
|
|
|
|
|
width: 100%;
|
2015-03-07 04:03:32 +08:00
|
|
|
max-width: @message-max-width;
|
2015-04-22 09:16:08 +08:00
|
|
|
display:block;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
|
|
|
|
|
.participants {
|
|
|
|
|
.contact-chip {
|
|
|
|
|
display:inline-block;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-04-22 09:16:08 +08:00
|
|
|
.message-list-notification-bars {
|
|
|
|
|
display:block;
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-18 03:11:34 +08:00
|
|
|
.messages-wrap {
|
2015-03-28 07:35:55 +08:00
|
|
|
flex: 1;
|
2015-03-18 03:11:34 +08:00
|
|
|
opacity:0;
|
|
|
|
|
transition: opacity 0s;
|
|
|
|
|
}
|
|
|
|
|
.messages-wrap.ready {
|
|
|
|
|
opacity:1;
|
2015-04-01 08:22:47 +08:00
|
|
|
transition: opacity .1s linear;
|
2015-03-18 03:11:34 +08:00
|
|
|
}
|
|
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
.minified-bundle + .message-item-wrap {
|
|
|
|
|
margin-top: 0;
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-04 10:51:56 +08:00
|
|
|
.message-item-wrap {
|
2015-06-23 06:49:52 +08:00
|
|
|
transition: height 0.1s;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
position: relative;
|
|
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
max-width: @message-max-width;
|
|
|
|
|
width: calc(~"100% - 12px");
|
|
|
|
|
|
2015-07-31 09:29:38 +08:00
|
|
|
margin: 0 auto;
|
|
|
|
|
padding: @message-spacing 0;
|
|
|
|
|
&:last-child {
|
2015-08-04 08:05:31 +08:00
|
|
|
padding-bottom: @spacing-double;
|
2015-07-31 09:29:38 +08:00
|
|
|
}
|
|
|
|
|
.message-item-white-wrap {
|
|
|
|
|
background: @background-primary;
|
|
|
|
|
border: 0;
|
|
|
|
|
box-shadow: 0 0 0.5px rgba(0, 0, 0, 0.28), 0 1px 1.5px rgba(0, 0, 0, 0.08);
|
|
|
|
|
border-radius: 4px;
|
|
|
|
|
}
|
2015-03-04 10:51:56 +08:00
|
|
|
|
2015-07-31 09:29:38 +08:00
|
|
|
&.before-reply-area { padding-bottom: 0; }
|
2015-06-23 06:49:52 +08:00
|
|
|
|
2015-03-07 08:08:34 +08:00
|
|
|
&.collapsed {
|
2015-07-31 09:29:38 +08:00
|
|
|
.message-item-white-wrap {
|
|
|
|
|
background-color: darken(@background-primary, 2%);
|
|
|
|
|
padding-top: 19px;
|
|
|
|
|
padding-bottom: 8px;
|
|
|
|
|
margin-bottom: 0;
|
|
|
|
|
}
|
2015-06-23 06:49:52 +08:00
|
|
|
|
|
|
|
|
&+.minified-bundle {
|
|
|
|
|
margin-top: -@message-spacing
|
|
|
|
|
}
|
2015-04-01 07:32:14 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
&.collapsed .message-item-area {
|
|
|
|
|
padding-bottom: 10px;
|
|
|
|
|
display: flex;
|
|
|
|
|
flex-direction: row;
|
|
|
|
|
font-size: @font-size-small;
|
|
|
|
|
|
|
|
|
|
.collapsed-snippet {
|
|
|
|
|
flex: 1;
|
|
|
|
|
white-space: nowrap;
|
|
|
|
|
text-overflow: ellipsis;
|
|
|
|
|
overflow: hidden;
|
2015-03-26 09:22:52 +08:00
|
|
|
cursor: default;
|
|
|
|
|
color: @text-color-very-subtle;
|
|
|
|
|
}
|
2015-04-01 07:32:14 +08:00
|
|
|
|
2015-06-26 01:35:06 +08:00
|
|
|
.collapsed-attachment {
|
|
|
|
|
width:15px;
|
|
|
|
|
height:15px;
|
|
|
|
|
background-size: 15px;
|
|
|
|
|
background-repeat: no-repeat;
|
|
|
|
|
background-position:center;
|
|
|
|
|
padding:12px;
|
|
|
|
|
margin-left: 0.5em;
|
|
|
|
|
background-image:url(../static/images/message-list/icon-attachment-@2x.png);
|
2015-06-30 08:25:00 +08:00
|
|
|
position: relative;
|
|
|
|
|
top: -2px;
|
2015-06-26 01:35:06 +08:00
|
|
|
}
|
|
|
|
|
|
2015-04-01 07:32:14 +08:00
|
|
|
.collapsed-from {
|
|
|
|
|
font-weight: @font-weight-semi-bold;
|
2015-06-23 06:49:52 +08:00
|
|
|
color: @text-color-very-subtle;
|
2015-04-01 07:32:14 +08:00
|
|
|
// min-width: 60px;
|
|
|
|
|
margin-right: 1em;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.collapsed-timestamp {
|
|
|
|
|
margin-left: 0.5em;
|
2015-05-22 09:08:29 +08:00
|
|
|
color: @text-color-very-subtle;
|
2015-03-26 03:41:48 +08:00
|
|
|
}
|
2015-03-07 08:08:34 +08:00
|
|
|
}
|
2015-03-26 03:41:48 +08:00
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.collapsed-participants {
|
|
|
|
|
padding: 10px 10px 10px 0;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
.message-item-divider {
|
2015-03-26 09:22:52 +08:00
|
|
|
border:0; // remove default hr border left, right
|
2015-03-25 04:57:24 +08:00
|
|
|
border-top: 2px solid @border-secondary-bg;
|
|
|
|
|
height: 3px;
|
|
|
|
|
background: @background-secondary;
|
|
|
|
|
border-bottom: 1px solid @border-primary-bg;
|
|
|
|
|
margin: 0;
|
2015-03-26 09:22:52 +08:00
|
|
|
|
|
|
|
|
&.collapsed {
|
2015-05-22 05:50:40 +08:00
|
|
|
height: 0;
|
2015-03-26 09:22:52 +08:00
|
|
|
border-bottom: 0;
|
|
|
|
|
}
|
2015-03-25 04:57:24 +08:00
|
|
|
}
|
|
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
.minified-bundle {
|
|
|
|
|
margin-right: @message-spacing;
|
|
|
|
|
margin-left: @message-spacing;
|
|
|
|
|
position: relative;
|
|
|
|
|
.num-messages {
|
|
|
|
|
position: absolute;
|
|
|
|
|
top: 50%;
|
|
|
|
|
left: 50%;
|
|
|
|
|
margin-left: -80px;
|
|
|
|
|
margin-top: -12px;
|
|
|
|
|
border-radius: 15px;
|
|
|
|
|
border: 1px solid @border-color-divider;
|
|
|
|
|
width: 160px;
|
|
|
|
|
background: @background-primary;
|
|
|
|
|
text-align: center;
|
|
|
|
|
color: @text-color-very-subtle;
|
|
|
|
|
z-index: 2;
|
|
|
|
|
background: @background-primary;
|
|
|
|
|
&:hover {
|
|
|
|
|
cursor: default;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
.msg-lines {
|
|
|
|
|
max-width: @message-max-width;
|
|
|
|
|
margin: 0 auto;
|
|
|
|
|
width: 100%;
|
|
|
|
|
}
|
|
|
|
|
.msg-line {
|
|
|
|
|
border-radius: 4px 4px 0 0;
|
|
|
|
|
position: relative;
|
|
|
|
|
border-top: 1px solid @border-color-divider;
|
|
|
|
|
border-right: 1px solid @border-color-divider;
|
|
|
|
|
border-left: 1px solid @border-color-divider;
|
|
|
|
|
background-color: darken(@background-primary, 2%);
|
2015-06-27 01:38:07 +08:00
|
|
|
box-shadow: 0 1px 1px rgba(0,0,0,0.1);
|
2015-06-23 06:49:52 +08:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-11 01:08:04 +08:00
|
|
|
.message-header {
|
|
|
|
|
position: relative;
|
|
|
|
|
font-size: @font-size-small;
|
2015-03-25 04:57:24 +08:00
|
|
|
padding-bottom: @spacing-standard;
|
2015-06-23 06:49:52 +08:00
|
|
|
padding-top: 19px;
|
2015-03-25 04:57:24 +08:00
|
|
|
|
2015-08-05 10:35:56 +08:00
|
|
|
&.pending {
|
|
|
|
|
.message-actions-wrap {
|
|
|
|
|
width: 0;
|
|
|
|
|
opacity: 0;
|
|
|
|
|
}
|
|
|
|
|
.pending-spinner {
|
|
|
|
|
opacity: 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.pending-spinner {
|
|
|
|
|
transition: opacity 100ms;
|
|
|
|
|
transition-delay: 50ms, 0ms;
|
|
|
|
|
transition-timing-function: ease-in;
|
|
|
|
|
opacity: 0;
|
|
|
|
|
}
|
|
|
|
|
|
2015-07-24 06:18:08 +08:00
|
|
|
.header-row {
|
|
|
|
|
margin-top: 0.5em;
|
|
|
|
|
color: @text-color-very-subtle;
|
|
|
|
|
|
|
|
|
|
.header-label {
|
|
|
|
|
float: left;
|
|
|
|
|
display: block;
|
|
|
|
|
font-weight: @font-weight-normal;
|
|
|
|
|
margin-left: 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.header-name {
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
.message-actions-wrap {
|
2015-08-05 10:35:56 +08:00
|
|
|
transition: opacity 100ms, width 150ms;
|
|
|
|
|
transition-delay: 50ms, 0ms;
|
|
|
|
|
transition-timing-function: ease-in-out;
|
|
|
|
|
width: 98px;
|
|
|
|
|
height: 32px;
|
|
|
|
|
opacity: 1;
|
2015-03-25 04:57:24 +08:00
|
|
|
text-align: right;
|
2015-08-05 10:35:56 +08:00
|
|
|
|
|
|
|
|
.button-dropdown {
|
|
|
|
|
width: 76px;
|
|
|
|
|
}
|
2015-03-25 04:57:24 +08:00
|
|
|
}
|
2015-03-11 01:08:04 +08:00
|
|
|
|
2015-03-28 07:38:34 +08:00
|
|
|
.message-actions-ellipsis {
|
2015-08-05 10:35:56 +08:00
|
|
|
display: block;
|
|
|
|
|
float: left;
|
2015-03-28 07:38:34 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-11 01:08:04 +08:00
|
|
|
.message-actions {
|
2015-03-25 04:57:24 +08:00
|
|
|
display: inline-block;
|
2015-03-28 07:38:34 +08:00
|
|
|
height: 23px;
|
|
|
|
|
border: 1px solid lighten(@border-color-divider, 6%);
|
2015-03-25 04:57:24 +08:00
|
|
|
border-radius: 11px;
|
|
|
|
|
|
2015-03-11 01:08:04 +08:00
|
|
|
z-index: 4;
|
|
|
|
|
margin-top: 0.35em;
|
|
|
|
|
margin-left: 0.5em;
|
2015-03-25 04:57:24 +08:00
|
|
|
text-align: center;
|
2015-03-11 01:08:04 +08:00
|
|
|
|
|
|
|
|
.btn-icon {
|
2015-03-25 04:57:24 +08:00
|
|
|
opacity: 0.75;
|
2015-03-11 01:08:04 +08:00
|
|
|
padding: 0 @spacing-half;
|
2015-03-25 04:57:24 +08:00
|
|
|
height: 20px;
|
|
|
|
|
line-height: 10px;
|
|
|
|
|
border-radius: 0;
|
2015-03-28 07:38:34 +08:00
|
|
|
border-right: 1px solid lighten(@border-color-divider, 6%);
|
2015-03-25 04:57:24 +08:00
|
|
|
&:last-child { border-right: 0; }
|
|
|
|
|
margin: 0;
|
2015-03-11 01:08:04 +08:00
|
|
|
&:active {background: transparent;}
|
2015-02-25 08:19:47 +08:00
|
|
|
}
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
.message-time {
|
2015-06-23 06:49:52 +08:00
|
|
|
padding-top: 5px;
|
2015-03-11 01:08:04 +08:00
|
|
|
z-index: 2; position: relative;
|
|
|
|
|
display: inline-block;
|
2015-06-23 06:49:52 +08:00
|
|
|
min-width: 125px;
|
2015-03-11 01:08:04 +08:00
|
|
|
}
|
|
|
|
|
.msg-actions-tooltip {
|
|
|
|
|
display: inline-block;
|
2015-03-10 02:17:22 +08:00
|
|
|
margin-left: 1em;
|
2015-03-11 01:08:04 +08:00
|
|
|
}
|
|
|
|
|
.message-participants { z-index: 1; position: relative; }
|
2015-03-10 02:17:22 +08:00
|
|
|
|
2015-03-11 01:08:04 +08:00
|
|
|
.message-time, .message-indicator {
|
|
|
|
|
color: @text-color-very-subtle;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-11 01:08:04 +08:00
|
|
|
.message-header-right {
|
2015-06-23 06:49:52 +08:00
|
|
|
z-index: 4;
|
|
|
|
|
position: relative;
|
2015-03-11 01:08:04 +08:00
|
|
|
float: right;
|
2015-03-25 04:57:24 +08:00
|
|
|
text-align: right;
|
2015-06-23 06:49:52 +08:00
|
|
|
display: flex;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-11 01:08:04 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.message-item-area {
|
|
|
|
|
width: 100%;
|
|
|
|
|
max-width: @message-max-width;
|
|
|
|
|
margin: 0 auto;
|
2015-06-23 06:49:52 +08:00
|
|
|
padding: 0 20px @spacing-standard 20px;
|
2015-03-11 01:08:04 +08:00
|
|
|
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
iframe {
|
|
|
|
|
width: 100%;
|
|
|
|
|
border: 0;
|
2015-03-04 10:51:56 +08:00
|
|
|
padding: 0;
|
2015-03-05 01:49:09 +08:00
|
|
|
margin-top: @spacing-sub-double;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
overflow: auto;
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-03-10 02:17:22 +08:00
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
.collapse-region {
|
|
|
|
|
width: calc(~"100% - 30px");
|
|
|
|
|
height: 56px;
|
|
|
|
|
position: absolute;
|
|
|
|
|
top: 0;
|
|
|
|
|
}
|
2015-03-10 02:17:22 +08:00
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
.header-toggle-control {
|
2015-03-11 01:08:04 +08:00
|
|
|
&.inactive { display: none; }
|
|
|
|
|
z-index: 3;
|
2015-03-10 02:17:22 +08:00
|
|
|
position: absolute;
|
2015-03-11 01:08:04 +08:00
|
|
|
top: 0;
|
2015-06-23 06:49:52 +08:00
|
|
|
left: -1 * 13px;
|
2015-06-09 08:48:59 +08:00
|
|
|
img { background: @text-color-very-subtle; }
|
2015-03-10 02:17:22 +08:00
|
|
|
}
|
2015-03-11 01:08:04 +08:00
|
|
|
.message-item-wrap:hover {
|
2015-06-23 06:49:52 +08:00
|
|
|
.header-toggle-control.inactive { display: block; }
|
2015-03-11 01:08:04 +08:00
|
|
|
}
|
2015-03-10 02:17:22 +08:00
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
.footer-reply-area-wrap {
|
2015-08-05 10:35:56 +08:00
|
|
|
overflow: hidden;
|
|
|
|
|
|
2015-06-23 06:49:52 +08:00
|
|
|
width: calc(~"100% - 12px");
|
|
|
|
|
max-width: @message-max-width;
|
|
|
|
|
margin: -3px auto @spacing-double auto;
|
|
|
|
|
|
|
|
|
|
position: relative;
|
|
|
|
|
z-index: 2;
|
|
|
|
|
|
2015-06-27 01:38:07 +08:00
|
|
|
border: 0;
|
2015-06-27 02:17:23 +08:00
|
|
|
box-shadow: 0 0 0.5px rgba(0, 0, 0, 0.28), 0 1px 1.5px rgba(0, 0, 0, 0.08);
|
2015-06-23 06:49:52 +08:00
|
|
|
border-top: 1px dashed @border-color-divider;
|
|
|
|
|
border-radius: 0 0 4px 4px;
|
2015-03-25 04:57:24 +08:00
|
|
|
background: @background-primary;
|
|
|
|
|
|
2015-06-06 02:40:44 +08:00
|
|
|
color: @text-color-very-subtle;
|
|
|
|
|
img.content-mask { background-color:@text-color-very-subtle; }
|
|
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
&:hover {
|
|
|
|
|
cursor: default;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.footer-reply-area {
|
|
|
|
|
width: 100%;
|
|
|
|
|
max-width: @message-max-width;
|
|
|
|
|
margin: 0 auto;
|
|
|
|
|
padding: 20px @spacing-double;
|
|
|
|
|
}
|
|
|
|
|
.reply-text {
|
|
|
|
|
display: inline-block;
|
|
|
|
|
margin-left: 0.5em;
|
|
|
|
|
position: relative;
|
|
|
|
|
top: 2px;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
}
|
|
|
|
|
.attachments-area {
|
2015-03-07 08:08:34 +08:00
|
|
|
padding-top: @spacing-standard;
|
2015-07-16 04:15:05 +08:00
|
|
|
|
|
|
|
|
// attachments are padded on both sides so that things like the remove "X" can
|
|
|
|
|
// overhang them. To make the attachments line up with the body, we need to outdent
|
|
|
|
|
margin-left: -@spacing-standard;
|
|
|
|
|
margin-right: -@spacing-standard;
|
|
|
|
|
|
|
|
|
|
cursor:default;
|
fix(drafts): Various improvements and fixes to drafts, draft state management
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
2015-02-04 08:24:31 +08:00
|
|
|
}
|
2015-03-10 02:17:22 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
///////////////////////////////
|
|
|
|
|
// message-participants.cjsx //
|
|
|
|
|
///////////////////////////////
|
2015-08-05 10:35:56 +08:00
|
|
|
.pending {
|
|
|
|
|
.message-participants {
|
|
|
|
|
padding-left: 34px;
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-03-10 02:17:22 +08:00
|
|
|
.message-participants {
|
|
|
|
|
|
2015-08-05 10:35:56 +08:00
|
|
|
transition: padding-left 150ms;
|
|
|
|
|
transition-timing-function: ease-in-out;
|
|
|
|
|
|
2015-03-26 09:22:52 +08:00
|
|
|
&.collapsed:hover {cursor: default;}
|
2015-03-10 02:17:22 +08:00
|
|
|
|
|
|
|
|
.from-contact {
|
|
|
|
|
font-weight: @headings-font-weight;
|
|
|
|
|
color: @text-color;
|
|
|
|
|
}
|
2015-03-19 09:50:46 +08:00
|
|
|
.from-label, .to-label, .cc-label, .bcc-label, .subject-label {
|
2015-03-10 02:17:22 +08:00
|
|
|
color: @text-color-very-subtle;
|
|
|
|
|
}
|
2015-03-25 04:57:24 +08:00
|
|
|
.to-label, .cc-label, .bcc-label, .subject-label { margin-left: @spacing-standard; }
|
2015-08-20 08:39:16 +08:00
|
|
|
.to-contact, .cc-contact, .bcc-contact, .to-everyone {
|
2015-03-10 02:17:22 +08:00
|
|
|
color: @text-color-very-subtle;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
.expanded-participants {
|
|
|
|
|
position: relative;
|
|
|
|
|
padding-right: 1.2em;
|
|
|
|
|
|
2015-03-11 06:12:13 +08:00
|
|
|
.participant {
|
|
|
|
|
display: inline-block;
|
|
|
|
|
margin-right: 0.5em;
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-11 01:08:04 +08:00
|
|
|
.participant-type {
|
|
|
|
|
margin-top: 0.5em;
|
|
|
|
|
&:first-child {margin-top: 0;}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-19 09:50:46 +08:00
|
|
|
.from-label, .to-label, .cc-label, .bcc-label, .subject-label {
|
2015-03-10 02:17:22 +08:00
|
|
|
float: left;
|
|
|
|
|
display: block;
|
2015-03-25 04:57:24 +08:00
|
|
|
font-weight: @font-weight-normal;
|
2015-03-10 02:17:22 +08:00
|
|
|
margin-left: 0;
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
.from-contact, .subject {
|
|
|
|
|
font-weight: @font-weight-semi-bold;
|
2015-03-10 02:17:22 +08:00
|
|
|
}
|
|
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
// .from-label { margin-right: 1em; }
|
|
|
|
|
.to-label, .cc-label { margin-right: 0.5em; }
|
|
|
|
|
.bcc-label { margin-right: 0; }
|
2015-03-11 01:08:04 +08:00
|
|
|
|
|
|
|
|
.participant-primary {
|
2015-03-25 04:57:24 +08:00
|
|
|
color: @text-color-very-subtle;
|
2015-03-11 01:08:04 +08:00
|
|
|
}
|
|
|
|
|
.participant-secondary {
|
|
|
|
|
color: @text-color-very-subtle;
|
2015-03-10 02:17:22 +08:00
|
|
|
}
|
2015-07-24 06:18:08 +08:00
|
|
|
|
2015-03-25 04:57:24 +08:00
|
|
|
.from-contact {
|
|
|
|
|
.participant-primary {
|
|
|
|
|
color: @text-color;
|
|
|
|
|
}
|
|
|
|
|
.participant-secondary {
|
|
|
|
|
color: @text-color;
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-03-10 02:17:22 +08:00
|
|
|
}
|
|
|
|
|
}
|
2015-03-21 07:31:35 +08:00
|
|
|
|
|
|
|
|
///////////////////////////////
|
2015-09-25 09:58:53 +08:00
|
|
|
// sidebar-contact-card.cjsx //
|
2015-03-21 07:31:35 +08:00
|
|
|
///////////////////////////////
|
2015-09-25 09:58:53 +08:00
|
|
|
.sidebar-section {
|
|
|
|
|
opacity: 0;
|
2015-03-21 07:31:35 +08:00
|
|
|
padding: @spacing-standard;
|
2015-03-26 09:22:52 +08:00
|
|
|
cursor: default;
|
2015-09-25 09:58:53 +08:00
|
|
|
&.visible {
|
|
|
|
|
transition: opacity 0.1s ease-out;
|
|
|
|
|
opacity: 1;
|
2015-03-21 07:31:35 +08:00
|
|
|
}
|
|
|
|
|
|
2015-09-25 09:58:53 +08:00
|
|
|
h2 {
|
2015-03-21 07:31:35 +08:00
|
|
|
font-size: 11px;
|
|
|
|
|
font-weight: @font-weight-semi-bold;
|
|
|
|
|
text-transform: uppercase;
|
|
|
|
|
color: @text-color-very-subtle;
|
|
|
|
|
border-bottom: 1px solid @border-color-divider;
|
|
|
|
|
margin: 2em 0 1em 0;
|
|
|
|
|
}
|
2015-09-25 09:58:53 +08:00
|
|
|
|
|
|
|
|
.sidebar-contact-card {
|
|
|
|
|
}
|
|
|
|
|
.sidebar-contact-list {
|
|
|
|
|
min-height:120px;
|
|
|
|
|
|
|
|
|
|
.contact {
|
|
|
|
|
color: @text-color-subtle;
|
|
|
|
|
font-size: @font-size-smaller;
|
|
|
|
|
&.selected {
|
|
|
|
|
font-weight: @font-weight-semi-bold;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-03-21 07:31:35 +08:00
|
|
|
}
|
|
|
|
|
|
2015-09-25 09:58:53 +08:00
|
|
|
|
2015-03-21 07:31:35 +08:00
|
|
|
.column-MessageListSidebar {
|
|
|
|
|
background-color: @background-off-primary;
|
|
|
|
|
overflow: auto;
|
2015-06-06 02:40:44 +08:00
|
|
|
border-left: 1px solid @border-color-divider;
|
2015-03-21 07:31:35 +08:00
|
|
|
.flexbox-handle-horizontal div {
|
|
|
|
|
border-right: 0;
|
|
|
|
|
width: 1px;
|
|
|
|
|
}
|
|
|
|
|
}
|
