Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-26 00:54:04 +08:00
Code Issues Projects Releases Packages Wiki Activity
Mailspring/internal_packages/composer/spec/expanded-participants-spec.cjsx

58 lines
2.4 KiB
Text
Raw Normal View History

feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
_ = require "underscore"
bump(react): 0.13.2 => 0.14.7 Great breakdown of React changes here: https://github.com/facebook/react/blob/master/CHANGELOG.md#0140-october-7-2015 Due to deprecation warnings, I don't think this will break third-party extensions unless they were doing really bad things.
2016-03-29 16:41:24 +08:00
React = require "react"
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
Fields = require '../lib/fields'
bump(react): 0.13.2 => 0.14.7 Great breakdown of React changes here: https://github.com/facebook/react/blob/master/CHANGELOG.md#0140-october-7-2015 Due to deprecation warnings, I don't think this will break third-party extensions unless they were doing really bad things.
2016-03-29 16:41:24 +08:00
ReactTestUtils = require('react-addons-test-utils')
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
AccountContactField = require '../lib/account-contact-field'
ExpandedParticipants = require '../lib/expanded-participants'
fix(composer): fix popout composer and add spec
2015-09-15 04:12:28 +08:00
{Actions} = require 'nylas-exports'
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
describe "ExpandedParticipants", ->
makeField = (props={}) ->
@onChangeParticipants = jasmine.createSpy("onChangeParticipants")
fix(composer): Change state.focusedField when clicking fields—see details Clicking participant fields to type in them did not cause state.focusedField to change, because no onFocus events were bound to the ParticipantTextFields. Since setState was not called, the focus would appear to change but revert as soon as you touched state. This diff also renames `onChangeEnabledFields` to `onAdjustEnabledFields` making it more clear that unlike the other handlers, it does not take a new value, it takes a set of changes. I also noticed that we /always/ focus fields when showing them, so I removed the separate focus param from it and made it adjust focus at the composer-view level only. I also consolidated everywhere that touches `state.focusedField` so that we can keep the `_lastFocusedParticipantField` value in sync with it more easily.
2015-12-09 09:44:20 +08:00
@onAdjustEnabledFields = jasmine.createSpy("onAdjustEnabledFields")
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
props.onChangeParticipants = @onChangeParticipants
fix(composer): Change state.focusedField when clicking fields—see details Clicking participant fields to type in them did not cause state.focusedField to change, because no onFocus events were bound to the ParticipantTextFields. Since setState was not called, the focus would appear to change but revert as soon as you touched state. This diff also renames `onChangeEnabledFields` to `onAdjustEnabledFields` making it more clear that unlike the other handlers, it does not take a new value, it takes a set of changes. I also noticed that we /always/ focus fields when showing them, so I removed the separate focus param from it and made it adjust focus at the composer-view level only. I also consolidated everywhere that touches `state.focusedField` so that we can keep the `_lastFocusedParticipantField` value in sync with it more easily.
2015-12-09 09:44:20 +08:00
props.onAdjustEnabledFields = @onAdjustEnabledFields
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
@fields = ReactTestUtils.renderIntoDocument(
<ExpandedParticipants {...props} />
)
it "always renders to field", ->
makeField.call(@)
el = ReactTestUtils.findRenderedDOMComponentWithClass(@fields, "to-field")
expect(el).toBeDefined()
it "renders cc when enabled", ->
makeField.call(@, enabledFields: [Fields.Cc])
el = ReactTestUtils.findRenderedDOMComponentWithClass(@fields, "cc-field")
expect(el).toBeDefined()
it "renders bcc when enabled", ->
makeField.call(@, enabledFields: [Fields.Bcc])
el = ReactTestUtils.findRenderedDOMComponentWithClass(@fields, "bcc-field")
expect(el).toBeDefined()
it "renders from when enabled", ->
makeField.call(@, enabledFields: [Fields.From])
el = ReactTestUtils.findRenderedComponentWithType(@fields, AccountContactField)
expect(el).toBeDefined()
it "empties cc and focuses on to field", ->
makeField.call(@, enabledFields: [Fields.Cc, Fields.Bcc, Fields.Subject])
@fields.refs[Fields.Cc].props.onEmptied()
fix(composer): Change state.focusedField when clicking fields—see details Clicking participant fields to type in them did not cause state.focusedField to change, because no onFocus events were bound to the ParticipantTextFields. Since setState was not called, the focus would appear to change but revert as soon as you touched state. This diff also renames `onChangeEnabledFields` to `onAdjustEnabledFields` making it more clear that unlike the other handlers, it does not take a new value, it takes a set of changes. I also noticed that we /always/ focus fields when showing them, so I removed the separate focus param from it and made it adjust focus at the composer-view level only. I also consolidated everywhere that touches `state.focusedField` so that we can keep the `_lastFocusedParticipantField` value in sync with it more easily.
2015-12-09 09:44:20 +08:00
expect(@onAdjustEnabledFields).toHaveBeenCalledWith hide: [Fields.Cc]
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
it "empties bcc and focuses on to field", ->
makeField.call(@, enabledFields: [Fields.Cc, Fields.Bcc, Fields.Subject])
@fields.refs[Fields.Bcc].props.onEmptied()
fix(composer): Change state.focusedField when clicking fields—see details Clicking participant fields to type in them did not cause state.focusedField to change, because no onFocus events were bound to the ParticipantTextFields. Since setState was not called, the focus would appear to change but revert as soon as you touched state. This diff also renames `onChangeEnabledFields` to `onAdjustEnabledFields` making it more clear that unlike the other handlers, it does not take a new value, it takes a set of changes. I also noticed that we /always/ focus fields when showing them, so I removed the separate focus param from it and made it adjust focus at the composer-view level only. I also consolidated everywhere that touches `state.focusedField` so that we can keep the `_lastFocusedParticipantField` value in sync with it more easily.
2015-12-09 09:44:20 +08:00
expect(@onAdjustEnabledFields).toHaveBeenCalledWith hide: [Fields.Bcc]
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
it "empties bcc and focuses on cc field", ->
makeField.call(@, enabledFields: [Fields.Bcc, Fields.Subject])
@fields.refs[Fields.Bcc].props.onEmptied()
fix(composer): Change state.focusedField when clicking fields—see details Clicking participant fields to type in them did not cause state.focusedField to change, because no onFocus events were bound to the ParticipantTextFields. Since setState was not called, the focus would appear to change but revert as soon as you touched state. This diff also renames `onChangeEnabledFields` to `onAdjustEnabledFields` making it more clear that unlike the other handlers, it does not take a new value, it takes a set of changes. I also noticed that we /always/ focus fields when showing them, so I removed the separate focus param from it and made it adjust focus at the composer-view level only. I also consolidated everywhere that touches `state.focusedField` so that we can keep the `_lastFocusedParticipantField` value in sync with it more easily.
2015-12-09 09:44:20 +08:00
expect(@onAdjustEnabledFields).toHaveBeenCalledWith hide: [Fields.Bcc]
feat(composer): participants collapse Summary: Participants now collapse Gmail style in the composer field. New, more declarative system for how we deal with "focusedFields" on the composer. Extracted a `CollapsedParticipants` and `ExpandedParticipants` component. Test Plan: TODO Reviewers: dillon, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2013
2015-09-14 22:37:00 +08:00
it "notifies when participants change", ->
makeField.call(@, enabledFields: [Fields.Cc, Fields.Bcc, Fields.Subject])
@fields.refs[Fields.Cc].props.change()
expect(@onChangeParticipants).toHaveBeenCalled()
Reference in a new issue Copy permalink