mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-09-08 05:34:23 +08:00
fix(message-list): fix type and change variable name
This commit is contained in:
parent
5d95feaf9b
commit
021c427ee5
3 changed files with 10 additions and 11 deletions
|
@ -16,9 +16,9 @@ class MessageItemContainer extends React.Component
|
|||
thread: React.PropTypes.object.isRequired
|
||||
message: React.PropTypes.object.isRequired
|
||||
|
||||
# The messageId (in the case of draft's local ID) is a derived
|
||||
# The localId (in the case of draft's local ID) is a derived
|
||||
# property that only the parent MessageList knows about.
|
||||
messageId: React.PropTypes.string
|
||||
localId: React.PropTypes.string
|
||||
|
||||
collapsed: React.PropTypes.bool
|
||||
isLastMsg: React.PropTypes.bool
|
||||
|
@ -60,7 +60,7 @@ class MessageItemContainer extends React.Component
|
|||
_renderComposer: =>
|
||||
props =
|
||||
mode: "inline"
|
||||
localId: @props.messageId
|
||||
localId: @props.localId
|
||||
threadId: @props.thread.id
|
||||
onRequestScrollTo: @props.onRequestScrollTo
|
||||
|
||||
|
@ -77,9 +77,9 @@ class MessageItemContainer extends React.Component
|
|||
"before-reply-area": @props.isBeforeReplyArea
|
||||
|
||||
_onSendingStateChanged: (draftLocalId) =>
|
||||
@setState(@_getStateFromStores()) if draftLocalId is @props.messageId
|
||||
@setState(@_getStateFromStores()) if draftLocalId is @props.localId
|
||||
|
||||
_getStateFromStores: ->
|
||||
isSending: DraftStore.isSendingDraft(@props.messageId)
|
||||
isSending: DraftStore.isSendingDraft(@props.localId)
|
||||
|
||||
module.exports = MessageItemContainer
|
||||
|
|
|
@ -286,15 +286,14 @@ class MessageList extends React.Component
|
|||
isLastMsg = (messages.length - 1 is idx)
|
||||
isBeforeReplyArea = isLastMsg and @_hasReplyArea()
|
||||
|
||||
messageId = @state.messageLocalIds[message.id]
|
||||
messageId ?= message.id
|
||||
localId = @state.messageLocalIds[message.id]
|
||||
|
||||
elements.push(
|
||||
<MessageItemContainer key={idx}
|
||||
ref={"message-container-#{message.id}"}
|
||||
thread={@state.currentThread}
|
||||
message={message}
|
||||
messageId={messageId}
|
||||
localId={localId}
|
||||
collapsed={collapsed}
|
||||
isLastMsg={isLastMsg}
|
||||
isBeforeReplyArea={isBeforeReplyArea}
|
||||
|
@ -302,7 +301,7 @@ class MessageList extends React.Component
|
|||
)
|
||||
|
||||
if @_hasReplyArea()
|
||||
components.push @_renderReplyArea()
|
||||
elements.push @_renderReplyArea()
|
||||
|
||||
return elements
|
||||
|
||||
|
|
|
@ -19,7 +19,7 @@ MessageItemContainer = proxyquire '../lib/message-item-container',
|
|||
{InjectedComponent} = require 'nylas-component-kit'
|
||||
|
||||
testThread = new Thread(id: "t1")
|
||||
testMessageId = "m1"
|
||||
testLocalId = "local-id"
|
||||
testMessage = new Message(id: "m1", draft: false, unread: true)
|
||||
testDraft = new Message(id: "d1", draft: true, unread: true)
|
||||
|
||||
|
@ -33,7 +33,7 @@ describe 'MessageItemContainer', ->
|
|||
ReactTestUtils.renderIntoDocument(
|
||||
<MessageItemContainer thread={testThread}
|
||||
message={message}
|
||||
messageId={testMessageId} />
|
||||
localId={testLocalId} />
|
||||
)
|
||||
|
||||
it "shows composer if it's a draft", ->
|
||||
|
|
Loading…
Add table
Reference in a new issue