Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-21 07:46:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[client-app] Measure and report composer window open times"

Browse source 
This reverts commit ecf3709669.

# Conflicts:
#	packages/client-app/internal_packages/composer/lib/main.jsx
#	packages/client-app/src/flux/stores/draft-store.es6
This commit is contained in:
Ben Gotow 2017-06-23 16:16:30 -07:00
parent ff4b8b5eb4
commit 08d8326ca4
2 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/client-app/src/flux/stores/draft-store.es6
View file

@ -285,11 +285,10 @@ class DraftStore extends NylasStore {
_onPopoutBlankDraft = () => {
Actions.recordUserEvent("Draft Created", {type: "new"});
const timerId = Utils.generateTempId()
NylasEnv.timer.start(`open-composer-window-${timerId}`);
NylasEnv.timer.start("Popout Draft");
return DraftFactory.createDraft().then((draft) => {
return this._finalizeAndPersistNewMessage(draft).then(({draftClientId}) => {
return this._onPopoutDraftClientId(draftClientId, {timerId, newDraft: true});
return this._onPopoutDraftClientId(draftClientId, {newDraft: true});
});
});
}
@ -337,10 +336,7 @@ class DraftStore extends NylasStore {
if (draftClientId == null) {
throw new Error("DraftStore::onPopoutDraftId - You must provide a draftClientId");
}
const {timerId} = options
if (!timerId) {
NylasEnv.timer.start(`open-composer-window-${draftClientId}`);
}
NylasEnv.timer.start("Popout Draft");
const title = options.newDraft ? "New Message" : "Message";
return this.sessionForClientId(draftClientId).then((session) => {
@ -352,9 +348,8 @@ class DraftStore extends NylasStore {
NylasEnv.newWindow({
title,
hidden: true, // We manually show in ComposerWithWindowProps::onDraftReady
timerId: timerId || draftClientId,
windowKey: `composer-${draftClientId}`,
windowType: 'composer-preload',
windowType: "composer-preload",
windowProps: _.extend(options, {draftClientId, draftJSON}),
});
});

2
packages/client-app/src/nylas-env.es6
View file

@ -934,7 +934,7 @@ export default class NylasEnvConstructor {
// plugins needs to be loaded.
populateHotWindow(event, loadSettings) {
if (/composer/.test(loadSettings.windowType)) {
NylasEnv.timer.split('open-composer-window');
NylasEnv.timer.split("Popout Draft");
}
this.loadSettings = loadSettings;
this.constructor.loadSettings = loadSettings;