From 0a413a1598493346f76dbf9179a3834781e9ac47 Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Wed, 25 Nov 2015 16:30:01 -0800 Subject: [PATCH] fix(sidebar): `selected` is not actually a required prop Fixes #476 --- internal_packages/account-sidebar/lib/account-sidebar-item.cjsx | 2 +- .../account-sidebar/lib/account-sidebar-section.cjsx | 2 +- internal_packages/account-sidebar/lib/account-sidebar.cjsx | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/internal_packages/account-sidebar/lib/account-sidebar-item.cjsx b/internal_packages/account-sidebar/lib/account-sidebar-item.cjsx index aec662b12..16c1e6827 100644 --- a/internal_packages/account-sidebar/lib/account-sidebar-item.cjsx +++ b/internal_packages/account-sidebar/lib/account-sidebar-item.cjsx @@ -10,8 +10,8 @@ class AccountSidebarItem extends React.Component @propTypes: { item: React.PropTypes.object.isRequired - selected: React.PropTypes.object.isRequired onToggleCollapsed: React.PropTypes.func.isRequired + selected: React.PropTypes.object collapsed: React.PropTypes.bool onDestroyItem: React.PropTypes.func } diff --git a/internal_packages/account-sidebar/lib/account-sidebar-section.cjsx b/internal_packages/account-sidebar/lib/account-sidebar-section.cjsx index ddd75a339..2bf936357 100644 --- a/internal_packages/account-sidebar/lib/account-sidebar-section.cjsx +++ b/internal_packages/account-sidebar/lib/account-sidebar-section.cjsx @@ -12,8 +12,8 @@ class AccountSidebarSection extends React.Component @propTypes: { section: React.PropTypes.object.isRequired collapsed: React.PropTypes.object.isRequired - selected: React.PropTypes.object.isRequired onToggleCollapsed: React.PropTypes.func.isRequired + selected: React.PropTypes.object } constructor: (@props) -> diff --git a/internal_packages/account-sidebar/lib/account-sidebar.cjsx b/internal_packages/account-sidebar/lib/account-sidebar.cjsx index 9fb9a9281..7a78bd107 100644 --- a/internal_packages/account-sidebar/lib/account-sidebar.cjsx +++ b/internal_packages/account-sidebar/lib/account-sidebar.cjsx @@ -39,6 +39,7 @@ class AccountSidebar extends React.Component collapsed={@state.collapsed} selected={@state.selected} onToggleCollapsed={@_onToggleCollapsed} /> + _onStoreChange: => @setState @_getStateFromStores()