Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-09-12 15:44:40 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(offline-status): Temporarily remove offline status notification

Browse source 
Summary:
This component was running into a hard loop trying to constantly, unnecessarily,
re-establish the delta connection to our n1cloud servers.

Test Plan: manual

Reviewers: mark, evan, spang

Reviewed By: evan, spang

Differential Revision: https://phab.nylas.com/D3918
This commit is contained in:
Juan Tejada 2017-02-14 16:10:55 -08:00
parent b5ea67198e
commit 1239e5fd78
3 changed files with 0 additions and 177 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

128
internal_packages/notifications/lib/items/offline-notification.jsx
View file

@ -1,128 +0,0 @@
import {NylasSyncStatusStore, React, Actions} from 'nylas-exports';
import {Notification} from 'nylas-component-kit';
const DISCONNECT_DEBOUNCE_INTERVAL = 15000;
const CHECK_STATUS_INTERVAL = 3000
export default class OfflineNotification extends React.Component {
static displayName = 'OfflineNotification';
constructor() {
super();
this._updateInterval = null;
this._setOfflineTimeout = null;
this._setRetryingTimeout = null;
this.state = this.getStateFromStores();
}
componentDidMount() {
this.unlisten = NylasSyncStatusStore.listen(this.onConnectedStatusChanged);
window.addEventListener('browser-window-focus', this.onWindowFocusChanged);
window.addEventListener('browser-window-blur', this.onWindowFocusChanged);
this.ensureCountdownInterval();
}
componentDidUpdate() {
this.ensureCountdownInterval();
}
componentWillUnmount() {
this.unlisten();
window.removeEventListener('browser-window-focus', this.onWindowFocusChanged);
window.removeEventListener('browser-window-blur', this.onWindowFocusChanged);
}
onConnectedStatusChanged = () => {
const nextState = this.getStateFromStores();
if (this.state.connected) {
if (!nextState.connected && !this._setOfflineTimeout) {
this._setOfflineTimeout = setTimeout(this._didBecomeDisconnected, DISCONNECT_DEBOUNCE_INTERVAL);
}
return;
}
if (nextState.connected) {
this._didBecomeConnected();
}
}
onTryAgain = () => {
clearTimeout(this._setRetryingTimeout)
this.setState({retrying: true})
this._setRetryingTimeout = setTimeout(() => this.setState({retrying: false}), 2000)
Actions.retryDeltaConnection();
}
onWindowFocusChanged = () => {
const nextState = this.getStateFromStores();
// If we notice we've reconnected we want to immediately remove the notification.
if (nextState.connected && !this.state.connected) {
this._didBecomeConnected();
return;
}
this.ensureCountdownInterval();
}
getStateFromStores() {
return {connected: NylasSyncStatusStore.connected()};
}
_clearOfflineTimeout = () => {
if (this._setOfflineTimeout) {
clearTimeout(this._setOfflineTimeout);
this._setOfflineTimeout = null;
}
}
_clearUpdateInterval = () => {
if (this._updateInterval) {
clearInterval(this._updateInterval);
this._updateInterval = null;
}
}
_didBecomeConnected = () => {
this._clearOfflineTimeout();
this._clearUpdateInterval();
this.setState({connected: true});
}
_didBecomeDisconnected = () => {
this._clearOfflineTimeout();
// We will call ensureCountdownInterval() in componentDidUpdate when this
// setState is complete.
this.setState({connected: false});
}
ensureCountdownInterval = () => {
this._clearUpdateInterval();
// only attempt to retry if the window is in the foreground to avoid
// the battery hit.
if (!this.state.connected && !document.body.classList.contains('is-blurred')) {
Actions.retryDeltaConnection();
this._updateInterval = setInterval(() => {
Actions.retryDeltaConnection();
}, CHECK_STATUS_INTERVAL);
}
}
render() {
const {connected, retrying} = this.state;
if (connected) {
return <span />;
}
const tryLabel = retrying ? 'Retrying...' : 'Try now';
return (
<Notification
className="offline"
title="Nylas Mail is offline"
priority="5"
icon="volstead-offline.png"
actions={[{label: tryLabel, id: 'try_now', fn: this.onTryAgain}]}
/>
)
}
}

29
internal_packages/notifications/spec/offline-notif-spec.jsx
View file

@ -1,29 +0,0 @@
import {mount} from 'enzyme';
import {React, NylasSyncStatusStore} from 'nylas-exports';
import OfflineNotification from '../lib/items/offline-notification';
describe("OfflineNotif", function offlineNotifTests() {
describe("When N1 is offline", () => {
beforeEach(() => {
spyOn(NylasSyncStatusStore, "connected").andReturn(false);
this.notif = mount(<OfflineNotification />);
})
it("displays a notification", () => {
expect(this.notif.find('.notification').exists()).toEqual(true);
})
it("allows the user to try connecting now", () => {
})
})
describe("When N1 is online", () => {
beforeEach(() => {
spyOn(NylasSyncStatusStore, "connected").andReturn(true);
this.notif = mount(<OfflineNotification />);
})
it("doesn't display a notification", () => {
expect(this.notif.find('.notification').exists()).toEqual(false);
})
})
});

20
src/flux/stores/nylas-sync-status-store.es6
View file

@ -188,26 +188,6 @@ class NylasSyncStatusStore extends NylasStore {
})
})
}
busy() {
return !this.isSyncComplete()
}
/**
* @return true if the N1Cloud delta stream is connected for at least one
* account
*/
connected() {
const statuses = Object.keys(this._statesByAccount)
.map((accountId) => this._statesByAccount[accountId].deltaStatus)
.filter((deltaStatus) => deltaStatus != null)
if (statuses.length === 0) {
return true
}
return statuses.some((status) => status.n1Cloud !== 'closed')
}
}
export default new NylasSyncStatusStore()