From 1722e8bb39a5e6488b9ad73284efb6f27a4e7785 Mon Sep 17 00:00:00 2001 From: Juan Tejada Date: Tue, 21 Feb 2017 14:12:06 -0800 Subject: [PATCH] [*] Catch more invalid login errors when sending Summary: See title Test Plan: manual Reviewers: evan, halla, spang Reviewed By: halla, spang Differential Revision: https://phab.nylas.com/D3994 --- packages/isomorphic-core/src/sendmail-client.es6 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/isomorphic-core/src/sendmail-client.es6 b/packages/isomorphic-core/src/sendmail-client.es6 index 6d317cc4c..941e506ef 100644 --- a/packages/isomorphic-core/src/sendmail-client.es6 +++ b/packages/isomorphic-core/src/sendmail-client.es6 @@ -48,12 +48,12 @@ class SendmailClient { // TODO: figure out how to parse different errors, like in cloud-core // https://github.com/nylas/cloud-core/blob/production/sync-engine/inbox/sendmail/smtp/postel.py#L354 - if (error.message.startsWith("Invalid login: 535-5.7.8 Username and Password not accepted.")) { - throw new APIError('Sending failed - Invalid login', 401, {originalError: error}) + if (/invalid login/i.test(error.message)) { + throw new APIError(`Sending failed - Invalid login`, 401, {originalError: error}) } if (error.message.includes("getaddrinfo ENOTFOUND")) { - throw new APIError('Sending failed - Network Error', 401, {originalError: error}) + throw new APIError(`Sending failed - Network Error`, 401, {originalError: error}) } if (error.message.includes("connect ETIMEDOUT")) {