Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-01-27 10:28:31 +08:00
Code Issues Projects Releases Packages Wiki Activity

[dev, cloud-*] make Docker run plain npm install and conslidate deps

Browse source 
Summary:
It doesn't really make sense to have the root package.json have any
dependencies since it's never "packaged" or built itself. Everything
really should be a dev dependency. This was only separated before because
the Dockerfile unnecessarily added the --production flag.

This will make the docker build take a smidge longer, but I think it's
worth the extra minute to keep the dependencies orderly and sematically
correct

Test Plan: re-run docker build

Reviewers: jerm, spang, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D3978
This commit is contained in:
Evan Morikawa 2017-02-21 14:33:00 -05:00
parent 7fa5e2fb3f
commit 17b7653109
2 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Dockerfile
View file

@ -14,7 +14,7 @@ WORKDIR /home
# bootstrap to install and link cloud-api, cloud-core, and cloud-workers.
# We need the --unsafe-perm param to run the postinstall script since Docker
# will run everything as sudo
RUN npm install --production --unsafe-perm
RUN npm install --unsafe-perm
# This uses babel to compile any es6 to stock js for plain node
RUN node packages/cloud-core/build/build-n1-cloud

22
package.json
View file

@ -2,21 +2,12 @@
"name": "nylas-mail-all",
"version": "0.0.1",
"description": "All components required to run Nylas Mail",
"dependencies": {
"devDependencies": {
"babel-cli": "6.x.x",
"babel-core": "6.x.x",
"babel-eslint": "7.1.0",
"babel-preset-electron": "1.4.15",
"babel-preset-react": "6.x.x",
"pm2": "2.4.0",
"lerna": "2.0.0-beta.37",
"fs-plus": "2.x.x",
"fs-extra": "2.x.x",
"glob": "7.x.x",
"request": "2.x.x",
"underscore": "1.8.x"
},
"devDependencies": {
"chalk": "1.x.x",
"coffeelint-cjsx": "2.x.x",
"electron-installer-dmg": "0.2.x",
@ -27,6 +18,9 @@
"eslint-plugin-jsx-a11y": "2.2.3",
"eslint-plugin-react": "6.7.1",
"eslint_d": "4.2.0",
"fs-extra": "2.x.x",
"fs-plus": "2.x.x",
"glob": "7.x.x",
"grunt": "0.4.x",
"grunt-cli": "0.1.x",
"grunt-coffeelint": "git+https://github.com/atom/grunt-coffeelint.git#cfb99aa99811d52687969532bd5a98011ed95bfe",
@ -36,8 +30,12 @@
"grunt-contrib-less": "0.8.x",
"grunt-electron-installer": "2.x.x",
"grunt-lesslint": "0.13.x",
"lerna": "2.0.0-beta.37",
"pm2": "2.4.0",
"request": "2.x.x",
"s3": "4.x.x",
"temp": "0.8.x"
"temp": "0.8.x",
"underscore": "1.8.x"
},
"scripts": {
"start": "npm run start-client",
@ -54,7 +52,7 @@
"test-cloud": "",
"stop": "npm run stop-cloud",
"stop-cloud": "pm2 stop all; pm2 delete all;",
"build-cloud": "",
"build-cloud": "docker build .",
"postinstall": "babel-node scripts/postinstall.js"
},