From 190fb561fd453c5a1cbc3bf98cc0e2d83d958ee7 Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Mon, 15 Feb 2021 10:34:27 -0600 Subject: [PATCH] =?UTF-8?q?Remove=20=E2=80=9CToggle=20Localizer=20Tools?= =?UTF-8?q?=E2=80=9D,=20encourage=20folks=20to=20submit=20PRs=20instead?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../localizer-help/assets/choose-element.png | Bin 488 -> 0 bytes .../localizer-help/lib/main.tsx | 188 ------------------ .../localizer-help/package.json | 17 -- app/menus/darwin.js | 1 - app/menus/linux.js | 1 - app/menus/win32.js | 1 - 6 files changed, 208 deletions(-) delete mode 100644 app/internal_packages/localizer-help/assets/choose-element.png delete mode 100644 app/internal_packages/localizer-help/lib/main.tsx delete mode 100644 app/internal_packages/localizer-help/package.json diff --git a/app/internal_packages/localizer-help/assets/choose-element.png b/app/internal_packages/localizer-help/assets/choose-element.png deleted file mode 100644 index ee4fe103b21a8762f5f3acebad435573249e8c02..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 488 zcmVP)Nkl$)?a|Lm-;cD-I%p667SCADo!QD9I29^dP7(m>x8PWLI7+49!A&;(OVCiB&YLGrz<7!W*6J0JBl2!x&(uV-D=6N3N z_j|H!Ta#AAK{61-Fz9eN(D8WG0D+IPqA^fkMSrf6BAInsEEZj=`VjP$Kybi1y)yi* z<2Yu+Ig@~puFYm6Vn2fEkg8%sMOb)LRuo0rE0_kEuMQ`}uP|N;Ujbg`sIK*T-BlKz z4dVfhm(as7>}0Db { - const { current, suggestion } = this.state; - - try { - const { status } = await MailspringAPIRequest.makeRequest({ - server: 'identity', - method: 'POST', - body: { current, suggestion, language: window.navigator.language }, - path: '/api/localization-suggestion', - json: true, - }); - if (status === 'success') { - remote.dialog.showMessageBoxSync({ - type: 'info', - buttons: [localized('OK')], - message: localized('Thank you!'), - title: localized('Thank you!'), - detail: localized( - `Your updated localization will be reviewed and included in a future version of Mailspring.` - ), - }); - } - } catch (err) { - AppEnv.showErrorDialog(err.toString()); - } - }; - - onSelectionBogusClick = event => { - event.preventDefault(); - event.stopPropagation(); - document.removeEventListener('click', this.onSelectionBogusClick, true); - }; - - onSelectionMouseDown = event => { - let text = null; - const element = document.elementFromPoint(event.clientX, event.clientY) as any; - - if (element) { - if (element.nodeName === 'INPUT') { - if (element.value) { - text = element.value; - } else { - text = element.placeholder; - } - } else if (element.innerText.length > 0) { - text = element.innerText; - } else { - const parent = element.closest('[title]'); - text = parent ? parent.title : ''; - } - } - - event.preventDefault(); - event.stopPropagation(); - document.removeEventListener('mousedown', this.onSelectionMouseDown); - if (text && text.length) { - this.setState({ selecting: false, current: text, suggestion: text }); - } else { - this.setState({ selecting: false }); - } - }; - - onToggleSelectionMode = () => { - if (this.state.selecting) { - document.removeEventListener('mousedown', this.onSelectionMouseDown); - document.removeEventListener('click', this.onSelectionBogusClick, true); - this.setState({ selecting: false }); - } else { - document.addEventListener('mousedown', this.onSelectionMouseDown); - document.addEventListener('click', this.onSelectionBogusClick, true); - this.setState({ selecting: true }); - } - }; - - render() { - const { selecting, current, suggestion } = this.state; - - return ( -
-
- - {localized('Submit Improved Localizations')} - - - this.setState({ current: e.target.value })} - /> - = - this.setState({ suggestion: e.target.value })} - /> - -
-
- - {localized( - 'Have a GitHub account? Want to contibute many translations? Contribute directly via a Pull Request!' - )} - - - Learn More - -
-
- ); - } -} - -let visible = false; - -export function activate() { - AppEnv.commands.add(document.body, 'window:toggle-localizer-tools', () => { - if (!visible) { - ComponentRegistry.register(SubmitLocalizationsBar, { - location: WorkspaceStore.Sheet.Global.Footer, - }); - } else { - ComponentRegistry.unregister(SubmitLocalizationsBar); - } - - visible = !visible; - }); -} - -export function deactivate() { - if (visible) { - ComponentRegistry.unregister(SubmitLocalizationsBar); - } -} diff --git a/app/internal_packages/localizer-help/package.json b/app/internal_packages/localizer-help/package.json deleted file mode 100644 index cb8441708..000000000 --- a/app/internal_packages/localizer-help/package.json +++ /dev/null @@ -1,17 +0,0 @@ -{ - "name": "localizer-help", - "version": "0.1.0", - "main": "./lib/main", - - "isOptional": true, - "isHiddenOnPluginsPage": true, - - "title": "Localizer Helper", - "description": "Allows localizers to click UI elements and suggest localizations inline.", - "icon": "./icon.png", - - "license": "GPL-3.0", - "engines": { - "mailspring": "*" - } -} diff --git a/app/menus/darwin.js b/app/menus/darwin.js index 50c399447..124f1bfc9 100644 --- a/app/menus/darwin.js +++ b/app/menus/darwin.js @@ -212,7 +212,6 @@ module.exports = { { label: localized('Install a Plugin') + '...', command: 'window:install-package' }, { type: 'separator' }, { label: localized('Reload'), command: 'window:reload' }, - { label: localized('Toggle Localizer Tools'), command: 'window:toggle-localizer-tools' }, { label: localized('Toggle Developer Tools'), command: 'window:toggle-dev-tools' }, { label: localized('Toggle Component Regions'), diff --git a/app/menus/linux.js b/app/menus/linux.js index ecb1a7a76..a68d4dd7b 100644 --- a/app/menus/linux.js +++ b/app/menus/linux.js @@ -181,7 +181,6 @@ module.exports = { { label: localized('Install a Plugin') + '...', command: 'window:install-package' }, { type: 'separator' }, { label: localized('Reload'), command: 'window:reload' }, - { label: localized('Toggle Localizer Tools'), command: 'window:toggle-localizer-tools' }, { label: localized('Toggle Developer Tools'), command: 'window:toggle-dev-tools' }, { label: localized('Toggle Component Regions'), diff --git a/app/menus/win32.js b/app/menus/win32.js index 35d1bb57a..0c17c203f 100644 --- a/app/menus/win32.js +++ b/app/menus/win32.js @@ -158,7 +158,6 @@ module.exports = { { label: localized('Install a Plugin') + '...', command: 'window:install-package' }, { type: 'separator' }, { label: localized('Reload'), command: 'window:reload' }, - { label: localized('Toggle Localizer Tools'), command: 'window:toggle-localizer-tools' }, { label: localized('Toggle Developer Tools'), command: 'window:toggle-dev-tools' }, { label: localized('Toggle Component Regions'),