From 1a36bec6fc02018d08d4f70001fcc1b2269ae7b0 Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Fri, 7 Jul 2017 15:57:29 -0700 Subject: [PATCH] Allow Attribute.Collection to have unspecified / basic type e.g. string --- .../client-app/src/flux/attributes/attribute-collection.es6 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/client-app/src/flux/attributes/attribute-collection.es6 b/packages/client-app/src/flux/attributes/attribute-collection.es6 index 631b04877..c7a96c5a3 100644 --- a/packages/client-app/src/flux/attributes/attribute-collection.es6 +++ b/packages/client-app/src/flux/attributes/attribute-collection.es6 @@ -47,7 +47,7 @@ export default class AttributeCollection extends Attribute { } return vals.map((val) => { - if (!(val instanceof this.ItemClass)) { + if (this.ItemClass && !(val instanceof this.ItemClass)) { throw new Error(`AttributeCollection::toJSON: Value \`${val}\` in ${this.modelKey} is not an ${this.ItemClass.name}`); } return (val.toJSON !== undefined) ? val.toJSON() : val; @@ -59,7 +59,7 @@ export default class AttributeCollection extends Attribute { return []; } return json.map((objJSON) => { - if (!objJSON || objJSON instanceof this.ItemClass) { + if (!objJSON || !this.ItemClass || objJSON instanceof this.ItemClass) { return objJSON; } return new this.ItemClass(objJSON);