bump(electron): Fix remaining deprecated requires, move to 1.0.1

This commit is contained in:
Ben Gotow 2016-05-12 13:59:20 -07:00
parent 589f77d7e1
commit 26d4361bfb
15 changed files with 26 additions and 33 deletions

View file

@ -486,7 +486,7 @@ export default class ComposerView extends React.Component {
return false; return false;
} }
const dialog = remote.require('dialog'); const dialog = remote.dialog;
const {to, cc, bcc, body, files, uploads} = this.props.draft; const {to, cc, bcc, body, files, uploads} = this.props.draft;
const allRecipients = [].concat(to, cc, bcc); const allRecipients = [].concat(to, cc, bcc);

View file

@ -77,7 +77,7 @@ class ComposerWithWindowProps extends React.Component {
} }
_showInitialErrorDialog(msg) { _showInitialErrorDialog(msg) {
const dialog = remote.require('dialog'); const dialog = remote.dialog;
// We delay so the view has time to update the restored draft. If we // We delay so the view has time to update the restored draft. If we
// don't delay the modal may come up in a state where the draft looks // don't delay the modal may come up in a state where the draft looks
// like it hasn't been restored or has been lost. // like it hasn't been restored or has been lost.

View file

@ -160,7 +160,7 @@ describe "ComposerView", ->
beforeEach -> beforeEach ->
spyOn(NylasEnv, "isMainWindow").andReturn true spyOn(NylasEnv, "isMainWindow").andReturn true
{remote} = require('electron') {remote} = require('electron')
@dialog = remote.require('dialog') @dialog = remote.dialog
spyOn(remote, "getCurrentWindow") spyOn(remote, "getCurrentWindow")
spyOn(@dialog, "showMessageBox") spyOn(@dialog, "showMessageBox")
spyOn(Actions, "sendDraft") spyOn(Actions, "sendDraft")

View file

@ -77,8 +77,8 @@ class MessageControls extends React.Component
Actions.composeForward(thread: @props.thread, message: @props.message) Actions.composeForward(thread: @props.thread, message: @props.message)
_onShowActionsMenu: => _onShowActionsMenu: =>
SystemMenu = remote.require('menu') SystemMenu = remote.Menu
SystemMenuItem = remote.require('menu-item') SystemMenuItem = remote.MenuItem
# Todo: refactor this so that message actions are provided # Todo: refactor this so that message actions are provided
# dynamically. Waiting to see if this will be used often. # dynamically. Waiting to see if this will be used often.
@ -108,7 +108,7 @@ class MessageControls extends React.Component
.then => .then =>
Actions.sendDraft(draft.clientId) Actions.sendDraft(draft.clientId)
dialog = remote.require('dialog') dialog = remote.dialog
dialog.showMessageBox remote.getCurrentWindow(), { dialog.showMessageBox remote.getCurrentWindow(), {
type: 'warning' type: 'warning'
buttons: ['OK'], buttons: ['OK'],
@ -119,8 +119,8 @@ class MessageControls extends React.Component
_onShowOriginal: => _onShowOriginal: =>
fs = require 'fs' fs = require 'fs'
path = require 'path' path = require 'path'
BrowserWindow = remote.require('browser-window') BrowserWindow = remote.BrowserWindow
app = remote.require('app') app = remote.app
tmpfile = path.join(app.getPath('temp'), @props.message.id) tmpfile = path.join(app.getPath('temp'), @props.message.id)
NylasAPI.makeRequest NylasAPI.makeRequest

View file

@ -11,7 +11,7 @@
"bugs": { "bugs": {
"url": "https://github.com/nylas/N1/issues" "url": "https://github.com/nylas/N1/issues"
}, },
"electronVersion": "0.37.8", "electronVersion": "1.0.1",
"dependencies": { "dependencies": {
"async": "^0.9", "async": "^0.9",
"babel-core": "6.8.0", "babel-core": "6.8.0",

View file

@ -48,7 +48,7 @@ function makeSqlite3Command() {
// Use our local version of npm (npm 3x) to build sqlite // Use our local version of npm (npm 3x) to build sqlite
var npmPath = '"' + path.resolve(__dirname, '..', 'build', 'node_modules', '.bin', 'npm') + '"'; var npmPath = '"' + path.resolve(__dirname, '..', 'build', 'node_modules', '.bin', 'npm') + '"';
return npmPath + " install https://github.com/bengotow/node-sqlite3/archive/bengotow/fts5.tar.gz --ignore-scripts && cd node_modules/sqlite3 && "+nodeGypPath+" configure rebuild --target="+targetElectronVersion+" --arch="+targetArch+" --target_platform="+targetPlatform+" --dist-url=https://atom.io/download/atom-shell --module_name=node_sqlite3 --module_path=../lib/binding/electron-v0.37-"+targetPlatform+"-"+targetArch return npmPath + " install https://github.com/bengotow/node-sqlite3/archive/bengotow/fts5.tar.gz --ignore-scripts && cd node_modules/sqlite3 && "+nodeGypPath+" configure rebuild --target="+targetElectronVersion+" --arch="+targetArch+" --target_platform="+targetPlatform+" --dist-url=https://atom.io/download/atom-shell --module_name=node_sqlite3 --module_path=../lib/binding/electron-v1.0-"+targetPlatform+"-"+targetArch
} }
function bootstrap() { function bootstrap() {

View file

@ -389,8 +389,7 @@ class Contenteditable extends React.Component
event.preventDefault() event.preventDefault()
{remote} = require('electron') {remote} = require('electron')
Menu = remote.require('menu') {Menu, MenuItem} = remote
MenuItem = remote.require('menu-item')
menu = new Menu() menu = new Menu()

View file

@ -202,12 +202,8 @@ class EventedIFrame extends React.Component
# "Copy Image" and "Search Google for 'Bla'" # "Copy Image" and "Search Google for 'Bla'"
event.preventDefault() event.preventDefault()
{remote} = require('electron') {remote, clipboard, shell, nativeImage} = require('electron')
clipboard = require('electron').clipboard {Menu, MenuItem} = remote
Menu = remote.require('menu')
MenuItem = remote.require('menu-item')
NativeImage = require('native-image')
shell = require('electron').shell
path = require('path') path = require('path')
fs = require('fs') fs = require('fs')
menu = new Menu() menu = new Menu()
@ -253,7 +249,7 @@ class EventedIFrame extends React.Component
canvas.height = img.height canvas.height = img.height
canvas.getContext("2d").drawImage(imageTarget, 0, 0) canvas.getContext("2d").drawImage(imageTarget, 0, 0)
imageDataURL = canvas.toDataURL("image/png") imageDataURL = canvas.toDataURL("image/png")
img = NativeImage.createFromDataURL(imageDataURL) img = nativeImage.createFromDataURL(imageDataURL)
clipboard.writeImage(img) clipboard.writeImage(img)
, false) , false)
img.src = src img.src = src

View file

@ -164,8 +164,8 @@ export default class ParticipantsTextField extends React.Component {
_onShowContextMenu = (participant) => { _onShowContextMenu = (participant) => {
// Warning: Menu is already initialized as Menu.cjsx! // Warning: Menu is already initialized as Menu.cjsx!
const MenuClass = remote.require('menu'); const MenuClass = remote.Menu;
const MenuItem = remote.require('menu-item'); const MenuItem = remote.MenuItem;
const menu = new MenuClass(); const menu = new MenuClass();
menu.append(new MenuItem({ menu.append(new MenuItem({

View file

@ -502,8 +502,7 @@ class TokenizingTextField extends React.Component
_showDefaultTokenMenu: (token) => _showDefaultTokenMenu: (token) =>
{remote} = require('electron') {remote} = require('electron')
Menu = remote.require('menu') {Menu, MenuItem} = remote
MenuItem = remote.require('menu-item')
menu = new Menu() menu = new Menu()
menu.append(new MenuItem( menu.append(new MenuItem(

View file

@ -8,9 +8,9 @@ fs = require('fs-plus');
path = require('path'); path = require('path');
if (process.type === 'renderer') { if (process.type === 'renderer') {
remote = require('electron').remote; remote = require('electron').remote;
app = remote.require('app'); app = remote.app;
} else { } else {
app = require('app'); app = require('electron').app;
} }
// A globally available ErrorLogger that can report errors to various // A globally available ErrorLogger that can report errors to various

View file

@ -338,7 +338,7 @@ class NylasEnvConstructor
# content trace visualizer (chrome://tracing). It's like Chromium Developer # content trace visualizer (chrome://tracing). It's like Chromium Developer
# Tools Profiler, but for all processes and threads. # Tools Profiler, but for all processes and threads.
trace: -> trace: ->
tracing = remote.require('electron').contentTracing tracing = remote.contentTracing
opts = opts =
categoryFilter: '*', categoryFilter: '*',
traceOptions: 'record-until-full,enable-sampling,enable-systrace', traceOptions: 'record-until-full,enable-sampling,enable-systrace',
@ -411,7 +411,7 @@ class NylasEnvConstructor
@getCurrentWindow().close() @getCurrentWindow().close()
quit: -> quit: ->
remote.require('app').quit() remote.app.quit()
# Essential: Get the size of current window. # Essential: Get the size of current window.
# #
@ -844,7 +844,7 @@ class NylasEnvConstructor
null null
exit: (status) -> exit: (status) ->
app = remote.require('app') app = remote.app
app.emit('will-exit') app.emit('will-exit')
remote.process.exit(status) remote.process.exit(status)

View file

@ -1,7 +1,7 @@
path = require('path') path = require('path')
spellchecker = require('spellchecker') spellchecker = require('spellchecker')
{remote} = require('electron') {remote} = require('electron')
MenuItem = remote.require('menu-item') MenuItem = remote.MenuItem
class NylasSpellchecker class NylasSpellchecker
constructor: -> constructor: ->

View file

@ -123,7 +123,7 @@ class WindowEventHandler
{remote} = require('electron') {remote} = require('electron')
_.defer -> _.defer ->
if remote.getGlobal('application').quitting if remote.getGlobal('application').quitting
remote.require('app').quit() remote.app.quit()
else else
NylasEnv.close() NylasEnv.close()
@ -180,8 +180,7 @@ class WindowEventHandler
word = event.target.value.substr(wordStart, wordEnd - wordStart) word = event.target.value.substr(wordStart, wordEnd - wordStart)
{remote} = require('electron') {remote} = require('electron')
Menu = remote.require('menu') {Menu, MenuItem} = remote
MenuItem = remote.require('menu-item')
menu = new Menu() menu = new Menu()
NylasSpellchecker = require('./nylas-spellchecker') NylasSpellchecker = require('./nylas-spellchecker')

View file

@ -60,7 +60,7 @@ function setupWindow (loadSettings) {
// productName: 'N1', // productName: 'N1',
// companyName: 'Nylas', // companyName: 'Nylas',
// // By explicitly passing the app version here, we could save the call // // By explicitly passing the app version here, we could save the call
// // of "require('electron').remote.require('app').getVersion()". // // of "require('electron').remote.app.getVersion()".
// extra: {_version: loadSettings.appVersion} // extra: {_version: loadSettings.appVersion}
// }) // })