From 334830d6e133152c9fd840c95c28519aa503e6c2 Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Thu, 22 Oct 2015 11:34:51 -0700 Subject: [PATCH] fix(feedback): Links should open in the user's default browser --- internal_packages/feedback/lib/feedback-button.cjsx | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/internal_packages/feedback/lib/feedback-button.cjsx b/internal_packages/feedback/lib/feedback-button.cjsx index 523987a74..3a0faa4a5 100644 --- a/internal_packages/feedback/lib/feedback-button.cjsx +++ b/internal_packages/feedback/lib/feedback-button.cjsx @@ -74,13 +74,21 @@ class FeedbackButton extends React.Component 'height': height, 'title': 'Feedback' + onOpenURL = (event, href) -> + shell = require 'shell' + shell.openExternal(href) + event.preventDefault() + # Disable window close, hide instead w.on 'close', (event) -> # inside the window we prevent close - here we route close to hide event.preventDefault() # this does nothing, contrary to the docs w.hide() w.on 'closed', (event) -> - window.feedbackWindow = null # if the window does get closed, clear our ref to it + # if the window does get closed, clear our ref to it + window.feedbackWindow = null + w.webContents.on('new-window', onOpenURL) + w.webContents.on('will-navigate', onOpenURL) url = path.join __dirname, '..', 'feedback.html' w.loadUrl("file://#{url}?#{params}")