Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-22 00:06:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(mailto): test case / parsing for url encoded To field

Browse source
This commit is contained in:
Ben Gotow 2016-02-01 11:22:23 -08:00
parent cbfe310521
commit 3d3f7fa315
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
spec/stores/draft-store-spec.coffee
View file

@ -897,6 +897,7 @@ describe "DraftStore", ->
'mailto:'
'mailto://bengotow@gmail.com'
'mailto:bengotow@gmail.com'
'mailto:mg%40nylas.com'
'mailto:?subject=%1z2a', # fails uriDecode
'mailto:?subject=%52z2a', # passes uriDecode
'mailto:?subject=Martha Stewart',
@ -919,6 +920,9 @@ describe "DraftStore", ->
new Message(
to: [new Contact(name: 'bengotow@gmail.com', email: 'bengotow@gmail.com')]
),
new Message(
to: [new Contact(name: 'mg@nylas.com', email: 'mg@nylas.com')]
),
new Message(
subject: '%1z2a'
),
@ -986,8 +990,8 @@ describe "DraftStore", ->
expect(received['subject']).toEqual(expectedDraft['subject'])
expect(received['body']).toEqual(expectedDraft['body']) if expectedDraft['body']
['to', 'cc', 'bcc'].forEach (attr) ->
received[attr].forEach (contact, jdx) ->
expect(contact instanceof Contact).toBe(true)
expectedContact = expectedDraft[attr][jdx]
expect(contact.email).toEqual(expectedContact.email)
expect(contact.name).toEqual(expectedContact.name)
expectedDraft[attr].forEach (expected, jdx) ->
actual = received[attr][jdx]
expect(actual instanceof Contact).toBe(true)
expect(actual.email).toEqual(expected.email)
expect(actual.name).toEqual(expected.name)

3
src/flux/stores/draft-store.coffee
View file

@ -424,6 +424,9 @@ class DraftStore
[whole, to, queryString] = /mailto:\/*([^\?\&]*)((.|\n|\r)*)/.exec(urlString)
if to.length > 0 and to.indexOf('@') is -1
to = decodeURIComponent(to)
# /many/ mailto links are malformed and do things like:
# &body=https://github.com/atom/electron/issues?utf8=&q=is%3Aissue+is%3Aopen+123&subject=...
# (note the unescaped ? and & in the URL).