Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-03-01 10:33:14 +08:00
Code Issues Projects Releases Packages Wiki Activity

[client-app] Fix passing in nylasId and accountId to report metrics

Browse source 
Summary: This was really broken

Test Plan: manual

Reviewers: halla, mark, evan

Reviewed By: mark, evan

Differential Revision: https://phab.nylas.com/D4021
This commit is contained in:
Juan Tejada 2017-02-22 14:16:27 -08:00
parent ad1a192b53
commit 49586e2e06
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/client-app/src/flux/stores/thread-list-actions-store.es6
View file

@ -2,8 +2,6 @@ import NylasStore from 'nylas-store'
import Actions from '../actions'
import Utils from '../models/utils'
import TaskFactory from '../tasks/task-factory'
import AccountStore from '../stores/account-store'
import IdentityStore from '../stores/identity-store'
import FocusedPerspectiveStore from '../stores/focused-perspective-store'
@ -35,14 +33,6 @@ class ThreadListActionsStore extends NylasStore {
_onThreadListDidUpdate = (threads) => {
const updatedAt = Date.now()
const identity = IdentityStore.identity()
if (!identity) { return }
// accountId is irrelevant for metrics reporting but we need to include
// one in order to make a NylasAPIRequest to our /ingest-metrics endpoint
const accountId = AccountStore.accounts()[0]
const nylasId = identity.id
const threadIdsInList = new Set(threads.map(t => t.id))
for (const [timerId, timerData] of this._timers.entries()) {
@ -53,8 +43,6 @@ class ThreadListActionsStore extends NylasStore {
Actions.recordPerfMetric({
action,
source,
nylasId,
accountId,
actionTimeMs,
targetCategory,
threadCount: threadIds.length,