Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-21 15:56:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

[iso-core] fix error toJSON in node environments

Browse source 
Summary:
Node's native `Error` object does NOT implement toJSON. We attempt to call
toJSON when reporting errors. This wasn't noticed until now because
bunyan's pretty logger (which only run in dev mode) started JSONifying
errors

Test Plan:
Try and API auth with a bad username with local setup. See that it throws
toJSON error. After patch, error properly serializes

Reviewers: spang, halla, jerm, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D3975
This commit is contained in:
Evan Morikawa 2017-02-17 17:31:36 -08:00
parent c149e9171d
commit 5577d1b4d3
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/isomorphic-core/src/errors.js
View file

@ -1,7 +1,11 @@
class NylasError extends Error {
toJSON() {
const json = super.toJSON() || {}
let json = {}
if (super.toJSON) {
// Chromium `Error`s have a `toJSON`, but Node `Error`s do NOT!
json = super.toJSON()
}
Object.getOwnPropertyNames(this).forEach((key) => {
json[key] = this[key];
});