From 63db2fbf1583e797eabd22e226357893abdd6e3e Mon Sep 17 00:00:00 2001
From: Alessandro Magionami <alessandro.magionami@gmail.com>
Date: Mon, 23 Sep 2019 17:39:01 +0200
Subject: [PATCH] =?UTF-8?q?Added=20the=20leading=20'www'=20to=20the=20soci?=
 =?UTF-8?q?al=20links=20in=20the=20sidebar,=20now=20curso=E2=80=A6=20(#155?=
 =?UTF-8?q?9)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Added the leading 'www' to the facebook and linkedin links in the sidebar, now cursor pointer is shown wheh hovering social links in the sidebar

* SocialProfileLink now accepts a hostname parameter used to generate social link urls, service remains only for the img
---
 .../lib/sidebar-participant-profile.tsx       | 23 ++++++++++---------
 .../styles/participant-profile.less           |  1 +
 2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/app/internal_packages/participant-profile/lib/sidebar-participant-profile.tsx b/app/internal_packages/participant-profile/lib/sidebar-participant-profile.tsx
index 72f0ff42c..8b62d1937 100644
--- a/app/internal_packages/participant-profile/lib/sidebar-participant-profile.tsx
+++ b/app/internal_packages/participant-profile/lib/sidebar-participant-profile.tsx
@@ -104,14 +104,15 @@ class ProfilePictureOrColorBox extends React.Component<{
     );
   }
 }
-class SocialProfileLink extends React.Component<{ handle: string; service: string }> {
+class SocialProfileLink extends React.Component<{ handle: string; service: string, hostname: string }> {
   static propTypes = {
     service: PropTypes.string,
     handle: PropTypes.string,
+    hostname: PropTypes.string,
   };
 
   render() {
-    const { handle, service } = this.props;
+    const { handle, service, hostname } = this.props;
 
     if (!handle) {
       return false;
@@ -119,8 +120,8 @@ class SocialProfileLink extends React.Component<{ handle: string; service: strin
     return (
       <a
         className="social-profile-item"
-        title={`https://${service}.com/${handle}`}
-        href={`https://${service}.com/${handle}`}
+        title={`https://${hostname}/${handle}`}
+        href={`https://${hostname}/${handle}`}
       >
         <RetinaImg
           url={`mailspring://participant-profile/assets/${service}-sidebar-icon@2x.png`}
@@ -473,10 +474,10 @@ export default class SidebarParticipantProfile extends React.Component<
           <IconRow icon="funding" node={funding} />
 
           <div className="social-profiles-wrap">
-            <SocialProfileLink service="facebook" handle={facebook && facebook.handle} />
-            <SocialProfileLink service="crunchbase" handle={crunchbase && crunchbase.handle} />
-            <SocialProfileLink service="linkedin" handle={linkedin && linkedin.handle} />
-            <SocialProfileLink service="twitter" handle={twitter && twitter.handle} />
+            <SocialProfileLink service="facebook" hostname="www.facebook.com" handle={facebook && facebook.handle} />
+            <SocialProfileLink service="crunchbase" hostname="www.crunchbase.com" handle={crunchbase && crunchbase.handle} />
+            <SocialProfileLink service="linkedin" hostname="www.linkedin.com" handle={linkedin && linkedin.handle} />
+            <SocialProfileLink service="twitter" hostname="twitter.com" handle={twitter && twitter.handle} />
           </div>
         </div>
       </div>
@@ -513,9 +514,9 @@ export default class SidebarParticipantProfile extends React.Component<
           </div>
 
           <div className="social-profiles-wrap">
-            <SocialProfileLink service="facebook" handle={facebook && facebook.handle} />
-            <SocialProfileLink service="linkedin" handle={linkedin && `in/${linkedin.handle}`} />
-            <SocialProfileLink service="twitter" handle={twitter && twitter.handle} />
+            <SocialProfileLink service="facebook" hostname="www.facebook.com" handle={facebook && facebook.handle} />
+            <SocialProfileLink service="linkedin" hostname="www.linkedin.com" handle={linkedin && `in/${linkedin.handle}`} />
+            <SocialProfileLink service="twitter" hostname="twitter.com" handle={twitter && twitter.handle} />
           </div>
         </div>
 
diff --git a/app/internal_packages/participant-profile/styles/participant-profile.less b/app/internal_packages/participant-profile/styles/participant-profile.less
index 69dd6c2f5..0c77546c7 100644
--- a/app/internal_packages/participant-profile/styles/participant-profile.less
+++ b/app/internal_packages/participant-profile/styles/participant-profile.less
@@ -117,6 +117,7 @@
   }
   .social-profile-item {
     margin: 0 10px;
+    cursor: pointer;
     &:first-child {
       margin-left: 0;
     }