Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-03-01 10:33:14 +08:00
Code Issues Projects Releases Packages Wiki Activity

feat(babel6): 90,798 lint problems

Browse source 
Fix eslint-task. Grunt doesn't recognize es6 files
This commit is contained in:
Evan Morikawa 2016-05-05 16:39:52 -07:00
parent e054a6ac91
commit 654820d568
2 changed files with 17 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/package.json
View file

@ -17,6 +17,8 @@
"escope": "3.3.0",
"eslint": "2.x.x",
"eslint-config-airbnb": "8.x.x",
"eslint-plugin-import": "1.x.x",
"eslint-plugin-jsx-a11y": "1.x.x",
"eslint-plugin-react": "5.x.x",
"fs-plus": "2.x",
"github-releases": "~0.3.0",

31
build/tasks/eslint-task.es6 → build/tasks/eslint-task.js
View file

@ -1,14 +1,13 @@
// Copied from https://github.com/sindresorhus/grunt-eslint
// So we can use our own eslint instead of this tasks's dependency.
const chalk = require('chalk');
const eslint = require('eslint');
'use strict';
var chalk = require('chalk');
var eslint = require('eslint');
module.exports = function eslintTask(grunt) {
grunt.registerMultiTask('eslint', 'Validate files with ESLint', () => {
const opts = this.options({
module.exports = function (grunt) {
grunt.registerMultiTask('eslint', 'Validate files with ESLint', function () {
var opts = this.options({
outputFile: false,
quiet: false,
maxWarnings: -1,
maxWarnings: -1
});
// legacy
@ -25,16 +24,16 @@ module.exports = function eslintTask(grunt) {
return true;
}
const formatter = eslint.CLIEngine.getFormatter(opts.format);
var formatter = eslint.CLIEngine.getFormatter(opts.format);
if (!formatter) {
grunt.warn(`Could not find formatter ${opts.format}'.`);
grunt.warn('Could not find formatter ' + opts.format + '\'.');
return false;
}
const engine = new eslint.CLIEngine(opts);
var engine = new eslint.CLIEngine(opts);
let report;
var report;
try {
report = engine.executeOnFiles(this.filesSrc);
} catch (err) {
@ -46,13 +45,13 @@ module.exports = function eslintTask(grunt) {
eslint.CLIEngine.outputFixes(report);
}
let results = report.results;
var results = report.results;
if (opts.quiet) {
results = eslint.CLIEngine.getErrorResults(results);
}
const output = formatter(results);
var output = formatter(results);
if (opts.outputFile) {
grunt.file.write(opts.outputFile, output);
@ -60,10 +59,10 @@ module.exports = function eslintTask(grunt) {
console.log(output);
}
const tooManyWarnings = opts.maxWarnings >= 0 && report.warningCount > opts.maxWarnings;
var tooManyWarnings = opts.maxWarnings >= 0 && report.warningCount > opts.maxWarnings;
if (report.errorCount === 0 && tooManyWarnings) {
grunt.warn(`ESLint found too many warnings (maximum:${opts.maxWarnings})`);
grunt.warn('ESLint found too many warnings (maximum:' + opts.maxWarnings + ')');
}
return report.errorCount === 0;