Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-24 08:04:11 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(selection): ExportedSelection must properly represent "None"

Browse source
This commit is contained in:
Ben Gotow 2016-01-12 11:25:01 -08:00
parent 646785e182
commit 67a448db5d
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/components/contenteditable/exported-selection.coffee
View file

@ -9,12 +9,15 @@
#
class ExportedSelection
constructor: (@rawSelection, @scopeNode) ->
@anchorNode = @rawSelection.anchorNode.cloneNode(true)
@anchorOffset = @rawSelection.anchorOffset
@anchorNodeIndex = DOMUtils.getNodeIndex(@scopeNode, @rawSelection.anchorNode)
@focusNode = @rawSelection.focusNode.cloneNode(true)
@focusOffset = @rawSelection.focusOffset
@focusNodeIndex = DOMUtils.getNodeIndex(@scopeNode, @rawSelection.focusNode)
@type = @rawSelection.type
unless @type is 'None'
@anchorNode = @rawSelection.anchorNode.cloneNode(true)
@anchorOffset = @rawSelection.anchorOffset
@anchorNodeIndex = DOMUtils.getNodeIndex(@scopeNode, @rawSelection.anchorNode)
@focusNode = @rawSelection.focusNode.cloneNode(true)
@focusOffset = @rawSelection.focusOffset
@focusNodeIndex = DOMUtils.getNodeIndex(@scopeNode, @rawSelection.focusNode)
@isCollapsed = @rawSelection.isCollapsed
### Public: Tests for equality amongst exported selections
@ -32,7 +35,10 @@ class ExportedSelection
and `endNodeIndex` fields via the `DOMUtils.getNodeIndex` method.
###
isEqual: (otherSelection) ->
return true if not otherSelection?
return false unless otherSelection?
return false if @type isnt otherSelection.type
return true if @type is 'None' and otherSelection.type is 'None'
return false if not otherSelection.anchorNode? or not otherSelection.focusNode?
anchorIndex = DOMUtils.getNodeIndex(@scopeNode, otherSelection.anchorNode)