Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-10-02 17:34:49 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(analyitcs): make sure to flush events before they close

Browse source
This commit is contained in:
Evan Morikawa 2016-06-02 16:24:32 +01:00
parent 077472af55
commit 680b219662
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
internal_packages/onboarding/lib/page-welcome.jsx
View file

@ -7,7 +7,15 @@ export default class WelcomePage extends React.Component {
static displayName = "WelcomePage";
_onContinue = () => {
Actions.recordUserEvent('Welcome Page Finished');
// We don't have a NylasId yet and therefore can't track the "Welcome
// Page Finished" event.
//
// If a user already has a Nylas ID and gets to this page (which
// happens if they sign out of all of their accounts), then it would
// properly fire. This is a rare case though and we don't want
// analytics users thinking it's part of the full funnel.
//
// Actions.recordUserEvent('Welcome Page Finished');
OnboardingActions.moveToPage("tutorial");
}

2
src/pro

@ -1 +1 @@
Subproject commit 590b767ebcd186be0a932a08015fb3f1c67d947f
Subproject commit 46d249d99f754fe5dfb719583b398bdcc0d3ba5f