From 683ef61c1f9b165c7dcdc1467687b7ec6ceac29c Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Mon, 9 Nov 2015 21:44:59 -0800 Subject: [PATCH] fix(prefs): `atom.keymaps` does not implement unsubscribe https://github.com/atom/atom-keymap/issues/101 --- .../preferences/lib/tabs/preferences-keymaps.cjsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx b/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx index c7af6ea2c..c6258fb01 100644 --- a/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx +++ b/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx @@ -25,11 +25,14 @@ class PreferencesKeymaps extends React.Component @_loadTemplates() componentDidMount: => - @unsubscribe = atom.keymaps.onDidReloadKeymap => + @_mounted = true + atom.keymaps.onDidReloadKeymap => + # Temporary fix for https://github.com/atom/atom-keymap/issues/101 + return unless @_mounted @setState(bindings: @_getStateFromKeymaps()) componentWillUnmount: => - @unsubscribe?() + @_mounted = false _loadTemplates: => templatesDir = path.join(atom.getLoadSettings().resourcePath, 'keymaps', 'templates')