Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-09-11 15:14:31 +08:00
Code Issues Projects Releases Packages Wiki Activity

[local-sync] Retry syncback tasks that throw retryable errors

Browse source 
Summary:
This will prevent us from showing error messages to the user when we
can automatically recover from the error

Test Plan: manual-- throw error from syncback task, check expected results

Reviewers: evan, mark, spang

Reviewed By: spang

Differential Revision: https://phab.nylas.com/D3812
This commit is contained in:
Juan Tejada 2017-01-31 10:29:57 -08:00
parent 71959b44fb
commit 7029653c00
1 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
packages/local-sync/src/local-sync-worker/syncback-task-helpers.es6
View file

@ -1,5 +1,7 @@
const {IMAPErrors} = require('isomorphic-core')
const SyncbackTaskFactory = require('./syncback-task-factory');
const MAX_TASK_RETRIES = 2
// TODO NOTE! These are the tasks we exclude from the sync loop. This should be
// refactored later.
@ -118,11 +120,22 @@ export async function runSyncbackTask({task, runTask} = {}) {
syncbackRequest.status = "INPROGRESS";
await syncbackRequest.save();
// TODO `runTask` is a hack to allow tasks to be executed outside the
// context of an imap connection, specifically to allow running send tasks
// outside of the sync loop. This should be solved in a better way or
// probably refactored when we implement the sync scheduler
const responseJSON = await runTask(task)
let responseJSON;
for (let numTries = 0; numTries <= MAX_TASK_RETRIES; numTries++) {
try {
// TODO `runTask` is a hack to allow tasks to be executed outside the
// context of an imap connection, specifically to allow running send tasks
// outside of the sync loop. This should be solved in a better way or
// probably refactored when we implement the sync scheduler
responseJSON = await runTask(task)
break;
} catch (err) {
if (!(err instanceof IMAPErrors.RetryableError) || numTries >= MAX_TASK_RETRIES) {
throw err
}
}
}
syncbackRequest.status = "SUCCEEDED";
syncbackRequest.responseJSON = responseJSON || {};
const after = new Date();