Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-12-29 11:52:34 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(thread-list): Don't rely on zip since it can become off-by-one forever

Browse source
This commit is contained in:
Ben Gotow 2016-04-28 15:53:29 -07:00
parent b3ea335345
commit 765d9f30fc
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
internal_packages/thread-list/lib/thread-list-data-source.coffee
View file

@ -18,13 +18,15 @@ _flatMapJoiningMessages = ($threadsResultSet) =>
# we make a single database query and load /all/ the message metadata for
# the new threads at once. (This is a performance optimization -it's about
# ~80msec faster than making 100 queries for 100 new thread ids separately.)
Rx.Observable.zip([
$threadsResultSet,
$threadsResultSet.flatMapLatest (threadsResultSet) =>
$threadsResultSet.flatMapLatest (threadsResultSet) =>
missingIds = threadsResultSet.ids().filter (id) -> not $messagesResultSets[id]
return Rx.Observable.from([[]]) if missingIds.length is 0
Rx.Observable.fromPromise(DatabaseStore.findAll(Message, threadId: missingIds))
])
if missingIds.length is 0
promise = Promise.resolve([threadsResultSet, []])
else
promise = DatabaseStore.findAll(Message, threadId: missingIds).then (messages) =>
Promise.resolve([threadsResultSet, messages])
return Rx.Observable.fromPromise(promise)
# 3. when that finishes, we group the loaded messsages by threadId and create
# the missing observables. Creating a query subscription would normally load