Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-01-04 07:10:06 +08:00
Code Issues Projects Releases Packages Wiki Activity

Make spellcheck decorator changes invisible to the undo/redo stack

Browse source
This commit is contained in:
Ben Gotow 2018-01-11 15:09:25 -08:00
parent ebb860f3ed
commit 84d40727af
1 changed files with 35 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
app/src/components/composer-editor/spellcheck-plugins.jsx
View file

@ -147,7 +147,10 @@ function onSpellcheckFocusedNode(change) {
}
});
change.setValue({ decorations: next });
change
.setOperationFlag('save', false)
.setValue({ decorations: next })
.setOperationFlag('save', true);
}
function onSpellcheckFullDocument(editor) {
@ -170,8 +173,37 @@ function onSpellcheckFullDocument(editor) {
break;
}
}
const change = value.change().setValue({ decorations });
editor.onChange(change);
// compare old decorations to new decorations. If we call call onChange
// it pushes on the undo stack, which we don't want to do unnecessarily.
let changed = false;
const previous = value.get('decorations');
if (!previous || previous.size !== decorations.length) {
changed = true;
} else {
const table = {};
previous.forEach(
d => (table[`${d.anchorKey}:${d.anchorOffset}-${d.focusKey}:${d.focusOffset}`] = true)
);
for (const d of decorations) {
if (!table[`${d.anchorKey}:${d.anchorOffset}-${d.focusKey}:${d.focusOffset}`]) {
changed = true;
break;
}
}
}
if (changed) {
const change = value
.change()
.setOperationFlag('save', false)
.setValue({ decorations })
.setOperationFlag('save', true);
editor.onChange(change);
} else {
console.log('skipping pointless decorator update');
}
}
let timer = null;