From 8afb14c4c6a6c91f76fcf365ca49c83af4da2dc9 Mon Sep 17 00:00:00 2001 From: Juan Tejada Date: Fri, 17 Feb 2017 13:20:19 -0800 Subject: [PATCH] [*] metrics(Part 4): Make /ingest-metrics use MetricsReporter Summary: This ensures that the Libhoney instance is a singleton in cloud processes. Test Plan: manual Reviewers: mark, spang Reviewed By: spang Differential Revision: https://phab.nylas.com/D3969 --- packages/isomorphic-core/src/metrics-reporter.es6 | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/isomorphic-core/src/metrics-reporter.es6 b/packages/isomorphic-core/src/metrics-reporter.es6 index 7a2e70a8a..348db277a 100644 --- a/packages/isomorphic-core/src/metrics-reporter.es6 +++ b/packages/isomorphic-core/src/metrics-reporter.es6 @@ -28,6 +28,13 @@ class MetricsReporter { }); } + sendToHoneycomb(info) { + if (!this._honey) { + throw new Error('Metrics Reporter: Honeycomb is not available in this environment') + } + this._honey.sendNow(info); + } + async reportEvent(info) { if (!info.accountId) { throw new Error("Metrics Reporter: You must include an accountId"); @@ -58,11 +65,11 @@ class MetricsReporter { }); await req.run() } else { - this._honey.sendNow(info); + this.sendToHoneycomb(info) } } catch (err) { - logger.log(info, "Metrics Collector: Submitted.", info); - logger.warn("Metrics Collector: Submission Failed.", {error: err, ...info}); + logger.log(info, "Metrics Reporter: Submitted.", info); + logger.warn("Metrics Reporter: Submission Failed.", {error: err, ...info}); } } }