Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-22 16:26:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(autolinker): Use getAttribute('href') because href is magic

Browse source
This commit is contained in:
Ben Gotow 2016-04-26 17:01:15 -07:00
parent e11181423e
commit 8e9346f224
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal_packages/message-list/lib/autolinker.es6
View file

@ -62,6 +62,6 @@ export function autolink(doc, {async} = {}) {
, ,
}); });
while (aTagWalker.nextNode()) { while (aTagWalker.nextNode()) {
aTagWalker.currentNode.title = aTagWalker.currentNode.href; aTagWalker.currentNode.title = aTagWalker.currentNode.getAttribute('href');
} }
} }

4
internal_packages/message-list/spec/autolinker-fixtures/linkedin-out.html
View file

@ -177,7 +177,7 @@ with Larry Wilmore"</a></td>
</tr> </tr>
<tr> <tr>
<td align="left" style="margin-left:0;color:#008CC9;font-weight:100;font-size:22px;line-height:26px;text-align:left;"> <td align="left" style="margin-left:0;color:#008CC9;font-weight:100;font-size:22px;line-height:26px;text-align:left;">
<a href="https://www.linkedin.com/e/v2/pulse?e=6m81ta-ilj7lvs1-it&amp;a=pulse_web_vi%E2%80%A6p;li=14&amp;m=hero&amp;permLink=why-i-havent-worked-30-years-larry-wilmore" title="Why I Haven’t Worked in 30 Years" style="margin-left:0;color:#008CC9;font-weight:100;text-decoration:none;text-align:left;"> <a href="https://www.linkedin.com/e/v2/pulse?e=6m81ta-ilj7lvs1-it&amp;a=pulse_web_vi%E2%80%A6p;li=14&amp;m=hero&amp;permLink=why-i-havent-worked-30-years-larry-wilmore" title="https://www.linkedin.com/e/v2/pulse?e=6m81ta-ilj7lvs1-it&amp;a=pulse_web_vi%E2%80%A6p;li=14&amp;m=hero&amp;permLink=why-i-havent-worked-30-years-larry-wilmore" style="margin-left:0;color:#008CC9;font-weight:100;text-decoration:none;text-align:left;">
Why I Haven’t Worked in 30 Years</a></td> Why I Haven’t Worked in 30 Years</a></td>
</tr> </tr>
<tr> <tr>
@ -224,7 +224,7 @@ Why I Haven’t Worked in 30 Years</a></td>
<table border="0" cellspacing="0" cellpadding="0" style="font-family:Helvetica,Arial,sans-serif;" width="520" class="responsive-article"> <table border="0" cellspacing="0" cellpadding="0" style="font-family:Helvetica,Arial,sans-serif;" width="520" class="responsive-article">
<tbody> <tbody>
<tr> <tr>
<td align="left" data-qa="votd_summary_link"><a href="https://www.linkedin.com/e/v2/pulse?e=6m81ta-ilj7lvs1-it&amp;a=pulse_web_vi%E2%80%A6p;li=14&amp;m=hero&amp;permLink=why-i-havent-worked-30-years-larry-wilmore" title="Why I Haven’t Worked in 30 Years"><img src="https://media.licdn.com/media/AAEAAQAAAAAAAAXcAAAAJDNhYzZmNjQzLTdiNzEtNDliMi05ZWIxLWQ1OGQ0MmE1YmJkOQ.png" alt="Highlight of the day" style="max-width:100%;border-width:0;"></a></td> <td align="left" data-qa="votd_summary_link"><a href="https://www.linkedin.com/e/v2/pulse?e=6m81ta-ilj7lvs1-it&amp;a=pulse_web_vi%E2%80%A6p;li=14&amp;m=hero&amp;permLink=why-i-havent-worked-30-years-larry-wilmore" title="https://www.linkedin.com/e/v2/pulse?e=6m81ta-ilj7lvs1-it&amp;a=pulse_web_vi%E2%80%A6p;li=14&amp;m=hero&amp;permLink=why-i-havent-worked-30-years-larry-wilmore"><img src="https://media.licdn.com/media/AAEAAQAAAAAAAAXcAAAAJDNhYzZmNjQzLTdiNzEtNDliMi05ZWIxLWQ1OGQ0MmE1YmJkOQ.png" alt="Highlight of the day" style="max-width:100%;border-width:0;"></a></td>
</tr> </tr>
<tr> <tr>
<td> <td>