From 93836f7973b9898629d67ea42896b9cff9337db2 Mon Sep 17 00:00:00 2001
From: Juan Tejada <juans.tejada@gmail.com>
Date: Thu, 23 Feb 2017 01:54:12 -0800
Subject: [PATCH] [iso-core] Fix imap error detection/coercion (again)

Summary:
If for whatever reason we passed an error with a `source` property
we weren't accounting for in `convertIMAPError`, we would return an
`undefined` error. Bad!

Instead, just return the original error

Test Plan: manual

Reviewers: spang, halla, evan, mark

Reviewed By: evan, mark

Differential Revision: https://phab.nylas.com/D4037
---
 packages/isomorphic-core/src/imap-errors.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/isomorphic-core/src/imap-errors.js b/packages/isomorphic-core/src/imap-errors.js
index 1222952e1..02ba0a8c9 100644
--- a/packages/isomorphic-core/src/imap-errors.js
+++ b/packages/isomorphic-core/src/imap-errors.js
@@ -75,7 +75,7 @@ class IMAPCertificateError extends NylasError { }
  *
  */
 function convertImapError(imapError) {
-  let error;
+  let error = imapError;
 
   if (imapError.message.toLowerCase().includes('try again')) {
     error = new RetryableError(imapError)
@@ -115,7 +115,7 @@ function convertImapError(imapError) {
     case "timeout-auth":
       error = new IMAPAuthenticationTimeoutError(imapError); break;
     default:
-      return error
+      break;
   }
   error.source = imapError.source
   return error