Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-09-11 07:04:33 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(undo-redo): Clear timeout when component unmounts to avoid React errors

Browse source
This commit is contained in:
Ben Gotow 2015-08-03 10:21:04 -07:00
parent b3f7e40588
commit 99da4a112a
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
internal_packages/undo-redo/lib/undo-redo-component.cjsx
View file

@ -28,7 +28,7 @@ class UndoRedoComponent extends React.Component
clearTimeout(@_timeout) clearTimeout(@_timeout)
_setNewTimeout: => _setNewTimeout: =>
clearTimeout(@_timeout) @_clearTimeout()
@_timeout = setTimeout (=> @_timeout = setTimeout (=>
@_hide() @_hide()
return return
@ -43,10 +43,11 @@ class UndoRedoComponent extends React.Component
return {show: s, task: t} return {show: s, task: t}
componentWillMount: -> componentWillMount: ->
@unsub = UndoRedoStore.listen(@_onChange) @_unsubscribe = UndoRedoStore.listen(@_onChange)
componentWillUnmount: -> componentWillUnmount: ->
@unsub() @_clearTimeout()
@_unsubscribe()
render: => render: =>
items = [].concat(@_renderUndoRedoManager()) items = [].concat(@_renderUndoRedoManager())