Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-23 15:46:28 +08:00
Code Issues Projects Releases Packages Wiki Activity

removes phishing warning for different subdomains (#2420)

Browse source 
This commit improves on nylas/N1#2343 (which allowed From and
Reply-To to be different aliases @ the same domain) by allowing the
address to differ by a subdomain.

For example, the pairs:

    From: foo@bar.com
    Reply-To: foo@sub.bar.com

    From: foo@bar.co.uk
    Reply-To: foo@other.bar.co.uk

    From: foo@bar.com
    Reply-To: foobar@bar.com
are each now allowed without warning.
This commit is contained in:
Ollie Ford 2016-07-08 19:20:19 +01:00 committed by Ben Gotow
parent e620b98d4c
commit 9b75ea72e6
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
internal_packages/phishing-detection/lib/main.jsx
View file

@ -7,6 +7,8 @@ import {
MessageStore,
} from 'nylas-exports';
const tld = require('tld');
// Notice that this file is `main.cjsx` rather than `main.coffee`. We use the
// `.cjsx` filetype because we use the CJSX DSL to describe markup for React to
// render. Without the CJSX, we could just name this file `main.coffee` instead.
@ -49,9 +51,9 @@ class PhishingIndicator extends React.Component {
// `Message` models from `MessageStore`.
if (message && message.replyTo && message.replyTo.length !== 0) {
const from = message.from[0].email
const fromDomain = from.split('@')[1];
const fromDomain = tld.registered(from.split('@')[1]);
const replyTo = message.replyTo[0].email
const replyToDomain = replyTo.split('@')[1];
const replyToDomain = tld.registered(replyTo.split('@')[1]);
if (replyToDomain !== fromDomain) {
return (
<div className="phishingIndicator">

1
internal_packages/phishing-detection/package.json
View file

@ -17,5 +17,6 @@
"composer": true
},
"dependencies": {
"tld": "^0.0.2"
}
}