Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-01 21:07:59 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(feedback): Links should open in the user's default browser

Browse source
This commit is contained in:
Ben Gotow 2015-10-22 11:34:51 -07:00
parent a83201ef7e
commit 9ff6c4912c
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
internal_packages/feedback/lib/feedback-button.cjsx
View file

@ -74,13 +74,21 @@ class FeedbackButton extends React.Component
'height': height, 'height': height,
'title': 'Feedback' 'title': 'Feedback'
onOpenURL = (event, href) ->
shell = require 'shell'
shell.openExternal(href)
event.preventDefault()
# Disable window close, hide instead # Disable window close, hide instead
w.on 'close', (event) -> w.on 'close', (event) ->
# inside the window we prevent close - here we route close to hide # inside the window we prevent close - here we route close to hide
event.preventDefault() # this does nothing, contrary to the docs event.preventDefault() # this does nothing, contrary to the docs
w.hide() w.hide()
w.on 'closed', (event) -> w.on 'closed', (event) ->
window.feedbackWindow = null # if the window does get closed, clear our ref to it # if the window does get closed, clear our ref to it
window.feedbackWindow = null
w.webContents.on('new-window', onOpenURL)
w.webContents.on('will-navigate', onOpenURL)
url = path.join __dirname, '..', 'feedback.html' url = path.join __dirname, '..', 'feedback.html'
w.loadUrl("file://#{url}?#{params}") w.loadUrl("file://#{url}?#{params}")