Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-10-06 11:16:10 +08:00
Code Issues Projects Releases Packages Wiki Activity

[client-sync] Don't double report refresh access token API errors

Browse source 
Summary:
Given that NylasAPIRequest reports all APIErrors for requests that
return 5xx, we were double reporting access token errors, which caused 2
groups in sentry and makes it difficult to track.

This commit removes the extra reporting for that error in the sync loop

Test Plan: manual

Reviewers: evan, khamidou, spang

Reviewed By: spang

Differential Revision: https://phab.nylas.com/D4098
This commit is contained in:
Juan Tejada 2017-03-06 08:15:05 -08:00
parent 8bd686bc6e
commit a041b79aaa
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/client-app/src/flux/nylas-api-request.es6
View file

@ -124,7 +124,7 @@ export default class NylasAPIRequest {
] ]
if (!ignorableStatusCodes.includes(apiError.statusCode)) { if (!ignorableStatusCodes.includes(apiError.statusCode)) {
const msg = apiError.message || `Unknown Error: ${apiError}` const msg = apiError.message || `Unknown Error: ${apiError}`
const fingerprint = ["{{ default }}", "local api", apiError.statusCode, msg]; const fingerprint = ["{{ default }}", "api error", apiError.statusCode, msg];
NylasEnv.reportError(apiError, {fingerprint: fingerprint}); NylasEnv.reportError(apiError, {fingerprint: fingerprint});
apiError.reported = true apiError.reported = true
} }

6
packages/client-sync/src/local-sync-worker/sync-worker.es6
View file

@ -192,12 +192,6 @@ class SyncWorker {
const {statusCode} = err const {statusCode} = err
this._logger.error(`🔃 Unable to refresh access token. Got status code: ${statusCode}`, err); this._logger.error(`🔃 Unable to refresh access token. Got status code: ${statusCode}`, err);
if (statusCode >= 500) {
// Even though we don't consider 500s as permanent errors when
// refreshing tokens, we want to report them
const fingerprint = ["{{ default }}", "access token refresh", statusCode, err.message];
NylasEnv.reportError(err, {fingerprint: fingerprint})
}
const isNonPermanentError = ( const isNonPermanentError = (
// If we got a 5xx error from the server, that means that something is wrong // If we got a 5xx error from the server, that means that something is wrong
// on the Nylas API side. It could be a bad deploy, or a bug on Google's side. // on the Nylas API side. It could be a bad deploy, or a bug on Google's side.